Commit Graph

302 Commits

Author SHA1 Message Date
Vladislav Bolkhovitin
49c56244a1 Fix 3.3 checkpatch warnings about min()and max()
Fix three occurrences of the following warnings reported by the checkpatch
script included with Linux kernel version 3.3:
WARNING: min() should probably be min_t()
WARNING: max() should probably be max_t()

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4172 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-03-27 01:46:51 +00:00
Vladislav Bolkhovitin
90670b1c83 scst_rx_mgmt_fn_lun(): Change 3rd arg from u8 * into void *
This change allows to remove several casts and hence improves
source code readability.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4169 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-03-27 01:40:45 +00:00
Vladislav Bolkhovitin
d5ffb2234b Cleanup mgmt parameters initialization.
It's better to do it via a single function.

Patch from Alexey Obitotskiy <alexeyo1@open-e.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4165 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-03-23 22:03:22 +00:00
Vladislav Bolkhovitin
937b2d550d Update for kernel 3.3
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4164 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-03-23 21:48:11 +00:00
Vladislav Bolkhovitin
50120c37b3 scst_cmd_aborted() is a bad and ambiguous name. Rename it to scst_cmd_aborted_on_xmit() and create a new version, which truly reflects its semantic.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4143 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-02-24 02:24:06 +00:00
Bart Van Assche
f944799e42 iscsi-scst: Port to RHEL 5.7
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4112 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-02-04 16:41:21 +00:00
Vladislav Bolkhovitin
8e5eafb7c3 Forgotten tcp_zero_copy.c added
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4080 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-01-20 03:13:11 +00:00
Vladislav Bolkhovitin
9da517bae1 Update for kernel 3.2. Netlink part in iSCSI-SCST done by Bart Van Assche <bvanassche@acm.org>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4077 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-01-18 23:48:02 +00:00
Vladislav Bolkhovitin
b31865ea69 Update of put_page_callback-2.6.32-220.patch from Patrick Zwahlen <paz@navixia.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4064 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-01-12 03:22:09 +00:00
Vladislav Bolkhovitin
f6ba6aaf43 Patch from Richard Sharpe <realrichardsharpe@gmail.com> implementing put_page_callback patch for CentOS 6.2/RHEL 6.2
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4057 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-01-10 03:02:24 +00:00
Vladislav Bolkhovitin
7872837b6b Replace list_entry((a)->next, b, c) by list_first_entry(a, b, c).
BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3965 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-12-10 03:50:24 +00:00
Vladislav Bolkhovitin
69d8c2fbd7 Change __attribute__((packed)) into __packed and
__attribute__((aligned(x))) into __aligned(x) in kernel code since
checkpatch complains about the former.

BSD-signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3952 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-12-06 03:02:13 +00:00
Vladislav Bolkhovitin
295adebc0f Use get/put_unaligned_be<n>(...) instead of
get/put_unaligned(cpu_to_be<n>(...)).

BSD-Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3941 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-12-01 03:28:39 +00:00
Vladislav Bolkhovitin
57193ecabc Those patches were mistakenly generated for patch -p0. Fix it. Thanks
Bart Van Assche for reporting it.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3926 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-11-16 19:21:30 +00:00
Vladislav Bolkhovitin
c95ef014d7 Update for kernel 3.1
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3902 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-10-27 19:11:40 +00:00
Bart Van Assche
74264389cd scst: Add script for rebuilding RHEL / CentOS / Scientific Linux kernel RPMs
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3890 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-10-05 17:14:23 +00:00
Bart Van Assche
49147b3d8d Change __constant_cpu_... into cpu_... since the latter is also evaluated at compile time.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3806 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-08-14 19:03:03 +00:00
Bart Van Assche
705c3754a2 Remove superfluous double quotes from around #warning messages because checkpatch 3.0 complains about these.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3789 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-07-29 12:58:13 +00:00
Vladislav Bolkhovitin
90aa221cbb Update for kernels 3.0
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3775 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-07-27 01:13:10 +00:00
Vladislav Bolkhovitin
654cc65319 put_page_callback patch for RHEL61 implemented by Patrick Zwahlen <paz@navixia.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3673 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-07-16 03:41:06 +00:00
Bart Van Assche
834015970b Add iscsi-scst/kernel/patches/rhel/put_page_callback_addendum-rhel6.patch
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3656 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-07-04 16:20:23 +00:00
Vladislav Bolkhovitin
daa5da87af Several wait loops in the SCST source code are similar. Move the common code
into a new macro called wait_event_locked().

Signed-off-by: Bart Van Assche <bvanassche@acm.org>

+

Micro-optimize wait_event_locked(). Switch from default_wake_function() to
autoremove_wake_function() (via DEFINE_WAIT()). The result is that
wait_queue_head_t.lock is locked once instead of twice for wakeup + wait queue
removal.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3591 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-06-18 21:15:59 +00:00
Vladislav Bolkhovitin
2f1745eec1 Set data_out_in_data_receiving for preliminary completed commands as
well to prevent releasing them too early in iscsi_check_tm_data_wait_timeouts()



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3546 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-06-06 21:04:04 +00:00
Bart Van Assche
beeef55b6f Use __packed instead of __attribute__((packed)).
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3500 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-06-01 10:40:07 +00:00
Bart Van Assche
375597fedf iSCSI-SCST: only define __packed for those kernels versions that do not have a definition for __packed.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3498 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-06-01 08:03:32 +00:00
Bart Van Assche
4839c8167f iscsi-scst: get rid of two "suspect code indent for conditional statements" checkpatch complaints.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3497 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-06-01 07:19:12 +00:00
Bart Van Assche
c37081aed5 Move spaces in long #warning/#error lines to the end of the previous line to shut up checkpatch.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3495 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-06-01 06:59:40 +00:00
Bart Van Assche
b901fe2958 iSCSI-SCST builds again on RHEL 5.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3488 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-05-28 10:37:46 +00:00
Vladislav Bolkhovitin
b5a41deb28 Update for 2.6.39
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3462 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-05-20 00:52:34 +00:00
Vladislav Bolkhovitin
c54ebba11a Some more TM cleanups/improvements
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3460 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-05-18 21:45:09 +00:00
Bart Van Assche
fc82862369 iscsi-scst: Fixed a compilation error that only occurred with GENERATING_UPSTREAM_PATCH defined.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3452 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-05-13 06:13:52 +00:00
Vladislav Bolkhovitin
5e7544e5a4 TM handling fixes, part2, hopefully, final.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3450 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-05-12 01:31:01 +00:00
Bart Van Assche
663d39f1ea iscsi-scst/kernel/iscsi.c: fix a checkpatch complaint about whitespace.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3447 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-05-11 11:00:01 +00:00
Vladislav Bolkhovitin
70eb596f60 Rework iSCSI aborts to make them more correct and remove recent workarounds (one more post-IET cleanup)
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3444 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-05-09 23:07:23 +00:00
Vladislav Bolkhovitin
f9cbfe51cd RHEL5/6 workaround
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3438 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-05-03 21:27:30 +00:00
Vladislav Bolkhovitin
8443ae6bc7 Don't abort not yet received commands
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3425 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-04-29 19:54:13 +00:00
Vladislav Bolkhovitin
c5b9c85591 - More timers improvements
- Cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3421 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-04-26 19:07:13 +00:00
Vladislav Bolkhovitin
08ab8e40be Rerference on the orig cmd should be taken during data out processing to correctly perform aborts
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3414 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-04-26 00:06:23 +00:00
Vladislav Bolkhovitin
3c59daab2a Correctly process being read cmd during abort
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3413 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-04-26 00:04:01 +00:00
Vladislav Bolkhovitin
64065a21e9 NOP-In/response timeouts improvements
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3411 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-04-25 23:50:49 +00:00
Bart Van Assche
d1acc24bed Suppress gcc 4.6 warnings about unused variables.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3350 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-04-03 14:34:48 +00:00
Vladislav Bolkhovitin
bfacd754f6 Fixes for make headers_check
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3330 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-04-01 18:15:29 +00:00
Vladislav Bolkhovitin
d77d19286f TRACE_OUT_OF_MEM cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3329 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-04-01 17:43:46 +00:00
Vladislav Bolkhovitin
4539005d7c Patch from Alexey Obitotskiy <alexeyo1@open-e.com> making get_initiator_port_transport_id() more flexible
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3322 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-03-29 14:30:01 +00:00
Vladislav Bolkhovitin
16f654b5ad Update for 2.6.38
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3294 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-03-21 14:10:50 +00:00
Bart Van Assche
ce918fa396 Spelling fix (in source code comments): reaquire -> reacquire.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3265 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-02-27 09:46:41 +00:00
Vladislav Bolkhovitin
411fb4f623 - Update for 2.6.37
- Docs updated
 - Returning of DIRECT contexts by scst_estimate_context() disabled (see comment in the patch why)



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3203 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-01-10 18:34:29 +00:00
Vladislav Bolkhovitin
f3238333dd Copyrights updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3200 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-01-06 20:02:04 +00:00
Bart Van Assche
1b72343266 Added "const" to keep checkpatch happy.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3191 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-01-05 13:14:25 +00:00
Bart Van Assche
3d707844b0 put_page_callback-2.6.37.patch: diff minimizing / added a missing file.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3029 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-12-12 12:22:10 +00:00