Commit Graph
44 Commits
Author SHA1 Message Date
Bart Van Assche 68edb1a296 Copyright updates + iscsi-scst bug fix (merge r4216 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.x@4704 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-01-06 14:03:57 +00:00
Vladislav Bolkhovitin a2f4d66bc8 Merge of the trunk's r3552:
Errors reporting fixes



git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.1.0.x@3554 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-06-07 18:22:22 +00:00
Vladislav Bolkhovitin aa72d67856 Patch from Stefan Hauser <st.hauser@googlemail.com> with some style changes fixing case when after a error
between sessions_count increment and the corresponding session creation, sessions_count is not decremented.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3353 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-04-04 17:58:59 +00:00
Vladislav Bolkhovitin 2a230b19ee Errors reporting cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3245 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-02-09 22:48:24 +00:00
Vladislav Bolkhovitin f3238333dd Copyrights updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3200 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-01-06 20:02:04 +00:00
Vladislav Bolkhovitin e24296ad98 Fix case when after INCOMING_MAX overflow no listen events requested to be provided by poll().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3088 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-12-15 15:48:51 +00:00
Vladislav Bolkhovitin 492e33a312 - Move nl_open() after kernel_open() to avoid issues when second start could skrew netlink states for the first instance
- Avoid compiler warn_unused_result warning



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1837 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-07-17 16:44:22 +00:00
Vladislav Bolkhovitin ec3640be0b Partially merge of IET r307: allows to redirect initiators to another portals
+
Cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1735 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-03 19:17:52 +00:00
Vladislav Bolkhovitin 459f589b34 - Delivery error response (instead of dropping connection) fixed
- Race when target deleted before the session(s) removal event(s) processed fixed
 - Docs updated



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1733 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-01 18:28:41 +00:00
Vladislav Bolkhovitin 5406a07d26 Various iSCSI initiators access control and visibility improvements. Particularly:
- SendTargets now returns all (allowed) portals. Particularly based on IET r230, 234, 249 and 264.
 - Initiators assigned to security groups without LUNs will not see the target during discovery and forbidden to login to it
 - Per portals access control added
 - Negative sign added to wildcard matching
 - Docs updated
 - Cleanups and minor fixes



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1685 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-05-07 18:08:52 +00:00
Vladislav Bolkhovitin 7d218fb344 States cleanup and fix related login problem
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1650 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-23 11:26:39 +00:00
Vladislav Bolkhovitin f025190b53 - Loosly merge of IET r271: fix connection and session leak on connection preparation stages
- Cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1645 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-21 22:17:43 +00:00
Vladislav Bolkhovitin 623c62d339 IET r219: Fixed log_debug to properly evaluate logging level.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1640 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-21 17:51:50 +00:00
Vladislav Bolkhovitin 4d5aaf047b Copyrights updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1585 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-06 08:57:48 +00:00
Vladislav Bolkhovitin 08e7c3fba6 Great threads handling and performance improvements:
- io_context not needed anymore

 - Now threads pool can be per session

 - Each device now can have own type of threads pool with own threads count

+ docs updates and some cleanups and minor fixes.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1563 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-03-25 19:43:41 +00:00
Vladislav Bolkhovitin 1f216064f3 Uniform max queue depth handling in iSCSI
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1556 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-03-18 11:44:39 +00:00
Vladislav Bolkhovitin 4d96089e50 Sysfs interface for targets made uniform. ISCSI-SCST made confirming the uniformity requirements. See README for details.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1511 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-17 19:07:54 +00:00
Vladislav Bolkhovitin f519e2c265 Fix spelling typos.
Signed-off-by: Dotan Barak <dotanba@gmail.com>

with additional spelling fixes noticed by frank zago <fzago@systemfabricworks.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1396 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-12-16 11:35:12 +00:00
Vladislav Bolkhovitin c918eb371e gcc 4.4.1 (as included in openSUSE 11.2) complains about the user-space iSCSI code because it breaks strict-aliasing rules. The reported warnings should be addressed because not doing so can result in the compiler generating incorrect code. The patch below fixes these compiler warnings.
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1352 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-11-20 19:53:12 +00:00
Vladislav Bolkhovitin 6153a079a3 iSCSI target sysfs "enabled" attribute implemented
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1324 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-11-06 18:41:37 +00:00
Bart Van Assche 6a80e5441e Removed trailing whitespace.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@905 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-06-16 06:29:04 +00:00
Vladislav Bolkhovitin f572d4ff79 - Copyrights updated.
- Other minor updates



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@803 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-04-27 19:01:28 +00:00
Vladislav Bolkhovitin 27c5d8dcdf The patch below fixes the following recently introduced checkpatch complaints:
* use tabs not spaces
* Macros with complex values should be enclosed in parenthesis.
* printk() should include KERN_ facility level.
The patch below has been verified by reviewing it carefully and by verifying the output of the following command: scripts/run-regression-tests -k 2.6.28.8

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@707 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-03-20 12:36:01 +00:00
Vladislav Bolkhovitin e252aadf35 - Fixed problems in reading iscsi-scst.conf
- Cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@698 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-03-17 18:00:26 +00:00
Vladislav Bolkhovitin bda620b65a - Connection reinstatement fixes
- Minor cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@687 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-03-04 18:31:35 +00:00
Vladislav Bolkhovitin bc7c69bfc4 - Fixed a major IET-derived iSCSI RFC violation: sessions and connections were not working
- A lot of cleanups and minor fixes, mostly IET-derived



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@685 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-03-03 18:13:23 +00:00
Vladislav Bolkhovitin 293c0ee1a3 - Iscsi-scst-adm fixes. It should be fully functional now.
- Other iSCSI-SCST user space fixes, improvements and cleanups.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@667 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-02-06 19:52:34 +00:00
Vladislav Bolkhovitin 922c377cd2 Merge with IET r195:
From: Lars Ellenberg <lars.ellenberg@linbit.com>

Ignore SIGPIPE in ietd

Otherwise we would die in some later write() during the event_loop
instead of getting EPIPE!



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@652 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-01-30 16:41:22 +00:00
Vladislav Bolkhovitin 684719c66e Merge with IET r170-191:
- Update MaxConnections documentation
 - Remove isns config description from man page
 - Check return values of chdir(), ftruncate() and write(), because recent versions of the glibc insist on the return value being checked by
introducing __attribute__((warn_unused_result)) to these functions.
 - Fix snprintf use in isns.c
 - Take \0-termination into account when passing strings to isns_tlv_set() to solve incompatibility with MS iSNS 3.0 as IQN length is multiple of 4
 - Fix list corruption if SCST target registration fails
 - Register the target port actually used instead of the default iSCSI port.
 - Remove unused connection->pad
 - Refactor cmnd_execute()
 - Version changed



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@649 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-01-29 19:10:10 +00:00
Vladislav Bolkhovitin 5b6ba1d246 Added error message for a kernel bug, which doesn't allow for poll() to work with >256 file descriptors and prevents iscsi-scstd to start.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@416 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-06-18 09:54:38 +00:00
Vladislav Bolkhovitin 20a2e4ae8d Copyrights updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@408 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-06-12 11:39:28 +00:00
Vladislav Bolkhovitin dbf723a163 - Fixed one more 32/64 bits user/kernel incompatibility
- Minor fixes


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@396 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-05-26 11:00:19 +00:00
Vladislav Bolkhovitin 2261eaec3e - Fixed problems with 64-bit platforms with 32-bit user space and with non-4K pages
- From the main Makefile all all LSI/MPT related targets are commented out, because the recent changes in its Makefile have broken them.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@391 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-05-23 15:12:34 +00:00
Vladislav Bolkhovitin 1213800b2f Patch from Bart Van Assche <bart.vanassche@gmail.com>, except few chuncks from qla2x00t/ obviously not related to the target mode addon:
One of the Linux kernel patch submission requirements is that source files do
not contain trailing whitespace. The patch below removes trailing whitespace
from .c and .h source files.

Note: it might be more convenient to run the script I used to generate this
patch than to review and apply the patch below. This is how I generated and
verified the patch below:

cat <<EOF >./strip-trailing-whitespace
#!/bin/bash
trap "rm -f $t" EXIT
t=/tmp/temporary-file.$$
for f in "$@"
do
  sed 's/[	 ]*$//' <"$f" >"$t" && mv "$t" "$f"
done
EOF
chmod a+x ./strip-trailing-whitespace
find -name '*.[ch]' | xargs ./strip-trailing-whitespace
svn diff -x -w

Signed-off-by: <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@377 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-05-19 10:21:41 +00:00
Vladislav Bolkhovitin cc685733a5 Interface versioning between iSCSI-SCST kernel and user space parts, iscsi_u.h renamed to iscsi_scst.h. Property svn:ignore adjusted accordingly. Docs updated.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@371 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2008-05-14 17:20:20 +00:00
Vladislav Bolkhovitin d0dcc1a584 Patches from Arne Redlich <agr@powerkom-dd.de>:
1. The kernel's log level is a string, so strcmp needs to be used for
comparisons.

2. Svn HEAD doesn't compile against kernel versions < 2.6.19 because
"bool" had its debut only in 2.6.19. Here's a quick fix.

3. Iscsi-scstd dies with SIGPIPE if run in foreground mode because the reading
end of the init_report_pipe is already closed in this mode.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@238 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2007-12-24 10:20:18 +00:00
Vladislav Bolkhovitin 1e18aabf3a - Implement SN based iSCSI IO flow control
- ABORT_CONSIDER_FINISHED_TASKS_AS_NOT_EXISTING compilation symbol added
 - TM fixes and cleanups
 - Fixes crash on modprobe with some real devices


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@233 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2007-12-13 18:28:34 +00:00
Vladislav Bolkhovitin ffb60ac8fc Now if iSCSI daemon fails to load config file, it fails to load.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@221 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2007-11-13 17:28:28 +00:00
Vladislav Bolkhovitin 2de18c7c7a - Now iSCSI target service load considered successful if at least one listen socket was successfully open and setup
- Minor race on BLOCKIO requests submittion was fixed
 - Other minor fixes and cleanups


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@220 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2007-11-12 11:21:54 +00:00
Vladislav Bolkhovitin 9120a41d61 - Fixed ignoring errors on the service start. Reported by Tomasz Chmielewski <mangoo@wpkg.org>
- Minor fixes


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@212 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2007-10-25 16:19:40 +00:00
Vladislav Bolkhovitin a8c124da1b - Fixes 2 shutdown problems
- Cosmetics


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@204 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2007-10-02 15:04:04 +00:00
Vladislav Bolkhovitin 5380955523 - Increased INCOMING_MAX as suggested in http://blog.wpkg.org/2007/09/09/solving-reliability-and-scalability-problems-with-iscsi/.
- Minor Makefile fixes


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@200 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2007-09-25 13:39:25 +00:00
Vladislav Bolkhovitin d224057476 Copyrights updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@166 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2007-08-23 15:28:18 +00:00
Vladislav Bolkhovitin e6a57baa14 The initial commit of iSCSI-SCST
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@162 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2007-08-15 09:28:54 +00:00