Commit Graph
9244 Commits
Author SHA1 Message Date
Bart Van Assche ee1c55ba6c qla2x00t-32gbit: Fix possible fcport null-pointer dereferences
In qla2x00_alloc_fcport(), fcport is assigned to NULL in the error
handling code on line 4880:
    fcport = NULL;

Then fcport is used on lines 4883-4886:
    INIT_WORK(&fcport->del_work, qla24xx_delete_sess_fn);
	INIT_WORK(&fcport->reg_work, qla_register_fcport_fn);
	INIT_LIST_HEAD(&fcport->gnl_entry);
	INIT_LIST_HEAD(&fcport->list);

Thus, possible null-pointer dereferences may occur.

To fix these bugs, qla2x00_alloc_fcport() directly returns NULL
in the error handling code.

These bugs are found by a static analysis tool STCheck written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

[ commit e82f04ec6ba91065fd33a6201ffd7cab840e1475 upstream ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8629 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-11-03 00:17:56 +00:00
Bart Van Assche abc8e3cfa1 qla2x00t-32gbit/Makefile: Add SPDX License Identifier
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8628 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-11-03 00:17:17 +00:00
Bart Van Assche 6448d4a1b3 qla2x00t-32gbit, qla_isr.c: Minimize diffs with the upstream code
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8627 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-11-03 00:16:45 +00:00
Bart Van Assche fed017ba44 qla2x00t-32gbit, qla_gs.c: Minimize diffs with the upstream code
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8626 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-11-03 00:16:28 +00:00
Bart Van Assche 18879e695f qla2x00t-32gbit, qla_bsg.c: Minimize diffs with the upstream code
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8625 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-11-03 00:16:12 +00:00
Bart Van Assche 81c207d37d qla2x00t-32gbit, qla_isr.c: Minimize diffs with the upstream code
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8624 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-11-03 00:15:34 +00:00
Bart Van Assche a50b32ca42 isert-scst: Change unlikely(IS_ERR(...)) into IS_ERR(...)
Surrounding IS_ERR(...) with unlikely() is redundant. Remove the redundant
unlikely() annotations.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8623 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-11-02 23:03:18 +00:00
Bart Van Assche 37269436b0 Merge branch 'svn-trunk' 2019-11-02 15:59:51 -07:00
Bart Van Assche 6dcb32a5ca ibmvstgt, mpt and mvsas_tgt: Remove these drivers
These drivers have not been updated in a significant way since 2010.
Additionally, these drivers fail to build against recent kernel versions.
I think this means that nobody is using these drivers. Hence remove these
drivers from the trunk.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8622 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-11-02 22:59:21 +00:00
Bart Van Assche a339814d70 Merge branch 'svn-trunk' 2019-10-14 21:45:53 -07:00
Bart Van Assche c02e4209a4 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8621 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-15 04:45:43 +00:00
Bart Van Assche 96bf8938ef Merge branch 'svn-trunk' 2019-10-14 21:15:56 -07:00
Bart Van Assche 5de1135f8e scst: Remove all references to the QLogic git tree
Since the driver in the qla2x00t-32gbit directory supersedes the driver from
the QLogic git tree, remove all references to the latter.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8620 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-15 04:15:49 +00:00
Bart Van Assche 00c36eb7d6 Merge branch 'svn-trunk' 2019-10-13 14:30:24 -07:00
Bart Van Assche c027b9de7e scst: Port to UEK 4
Reported-by: Gilbert Standen <gilstanden@hotmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8619 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-13 21:28:19 +00:00
Bart Van Assche 0c2a242249 .gitignore: Update
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8618 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-13 21:21:58 +00:00
Bart Van Assche 659569506c Merge branch 'svn-trunk' 2019-10-10 19:08:37 -07:00
Bart Van Assche a444b28dfa scripts/sign-modules: Do not try to sign modules CONFIG_MODULE_SIG=n
This fixes the build on e.g. Debian 9. See also
https://sourceforge.net/p/scst/tickets/30/.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8617 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-11 02:08:09 +00:00
Bart Van Assche db05d0f29e Merge branch 'svn-trunk' 2019-10-08 19:57:44 -07:00
Bart Van Assche 8dbffe9b25 scst-dkms.spec.in: Sync with scst.spec.in
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8616 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-09 02:57:22 +00:00
Bart Van Assche 5d3e3e9590 scripts/specialize-patch: Port to RHEL 8
Signed-off-by: Ivan Orlov <orlov@soligran.ru>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8615 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-09 02:41:48 +00:00
Bart Van Assche 4c32934243 iscsi-scst/Makefile_user_space_only: Synchronize this file with iscsi-scst/Makefile
Signed-off-by: Ivan Orlov <orlov@soligran.ru>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8614 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-09 02:40:14 +00:00
Bart Van Assche 36e4ee26bb scst/include/backport.h: Include <linux/blk-mq.h> on RHEL 8
This patch is a build fix for RHEL 8.

Signed-off-by: Ivan Orlov <orlov@soligran.ru>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8613 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-09 02:39:44 +00:00
Bart Van Assche 1e79f561bc scst.spec.in: Make this spec file compatible with rpm v4.14
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8612 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-09 02:17:11 +00:00
Bart Van Assche a504222723 scst/src/Makefile: Specify the installation directory for device handlers explicitly
This patch unbreaks 'make rpm' against Linux kernel v5.3.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8611 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-09 02:16:28 +00:00
Bart Van Assche 87d64c162d scst: Unbreak the build for RHEL 6 / CentOS 6
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8610 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-09 01:33:25 +00:00
Bart Van Assche 4dcc67a224 Merge branch 'svn-trunk' 2019-10-06 16:54:15 -07:00
Bart Van Assche 7b8c92e151 scst: Fix latency measurements if multiple commands are processed simultaneously by a single thread
Signed-off-by: Lev Vainblat <lev@zadarastorage.com>
[ bvanassche: reordered scst_cmd members ]


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8608 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 23:52:51 +00:00
Bart Van Assche 64e4230271 Merge branch 'svn-trunk' 2019-10-06 16:30:10 -07:00
Bart Van Assche 8df56e2ea3 scripts/sign-modules: Fix module signing for Debian
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8607 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 23:24:06 +00:00
Bart Van Assche 948b693ab1 Merge branch 'svn-trunk' 2019-10-06 15:10:51 -07:00
Bart Van Assche 23f7283906 scst/include/scst.h: Reduce the size of struct scst_cmd
Reduce the size of struct scst_cmd by reordering its structure members such
that there are two holes less in this data structure. This change has been
verified with the help of the 'pahole' tool.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8606 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 22:10:31 +00:00
Bart Van Assche 7852d95428 Merge branch 'svn-trunk' 2019-10-06 14:39:41 -07:00
Bart Van Assche b4f893a009 Update Subversion ignore lists
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8605 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 21:39:25 +00:00
Bart Van Assche 20be212509 Update Subversion ignore lists
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8604 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 21:37:43 +00:00
Bart Van Assche ea2d6ac0d9 scst/include/backport.h: Sort alphabetically
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8603 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 21:31:20 +00:00
Bart Van Assche 9c96ba8752 Merge branch 'svn-trunk' 2019-10-06 14:10:41 -07:00
Bart Van Assche 3d5a5078ca contributing.html: Remove information about already implemented features
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8602 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-06 00:01:20 +00:00
Bart Van Assche cb73881c46 www: Update copyright footer
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8601 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-05 23:36:37 +00:00
Bart Van Assche 821116f242 www/downloads.html: Remove links to binary versions of SCST 1.0.1
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8600 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-05 23:34:56 +00:00
Bart Van Assche 21a053c5d0 Merge branch 'svn-trunk' 2019-10-05 16:05:01 -07:00
Bart Van Assche ed68f1cb43 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8599 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-10-05 21:34:55 +00:00
Bart Van Assche 6caccfa149 Merge branch 'svn-trunk' 2019-09-29 18:03:40 -07:00
Bart Van Assche b33060cdd8 nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8598 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-30 01:03:27 +00:00
Bart Van Assche ab52602cc7 Merge branch 'svn-trunk' 2019-09-29 16:36:07 -07:00
Bart Van Assche 982e33160f scripts/specialize-patch: Fix a gawk warning
gawk: scripts/specialize-patch:329: (FILENAME=- FNR=26) warning: regexp escape sequence `\&' is not a known regexp operator



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8597 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-29 23:13:49 +00:00
Bart Van Assche 4ff23a3f33 Merge branch 'svn-trunk' 2019-09-29 15:39:59 -07:00
Bart Van Assche 9add460430 Suppress module signing error messages
Suppress the following error messages:

- SSL error:02001002:system library:fopen:No such file or directory: crypto/bio/bss_file.c:72
- SSL error:2006D080:BIO routines:BIO_new_file:no such file: crypto/bio/bss_file.c:79
sign-file: certs/signing_key.pem: No such file or directory

 


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8596 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-29 22:33:03 +00:00
Bart Van Assche 81fbece669 Merge branch 'svn-trunk' 2019-09-29 15:18:03 -07:00
Bart Van Assche 06ee7ca41d Makefile: Unbreak the RPM build process
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8595 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-09-29 22:10:46 +00:00