mirrors/scst
1
0
Fork 0
mirror of https://github.com/SCST-project/scst.git synced 2026-05-17 10:41:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,883 Commits 26 Branches 11 Tags
38f2e60dfd97ffadf5c77f02231852fe1aec9e4e
Commit Graph

288 Commits

Author SHA1 Message Date
Bart Van Assche
edac418f66 SRP_CRED_REQ autodetection is now disabled by default. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2026 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-31 06:30:59 +00:00
Bart Van Assche
725e090a94 Print an informational message instead of an error message for MRA (Message 
Receipt Acknowledgement) messages.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2016 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-28 07:12:26 +00:00
Bart Van Assche
0e56ff520e Updated HA section. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1972 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-22 19:02:26 +00:00
Bart Van Assche
84649a0e60 Reverted r1442. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1971 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-21 15:58:47 +00:00
Bart Van Assche
314c1a5750 Documentation update. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1966 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-21 08:45:49 +00:00
Bart Van Assche
6c3b1e55be Corrected an error message. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1965 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-21 08:27:28 +00:00
Bart Van Assche
894190c09e Removed superfluous __attribute__((packed)). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1952 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-15 10:02:10 +00:00
Bart Van Assche
ed195d5e4f Added more comments. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1939 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-06 17:28:04 +00:00
Bart Van Assche
23a55be361 Fixed a compiler warning that was only reported on RHEL 5.x. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1905 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-02 17:01:06 +00:00
Bart Van Assche
e30376945f Changes: 
- Made sure that in mode thread=1 not only send completions but also receive completions are processed in thread context.
- Merged IB send and receive completion queues again such that both types of completions are processed in a fairly.

git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1904 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-02 16:50:14 +00:00
Bart Van Assche
a851118fe6 Avoid that /sys/module/ib_srpt/parameters/srpt_service_guid contains a double newline. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1902 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-01 19:12:34 +00:00
Bart Van Assche
02d6dc9860 Functional changes: 
- Changed default value for the kernel module parameter thread from 0 to 1 because mode 0 can trigger soft lockup complaints under sufficient load.
- Changed default value for the kernel module parameter srpt_autodetect_cred_req from false to true.
Non-functional changes:
- Removed several superfluous casts in ib_srpt.c.
Performance-related changes:
- Rearranged if/then/else statements such that the most frequently executed code occurs first.
- When SCST_MAX_TGT_DEV_COMMANDS > 128, the SRP receive queue size is now SCST_MAX_TGT_DEV_COMMANDS instead of 128.
Bug fixes:
- Fixed performance bug in modes thread=0 and 2.
- Fixed a bug in IB send queue overflow handling.
- Fixed race related to IB completion thread creation (mode thread=1).
- Made sure that the following warning is no longer triggered during module removal:
WARNING: at fs/proc/generic.c:825 remove_proc_entry+0x261/0x2f0()
Call Trace:
 [<ffffffff8104d74b>] warn_slowpath_common+0x7b/0xc0
 [<ffffffff8104d7f1>] warn_slowpath_fmt+0x41/0x50
 [<ffffffff8116e8a1>] remove_proc_entry+0x261/0x2f0
 [<ffffffff810832c8>] ? debug_check_no_locks_freed+0xc8/0x150
 [<ffffffff81082ecb>] ? mark_held_locks+0x6b/0xa0
 [<ffffffff8110f95f>] ? kfree+0xcf/0x180
 [<ffffffff810831a5>] ? trace_hardirqs_on_caller+0x145/0x190
 [<ffffffff810831fd>] ? trace_hardirqs_on+0xd/0x10
 [<ffffffffa05835c2>] srpt_unregister_procfs_entry+0x22/0x40 [ib_srpt]
 [<ffffffffa0583aba>] srpt_release+0x8a/0x1a0 [ib_srpt]
 [<ffffffffa04cbcc0>] scst_unregister_target+0x70/0x3f0 [scst]
 [<ffffffff811bf6d7>] ? kobject_put+0x27/0x60
 [<ffffffff8126ff67>] ? put_device+0x17/0x20
 [<ffffffffa058587e>] srpt_remove_one+0xee/0x1a0 [ib_srpt]
 [<ffffffffa03ddfc5>] ib_unregister_client+0x65/0x120 [ib_core]
 [<ffffffffa0588f43>] srpt_cleanup_module+0x5f/0xc3 [ib_srpt]
 [<ffffffff8108e8dd>] sys_delete_module+0x1bd/0x280
 [<ffffffff8135e5ad>] ? retint_swapgs+0xe/0x13
 [<ffffffff810831a5>] ? trace_hardirqs_on_caller+0x145/0x190
 [<ffffffff810030db>] system_call_fastpath+0x16/0x1b
---[ end trace 3fc26663490f6a89 ]---

git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1901 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-01 14:40:54 +00:00
Bart Van Assche
1590390350 Reordered two fields in struct srpt_rdma_ch. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1900 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-08-01 12:47:00 +00:00
Bart Van Assche
d402b1e851 Command abortion bug fix. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1899 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-30 15:28:56 +00:00
Bart Van Assche
b9c3b09613 Checkpatch fix. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1898 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-30 15:03:04 +00:00
Bart Van Assche
7ef2bc926e Made ib_srpt_compl kernel thread logging more detailed. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1897 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-30 14:53:22 +00:00
Bart Van Assche
02cfb12400 Fixed a bug in the algorithm that decides when to send SRP_CRED_REQ. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1896 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-30 14:45:41 +00:00
Bart Van Assche
ffe7409533 Changed behavior of mode thread=1: IB completions are now entirely processed on thread context and there is now one thread per session instead of one thread for all sessions. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1895 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-30 14:32:44 +00:00
Bart Van Assche
49cbea848a Dynamically decrease the initiator's SRP queue depth if it supports SRP_CRED_REQ and scst_get_max_lun_commands(NULL, 0) (48 with unmodified scst_priv.h) is less than SRPT_RQ_SIZE (128 with unmodified ib_srpt.h). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1894 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-30 11:26:40 +00:00
Bart Van Assche
9ce80877d2 Added support for SRP_CRED_REQ and auto-detection of initiator SRP_CRED_REQ support (disabled by default). 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1891 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-29 14:21:16 +00:00
Bart Van Assche
f299b1d2b3 Micro-optimization: replaced a spinlock by an atomic variable. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1882 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-28 10:15:33 +00:00
Bart Van Assche
803a312144 Replaced busy-waiting for more credits by wait_for_completion(). 
Moved processing delay loop out of interrupt context.
Preparations for SRP_CRED_REQ support and run-time receive queue selection.

git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1880 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-27 16:23:45 +00:00
Bart Van Assche
8873db3eb6 Split a line. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1879 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-27 16:07:30 +00:00
Bart Van Assche
747511e3b8 IB verbs compliance fix: drain the completion queues before destroying them. 
Moved some thread=1 related functions in ib_srpt.c such that these are grouped in the source file.

git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1876 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-25 13:13:45 +00:00
Bart Van Assche
0925119ad8 Made sure that invocation of srpt_pending_cmd_timeout() after 
srpt_handle_rdma_comp() finished and before srpt_xmit_response() started works
properly.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1875 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-25 09:34:20 +00:00
Bart Van Assche
1c64261bec Increased default send queue size from 2048 to 4096 and made the send queue 
size configurable via the kernel module parameter srpt_sq_size.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1874 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-25 09:15:10 +00:00
Bart Van Assche
95bba60a0a Fixed a bug in the command abortion logic that could result rmmod ib_srpt to hang. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1873 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-24 16:47:29 +00:00
Bart Van Assche
ef509acbd8 Refined the timeout error message. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1872 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-24 11:46:29 +00:00
Bart Van Assche
dc80bce266 Fixed a race between initiator and target in the algorithm for computing the REQUEST LIMIT DELTA value sent in responses towards the initiator that could cause the initiators req_lim value temporarily to exceed 128 (SRPT_RQ_SIZE). While harmless, this caused messages like "ib_srpt: ***ERROR***: req_lim = -1 < 0" to appear in the target kernel log. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1871 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-24 08:35:28 +00:00
Bart Van Assche
a9d5ab6737 Added --group_reporting. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1870 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-23 13:41:59 +00:00
Bart Van Assche
06b4f6d8aa Increased SRP initiator lockup safety margin, fixed a sparse warning and added more comments. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1869 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-23 13:41:55 +00:00
Bart Van Assche
7322ff6c24 Added an additional test. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1868 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-23 12:25:54 +00:00
Bart Van Assche
c7472c2aa6 Made sure that ib_srp initiator cannot lock up even when its I/O depth > 1. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1867 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-23 12:23:39 +00:00
Bart Van Assche
baa4b4ee29 Fixed a bug that caused trouble while handling send completions for failed data transfer commands. An example of the call stack that could be logged: 
WARNING: at srpt/src/ib_srpt.c:2908 srpt_unmap_sg_to_ib_sge+0xcb/0x13e [ib_srpt]()
[ ... ]
Call Trace:
 <IRQ>  [<ffffffffa0317827>] ? srpt_unmap_sg_to_ib_sge+0xcb/0x13e [ib_srpt]
 [<ffffffff8023885a>] ? warn_slowpath_common+0x77/0x8e
 [<ffffffffa0317827>] ? srpt_unmap_sg_to_ib_sge+0xcb/0x13e [ib_srpt]
 [<ffffffffa03178f1>] ? srpt_handle_send_comp+0x57/0x7d [ib_srpt]
 [<ffffffffa0319c18>] ? srpt_send_completion+0x82/0xca [ib_srpt]
 [<ffffffffa024f646>] ? mlx4_cq_completion+0x21/0x62 [mlx4_core]
 [<ffffffffa025051e>] ? mlx4_eq_int+0x55/0x2a4 [mlx4_core]
 [<ffffffffa025077c>] ? mlx4_msi_x_interrupt+0xf/0x17 [mlx4_core]
 [<ffffffff8023cff6>] ? tasklet_action+0x64/0xb5
 [<ffffffff802675f9>] ? handle_IRQ_event+0x53/0x105
 [<ffffffff802690ac>] ? handle_edge_irq+0xda/0x11a
 [<ffffffff8020db65>] ? handle_irq+0x81/0x8a
 [<ffffffff8020d399>] ? do_IRQ+0x57/0xbf
 [<ffffffff8020c2d3>] ? ret_from_intr+0x0/0xa
 <EOI>  [<ffffffff80211ca6>] ? mwait_idle+0xa3/0xd1
 [<ffffffff8051ac1a>] ? notifier_call_chain+0x29/0x4c
 [<ffffffff8020aa61>] ? cpu_idle+0x40/0x5e
---[ end trace fef4d0c17ebda700 ]---
------------[ cut here ]------------
kernel BUG at /usr/src/redhat/BUILD/kernel-2.6.30.10/arch/x86/include/asm/dma-mapping.h:104!
invalid opcode: 0000 [#1] SMP
[ ... ]

git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1866 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-23 07:38:15 +00:00
Bart Van Assche
380d63a33e Updated performance measurements. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1858 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-22 08:32:50 +00:00
Bart Van Assche
34bab4bc58 Micro-optimized the IB completion handlers for modes thread=0 and thread=2. 
Fixed another session unregistration race.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1857 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-22 07:43:17 +00:00
Bart Van Assche
a8d02fbfca Enabled rdy_to_xfer_atomic for mode thread=0. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1855 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-22 05:54:55 +00:00
Bart Van Assche
b5c0a25514 Module removal and session unregistration with ongoing I/O should now finally work reliably. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1849 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-21 14:22:34 +00:00
Bart Van Assche
5ded0b7660 Changes: 
- Implemented a workaround for a race between ib_destroy_cq() and the IB
  completion handlers. This race could trigger a kernel crash or kernel lockup
  when unloading the ib_srpt module while I/O was ongoing or by performing
  a relogin from an SRP initiator while I/O was ongoing.
- Moved the code for handling IB completions in single-threaded mode to
  separate functions.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1848 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-21 10:52:36 +00:00
Bart Van Assche
0e6414624e Follow-up for r1845. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1846 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-20 19:44:39 +00:00
Bart Van Assche
a9668c9f07 Micro-optimized srpt_handle_rdma_comp(). 
Assigned names to the three threading modes.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1845 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-20 18:40:29 +00:00
Bart Van Assche
7cca01ae41 Added one more test. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1842 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-18 17:43:44 +00:00
Bart Van Assche
2d3b5d3387 Partially reverted r1416 in order to fix a data corruption issue that occurred 
with highly parallel workloads.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1841 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-18 17:39:43 +00:00
Bart Van Assche
5d78905aaf Whitespace-only changes: converted spaces to tabs. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1840 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-17 20:17:45 +00:00
Bart Van Assche
3b69f969f1 Under heavily multithreaded I/O (twenty or more concurrent writers), data corruption could occur. This issue was introduced in r1506 and has now been fixed. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1839 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-17 19:50:45 +00:00
Bart Van Assche
78cb9e9458 Changed meaning of thread kernel module parameter: while 0 still stands for IRQ context, 1 does now stand for single-threaded processing and 2 for processing SCSI command via multiple kernel threads. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1838 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-17 19:21:22 +00:00
Bart Van Assche
402306e3e0 Relaxed send-queue-full error handling. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1826 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-14 18:37:42 +00:00
Bart Van Assche
7a0a6fb86e Made srpt_srq_size configurable as a kernel module parameter. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1825 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-14 18:28:09 +00:00
Bart Van Assche
fe81f9766c Changed two PRINT_INFO() messages that reported that the send queue was full into PRINT_ERROR() messages, and renamed a few variables. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1824 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-14 17:22:52 +00:00
Bart Van Assche
e7c082ac23 Implemented several source code refinements that do not affect functionality. 
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1819 d57e44dd-8a1f-0410-8b47-8ef2f437770f
 2010-07-13 18:36:08 +00:00