Commit Graph

785 Commits

Author SHA1 Message Date
Bart Van Assche
4e92274317 Merge branch 'svn-trunk' 2015-07-14 18:30:41 -07:00
Bart Van Assche
0651bc1e4e ib_srpt: Linux kernel v4.2 ib_create_cq() build fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6426 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 23:49:48 +00:00
Bart Van Assche
5f95edc612 ib_srpt: Test whether ib_create_send_mad() needs a base_version argument
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6424 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 23:24:26 +00:00
Bart Van Assche
87b6fde56d ib_srpt: Linux kernel v4.2 build fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6423 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 22:50:25 +00:00
Bart Van Assche
f72c420af7 Merge branch 'svn-trunk' 2015-07-09 18:04:58 -07:00
Bart Van Assche
44542c9752 ib_srpt: Follow-up for r6410
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6411 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-09 19:11:04 +00:00
Bart Van Assche
b448c6edf4 ib_srpt: Add support for systems with more than 64 CPU's
Avoid that the following warning is reported on systems with more
than 64 CPU's:

WARNING: CPU: 0 PID: 4762 at drivers/scst/srpt/ib_srpt.c:4179 init_module+0x1d8f42/0x1db887 [ib_srpt]()
Call Trace:
 [<ffffffff8154f2ed>] dump_stack+0x46/0x58
 [<ffffffff8104b4ec>] warn_slowpath_common+0x8c/0xc0
 [<ffffffff8104b53a>] warn_slowpath_null+0x1a/0x20
 [<ffffffffa0236f42>] init_module+0x1d8f42/0x1db887 [ib_srpt]
 [<ffffffffa0233000>] ? 0xffffffffa0233000
 [<ffffffffa005e000>] ? 0xffffffffa005e000
 [<ffffffffa015d587>] ib_register_client+0x87/0xc0 [ib_core]
 [<ffffffffa005e0ef>] init_module+0xef/0x1000 [ib_srpt]
 [<ffffffffa005e000>] ? 0xffffffffa005e000
 [<ffffffff810002bc>] do_one_initcall+0x8c/0x1c0
 [<ffffffff81149022>] ? __vunmap+0xc2/0x110
 [<ffffffff810bb3e3>] load_module+0x1b03/0x22a0
 [<ffffffff810b7e80>] ? show_initstate+0x60/0x60
 [<ffffffff810bbcce>] SyS_finit_module+0x8e/0x90
 [<ffffffff81555a32>] system_call_fastpath+0x12/0x17

Reported-by: Jack Wang <xjtuwjp@gmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6410 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-08 18:23:24 +00:00
Bart Van Assche
c74a2449c5 Return ENOTSUPP instead of ENOSYS for operations that are not supported
ENOSYS must only be used inside system calls.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
2015-06-28 08:50:36 -07:00
Bart Van Assche
e2210ff40f ib_srpt, make clean: Remove all temporary files
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6381 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:28:39 +00:00
Bart Van Assche
9bfdc312d3 ib_srpt: RHEL 5 build fix
Make the ib_srpt driver build again on RHEL 5 systems. See also
r6138.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6334 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-16 20:15:12 +00:00
Bart Van Assche
550ab7c1d3 ib_srpt: RHEL 7.1 build fix
With the RHEL 7.0 kernel ib_register_mad_agent() takes eight
arguments. With the RHEL 7.1 kernel the same function takes nine
arguments. Detect at build time how many arguments this function
takes.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6331 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-16 20:12:28 +00:00
Bart Van Assche
020ec68ddc ib_srpt: Change default behavior from using SRQ to not using SRQ
Although the non-SRQ mode needs more resources that mode has the
advantage that the end-to-end flow control mechanism is used.

From the IB spec:

C9-150.2.1: For QPs that are not associated with an SRQ, each HCA
receive queue shall generate end-to-end flow control credits. If
a QP is associated with an SRQ, the HCA receive queue shall not
generate end-to-end flow control credits.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6329 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-16 18:57:16 +00:00
Bart Van Assche
00caa9aedd Merge branch 'svn-trunk' 2015-06-10 21:03:20 -07:00
Bart Van Assche
5b397efc3f srpt/README: Spelling fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6232 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-10 00:36:16 +00:00
Bart Van Assche
ec6c9386c7 ib_srpt: Change default behavior from using SRQ to not using SRQ 2015-05-22 12:28:20 +02:00
Bart Van Assche
bd20e1fcf7 ib_srpt, make clean: Remove all temporary files
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
2015-05-06 14:57:14 +02:00
Bart Van Assche
cb823d4d66 Merge branch 'svn-trunk' into master 2015-05-06 08:25:45 +02:00
Vladislav Bolkhovitin
e719f0eca5 ib_srpt: cleanup fixed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6203 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-06 02:05:54 +00:00
Bart Van Assche
4f445f4c33 Merge branch 'svn-trunk' r6192
Conflicts:
	scst/include/scst.h
	scst/src/dev_handlers/scst_vdisk.c
2015-05-01 08:15:50 +02:00
Vladislav Bolkhovitin
906f4dfefb Merge t10-pi branch back
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6192 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-01 04:21:56 +00:00
Bart Van Assche
5b57a0bcea ib_srpt: RHEL 5 build fix
Make the ib_srpt driver build again on RHEL 5 systems. See also
r6138 / commit ID 940faa9ad4.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
2015-04-15 17:54:56 +02:00
Bart Van Assche
a613f706c3 ib_srpt: RHEL 7.1 build fix
With the RHEL 7.0 kernel ib_register_mad_agent() takes eight
arguments. With the RHEL 7.1 kernel the same function takes nine
arguments. Detect at build time how many arguments this function
takes.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
2015-04-15 14:30:34 +02:00
Bart Van Assche
33a4bccc38 ib_srpt: Avoid that aborting a command triggers a race condition
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6181 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-10 05:39:44 +00:00
Bart Van Assche
98fb52432c ib_srpt: Specify a valid completion vector during completion queue creation
Avoid that SRP login can fail as follows:

kernel: ib_srpt: failed to create CQ: cqe 320; c.v. 17; ret -22


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6179 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-09 15:06:36 +00:00
Bart Van Assche
c32f79f6c1 Revert T10-PI support
The T10-PI patch (r6162) increases the time needed to run mkfs.ext4
over iSCSI from less than a second to several minutes. This is a
regression so revert the T10-PI patch until there is sufficient time
to find the root cause of this regression and to fix this regression.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6171 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-31 09:51:24 +00:00
Bart Van Assche
d6db54ebdc ib_srpt: Enable building against OFED headers without patching the build system (follow-up for r6138)
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6166 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-29 19:19:36 +00:00
Bart Van Assche
a3f4f28711 Build fixes - follow-up for r6162
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6164 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-29 17:32:59 +00:00
Vladislav Bolkhovitin
fe38e4acb2 Copyrights updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6146 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-19 00:01:03 +00:00
Bart Van Assche
1c8574763b ib_srpt, Makefile: Pass same flags to "make modules" and to "make install"
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6141 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-04 10:42:38 +00:00
Bart Van Assche
0e292ac2d8 ib_srpt: Follow-up for r6138
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6140 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-03 15:49:22 +00:00
Bart Van Assche
940faa9ad4 ib_srpt: Enable building against OFED headers without patching the build system
Additionally, include the OFED flavor name in the ib_srpt version number.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6138 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-02 14:28:25 +00:00
Bart Van Assche
ef48d260d2 ib_srpt: Suppress a compiler warning when building against Mellanox OFED
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6137 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-02 14:24:33 +00:00
Vladislav Bolkhovitin
4ac6d7a26d [PATCH] scst: Drop detect() method
There is no need for a detect() method - code that is present in such
a method can be moved to module_init(). Hence declare this method
obsolete. Leave the detect pointer member in the target template for
now for out-of-tree SCST drivers.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>

with some improvements



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6113 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-21 04:32:36 +00:00
Bart Van Assche
35db9c65f3 ib_srpt: Suppress three more checkpatch warnings
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6107 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-17 07:21:01 +00:00
Bart Van Assche
f974dee9b0 ib_srpt: Suppress a checkpath complaint
Avoid that checkpatch reports the following:

WARNING: Possible unnecessary 'out of memory' message


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6106 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-17 07:08:49 +00:00
Bart Van Assche
68a9178e4a ib_srpt: Remove redundant forward declarations
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6105 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 15:47:46 +00:00
Bart Van Assche
56d3217eb0 ib_srpt: Update a source code comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6104 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 15:43:44 +00:00
Bart Van Assche
d46a3e8bab ib_srpt: Convert srpt_xfer_data() return value
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6103 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 14:49:45 +00:00
Bart Van Assche
59f25b783e ib_srpt: Eliminate an argument from srpt_xfer_data()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6102 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 14:34:00 +00:00
Bart Van Assche
5b5d944140 ib_srpt: Rename more variables
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6101 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 13:41:31 +00:00
Bart Van Assche
aa52348481 ib_srpt: Fix a checkpatch complaint
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6100 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 13:21:34 +00:00
Bart Van Assche
4ddf8b19ec ib_srpt: Clean up an error message
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6099 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 13:18:18 +00:00
Bart Van Assche
585df7c5f6 ib_srpt: Rename a few variables
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6098 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 13:16:52 +00:00
Bart Van Assche
edb4d579fb ib_srpt: Shorten a source code comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6097 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 12:53:12 +00:00
Bart Van Assche
c2b09b243c ib_srpt: Change type of the first argument of srpt_get_ioc()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6096 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 12:48:36 +00:00
Bart Van Assche
460c0bdada ib_srpt: Swap the order of two declarations
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6095 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 10:56:26 +00:00
Bart Van Assche
c8e0a2c711 ib_srpt: Reorder structure members
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6094 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 10:40:05 +00:00
Bart Van Assche
b0ed8ed58c ib_srpt: Convert print and trace statements
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6093 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 10:26:21 +00:00
Bart Van Assche
b686ed343d ib_srpt: Remove TRACE_ENTRY()/TRACE_EXIT() macro invocations
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6092 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 09:46:40 +00:00
Bart Van Assche
42bc56a0a2 ib_srpt: Add missing kernel-doc comments
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6091 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 09:44:25 +00:00