Commit Graph
128 Commits
Author SHA1 Message Date
Vladislav Bolkhovitin 3120885a46 - Eliminate theorethically possible race leading to sending wrong max_sn to initiators
- Alignment cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2022 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-08-30 20:34:17 +00:00
Vladislav Bolkhovitin 1607d12c9c Sysfs cleanups and fixes, part 1
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1962 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-08-20 15:38:21 +00:00
Vladislav Bolkhovitin 7eddeb82ab - Some iSCSI performance fixes
- __attribute__((aligned(sizeof(long))) added to all field with different protection than the previous field to make sure they don't share the same bus line. Just in case, actually, compiler should do the alignment by default.

 - Small docs updates.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1948 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-08-13 18:12:45 +00:00
Vladislav Bolkhovitin 28dd4e5150 Patch from Bart Van Assche <bvanassche@acm.org> fixing endianness warning reported by sparse.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1833 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-07-17 13:53:41 +00:00
Vladislav Bolkhovitin 2f667fe80f Part of the patch from Bart Van Assche <bvanassche@acm.org> fixing/suppressing iscsi-scst related endianness warnings reported by sparse with some changes
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1828 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-07-15 17:45:41 +00:00
Vladislav Bolkhovitin 54c98834cd BE changes to keep sparse happy pointed out by Bart Van Assche <bvanassche@acm.org>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1791 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-25 18:14:13 +00:00
Vladislav Bolkhovitin 0d21ef4e23 Fix for wrong endianness in scst_cmd_set_tgt_sn() call. Reported by Phil White <phil@scalecomputing.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1785 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-25 10:23:20 +00:00
Vladislav Bolkhovitin 78edc5afb9 Various cleanups and fixes after some errors injection tests. Particularly:
- ISCSI preliminary completed commands handling fixes
 - Write residuals cleanups and fixes
 - Interface to handle residuals and received from initiators data changed
 - BIDI cleanups and fixes.
 - All BIDI IN fields and functions renamed to OUT to be in line with the in-kernel convention

+ 

Docs updated



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1780 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-23 13:57:35 +00:00
Vladislav Bolkhovitin 2da20cee9e Add listing attributes of various types in the help string to help manegement utilities. Added on request from Mark Buechler <mark.buechler@gmail.com>.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1762 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-11 18:40:14 +00:00
Bart Van Assche ca97893240 Fixed checkpatch complaints about whitespace and one sparse warning.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1745 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-05 16:44:27 +00:00
Vladislav Bolkhovitin 8c05a7f350 Residuals and write residuals counting fixes
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1742 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-04 19:43:02 +00:00
Vladislav Bolkhovitin 0007914f1d Make RX data digest failures handling more smart
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1731 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-01 11:35:27 +00:00
Vladislav Bolkhovitin 888bd5150e Minor typo fixed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1728 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-05-31 18:04:16 +00:00
Vladislav Bolkhovitin 465b7669c6 ALL_TG_PT implemented + some other fixes
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1725 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-05-31 17:12:50 +00:00
Vladislav Bolkhovitin 129008c92c CONFIG_SCST_ISCSI_SKIP_ISID removed, because it isn't needed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1717 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-05-26 18:26:52 +00:00
Vladislav Bolkhovitin b53e4cb4c1 Merge of the pr branch with additional fixes for problems found during extra testing
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1714 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-05-26 17:46:46 +00:00
Vladislav Bolkhovitin bc1cda46df Sparse cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1713 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-05-24 12:32:45 +00:00
Vladislav Bolkhovitin 5406a07d26 Various iSCSI initiators access control and visibility improvements. Particularly:
- SendTargets now returns all (allowed) portals. Particularly based on IET r230, 234, 249 and 264.
 - Initiators assigned to security groups without LUNs will not see the target during discovery and forbidden to login to it
 - Per portals access control added
 - Negative sign added to wildcard matching
 - Docs updated
 - Cleanups and minor fixes



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1685 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-05-07 18:08:52 +00:00
Vladislav Bolkhovitin 07ecd8a5bc Cleanups for minor issues noteced by Bart Van Assche <bvanassche@acm.org>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1678 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-05-04 17:39:57 +00:00
Bart Van Assche 9f2a7853cd Fixed several recently introduced sparse warnings.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1672 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-30 11:03:38 +00:00
Bart Van Assche c99bd720c8 Removed trailing whitespace because checkpatch complained about it.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1671 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-30 10:49:28 +00:00
Vladislav Bolkhovitin a59f9a0dc6 Residuals handling fixes, part 2
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1667 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-29 17:13:12 +00:00
Vladislav Bolkhovitin 1c21b1ffb8 Minor cleanups, fixes and updates
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1657 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-27 16:29:58 +00:00
Vladislav Bolkhovitin eb05cb541e Merge of IET r228: add module version and description
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1641 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-21 17:56:48 +00:00
Vladislav Bolkhovitin 4d5aaf047b Copyrights updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1585 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-06 08:57:48 +00:00
Bart Van Assche b0cf40d013 Fixed checkpatch complaints about whitespace.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1567 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-03-27 08:45:18 +00:00
Vladislav Bolkhovitin 1f216064f3 Uniform max queue depth handling in iSCSI
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1556 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-03-18 11:44:39 +00:00
Vladislav Bolkhovitin cbaab260f1 Add new scst_cmd_get_queue_type()/scst_cmd_set_queue_type() accessors and use them in target drivers instead of direct access to SCST's cmd->queue_type.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1553 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-03-17 19:11:18 +00:00
Vladislav Bolkhovitin 88e5601df0 Deeply reworked patch from Alexey Obitotskiy <alexeyo1@open-e.com> implementing support for sending NOP-In requests
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1533 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-03-05 12:56:20 +00:00
Vladislav Bolkhovitin 713410951b Minor fixes and cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1520 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-25 13:37:56 +00:00
Vladislav Bolkhovitin 4d96089e50 Sysfs interface for targets made uniform. ISCSI-SCST made confirming the uniformity requirements. See README for details.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1511 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-17 19:07:54 +00:00
Bart Van Assche 7eee1392b8 Compiles again without warnings.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1501 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-12 18:59:15 +00:00
Vladislav Bolkhovitin 82e07ddb73 Commented out required by iSCSI RFC, but not needed for processing, check of LUN field in Data-Out PDU, because some initiators (Windows, at least) don't care to correctly set it.
Reported and tested by Ladislav Pašek <pasek@valbek.cz>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1500 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-12 13:12:58 +00:00
Vladislav Bolkhovitin eada62f329 Fixed processing of REQUEST SENSE and INQUIRY commands for not existing LUNs
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1462 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-13 18:10:10 +00:00
Bart Van Assche ddbaa159ca Fixed the following checkpatch complaint:
1 WARNING: braces {} are not necessary for single statement blocks


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1457 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-13 08:21:39 +00:00
Vladislav Bolkhovitin 4a2fcb870b - Logging cleanups. Particularly, TRACE_MGMT_MINOR level was removed
- Docs updates
 - Other minor fixes and cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1452 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-12 13:29:01 +00:00
Vladislav Bolkhovitin 5b930aa9a4 - Improved handling of commands with TASK ABORTED status
- Minor cleanup



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1449 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-11 19:41:23 +00:00
Bart Van Assche 1660fe1c3c Fixed the following category of checkpatch complaints:
2 ERROR: code indent should use tabs where possible


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1440 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-09 15:01:59 +00:00
Vladislav Bolkhovitin e6ac85312b Commands can be aborted by other transports, so cmnd_rx_continue() should check scst_cmd_aborted().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1439 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-08 16:19:31 +00:00
Bart Van Assche 754d139673 Fixed checkpatch complaints about whitespace (use tabs instead of spaces /
trailing whitespace) and the sparse complaint about using '0' as a pointer.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1433 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-06 20:22:15 +00:00
Vladislav Bolkhovitin 05d1bbfedc A huge chunk of related to each other changes, which had to be tested together.
iSCSI-SCST: A huge improvements in errors recovery and iSCSI RFC complaince as well as performance. Also:

 - Fixes and improvements for MaxOutstandingR2T>1

 - Flow control tracing added.

 - Cleanups

SCST core:

 - Now for scst_cmd_init_stage1_done() commands preprocessing_done() is always called before xmit_response(), even in case of abort or error.

 - Fixed recently introduced bug, which can lead to sending responses for aborted commands after reply on the corresponding TM command already sent.

 - Flow control tracing added.

 - Now it is possible to call functions setting commands execution status (e.g., scst_set_cmd_error_status()) several times for the same command. Only the first call will be completed, other calls - ignored.

 - All commands are counted and shown in proc/sysfs now. Before only active, i.e. not yet executed commands, were counted and shown there.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1431 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-01-06 13:02:22 +00:00
Bart Van Assche 8e8abd54b5 Fixed the following category of complaints reported by the 2.6.32 checkpatch:
11 ERROR: that open brace { should be on the previous line


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1405 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-12-16 20:01:08 +00:00
Vladislav Bolkhovitin f519e2c265 Fix spelling typos.
Signed-off-by: Dotan Barak <dotanba@gmail.com>

with additional spelling fixes noticed by frank zago <fzago@systemfabricworks.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1396 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-12-16 11:35:12 +00:00
Vladislav Bolkhovitin 3261614731 - Fix for memory allocation for scst_user and locally handled commands
- Execution context cleanups and fixes



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1338 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-11-16 18:05:10 +00:00
Vladislav Bolkhovitin 6153a079a3 iSCSI target sysfs "enabled" attribute implemented
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1324 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-11-06 18:41:37 +00:00
Vladislav Bolkhovitin 977a20ccba ISCSI target sysfs implementation, except "enabled" attribute.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1305 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-30 20:15:38 +00:00
Vladislav Bolkhovitin f999f978ee Exclude unneeded code from the kernel patch generation
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1262 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 18:02:25 +00:00
Vladislav Bolkhovitin 82b04b2a00 Merge of the sysfs branch. To enable the sysfs interface you should run "make disable_proc". To switch back on the procfs interface you should run "make disable_proc".
The sysfs intarface is mostly finished. Only initiators-oriented access control not implemented and not all target drivers are updated. Only qla2x00t has been fully updated.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1229 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-21 16:49:52 +00:00
Vladislav Bolkhovitin cc83f517ea - Fix for a possible DoS, when misbehavine scst_user's handler hangs several memory allocations (= count of iSCSI read threads) and by so prevents other sessions from being served correctly. Spotted by Erez Zilber <erezzi.list@gmail.com>
- iSCSI read state machine cleanups

 - Fix a race when just freed iSCSI session accessed, because the corresponding SCST session is still being unregistered.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1224 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-15 15:56:57 +00:00
Vladislav Bolkhovitin ab1835aec5 More consistency in TM functions logging.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1099 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-09-16 18:08:02 +00:00