Name anonymous function and negotiation-callback parameters and match
declaration names to their definitions. This includes the misleading
length name of the CDB LBA argument. Types and calling conventions
remain unchanged. Use pool_type for the two private sysfs parameter names
so their declarations fit; structure fields and diagnostics keep their
existing names.
Drop redundant extern on function prototypes, retain it on objects, and
align continued arguments with the resulting opening parentheses.
Cppcheck reports funcArgNamesDifferent, funcArgNamesDifferentUnnamed.
One example:
Function 'sqa_enable_tgt' argument 1 names different: declaration
'tgt' definition 'scst_tgt'.
Checkpatch reports FUNCTION_ARGUMENTS:
function definition argument 'const struct iscsi_key *' should also
have an identifier name
Checkpatch reports AVOID_EXTERNS:
extern prototypes should be avoided in .h files
Checkpatch reports PARENTHESIS_ALIGNMENT:
Alignment should match open parenthesis
Use distinct names for parser arguments, local descriptors, trace flags
and iSNS send/receive transaction IDs. Rename the process-wide SRPT RDMA
listener so connection-specific IDs do not shadow it.
Remove initial values replaced unconditionally before use and the
impossible fgets NULL branch. Retain configuration-dependent
initializers, listener lifetime and every connection ID passed to RDMA
operations.
Cppcheck reports shadowArgument, redundantInitialization. One example:
Local variable 'pp' shadows outer argument
Cppcheck reports shadowVariable, unreadVariable. One example:
Argument 'trace_flag' shadows outer variable
Gleb Chesnokov
Vladislav Bolkhovitin
Bart Van Assche