If HBA initialization fails unexpectedly (exiting via probe_failed:), we
may fail to free vha->gnl.l. So that we don't attempt to double free, set
this pointer to NULL after a free and check for NULL at probe_failed: so we
know whether or not to call dma_free_coherent.
Signed-off-by: Bill Kuzeja <william.kuzeja@stratus.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit 26fa656e9a0cbccddf7db132ea020d2169dbe46e upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8630 d57e44dd-8a1f-0410-8b47-8ef2f437770f
In qla2x00_alloc_fcport(), fcport is assigned to NULL in the error
handling code on line 4880:
fcport = NULL;
Then fcport is used on lines 4883-4886:
INIT_WORK(&fcport->del_work, qla24xx_delete_sess_fn);
INIT_WORK(&fcport->reg_work, qla_register_fcport_fn);
INIT_LIST_HEAD(&fcport->gnl_entry);
INIT_LIST_HEAD(&fcport->list);
Thus, possible null-pointer dereferences may occur.
To fix these bugs, qla2x00_alloc_fcport() directly returns NULL
in the error handling code.
These bugs are found by a static analysis tool STCheck written by us.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
[ commit e82f04ec6ba91065fd33a6201ffd7cab840e1475 upstream ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8629 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Surrounding IS_ERR(...) with unlikely() is redundant. Remove the redundant
unlikely() annotations.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8623 d57e44dd-8a1f-0410-8b47-8ef2f437770f
These drivers have not been updated in a significant way since 2010.
Additionally, these drivers fail to build against recent kernel versions.
I think this means that nobody is using these drivers. Hence remove these
drivers from the trunk.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8622 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Since the driver in the qla2x00t-32gbit directory supersedes the driver from
the QLogic git tree, remove all references to the latter.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8620 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Reduce the size of struct scst_cmd by reordering its structure members such
that there are two holes less in this data structure. This change has been
verified with the help of the 'pahole' tool.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8606 d57e44dd-8a1f-0410-8b47-8ef2f437770f
gawk: scripts/specialize-patch:329: (FILENAME=- FNR=26) warning: regexp escape sequence `\&' is not a known regexp operator
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8597 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Suppress the following error messages:
- SSL error:02001002:system library:fopen:No such file or directory: crypto/bio/bss_file.c:72
- SSL error:2006D080:BIO routines:BIO_new_file:no such file: crypto/bio/bss_file.c:79
sign-file: certs/signing_key.pem: No such file or directory
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8596 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Bart Van Assche