Commit Graph
3313 Commits
Author SHA1 Message Date
Vladislav Bolkhovitin b91344f856 Fix incorrect "Access beyond the end of the device" reporting for INQUIRY on vcdroms without disk
Reported and suggested how to fix it by Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4309 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-19 03:42:57 +00:00
Vladislav Bolkhovitin 46a4e0a2ae Micro-optimization: cmd_data_descriptors_cnt isn't needed
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4308 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-18 19:50:54 +00:00
Vladislav Bolkhovitin d0af97d3f1 scst_vdisk, CD-ROM: Change error code returned if no medium present
If my interpretation of section "6.37 TEST UNIT READY command" in SPC-4
is correct then TEST UNIT READY should report "MEDIUM NOT PRESENT" if no
medium is present instead of "LOGICAL UNIT NOT READY, AUXILIARY MEMORY
NOT ACCESSIBLE".

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4307 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-18 02:56:13 +00:00
Bart Van Assche e28130bb2f scstadmin, FC, NPIV: Make -write_config save the "node_name" and "parent_host"
attributes.

Reported-by: Dimitri Puzin <max@psycast.de>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4306 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-17 15:08:57 +00:00
Bart Van Assche c569b7e8a1 scstadmin: Rework r4304.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4305 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-17 12:54:42 +00:00
Bart Van Assche 00caf4d5c9 scstadmin: Make -write_config save the scst_local session name
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4304 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-17 12:18:48 +00:00
Vladislav Bolkhovitin b0a24b829b Make qla2x00t cleanly compile on RHEL 6.2
From Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4303 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-17 01:17:09 +00:00
Vladislav Bolkhovitin cacf9046d8 Update iSCSI HOWTO
Bring the iSCSI-SCST how-to in sync with scstadmin. Applies to trunk
and 2.2 branch.

Reported-by: Kenneth Wong <kenwong@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4302 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-17 01:10:10 +00:00
Bart Van Assche 363e1b5a05 scst_vdisk: Avoid that invalid data is returned for VPD page 0xb0 if
vdev_blockio_get_unmap_params() fails.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4301 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-15 18:38:35 +00:00
Bart Van Assche 44978416d4 ib_srpt: Slightly reduce the CPU load caused by the srpt thread(s).
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4300 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-14 17:56:49 +00:00
Bart Van Assche 5256d37f42 ib_srpt: Make SCST I/O context configurable at compile time
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4299 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-14 17:42:37 +00:00
Bart Van Assche ea47b3c059 ib_srpt: Fix spelling in a source code comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4298 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-14 15:09:36 +00:00
Bart Van Assche f879eadf3d nightly build: Update kernel versions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4297 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-13 18:35:57 +00:00
Vladislav Bolkhovitin 0fe0a3b839 WRITE SAME related cleanups and fixes
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4296 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-11 23:20:19 +00:00
Vladislav Bolkhovitin d3b4b46223 Patch improving handling of errors during passing connection to the kernel.
From Lev Vainblat <lev@zadarastorage.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4295 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-11 01:20:26 +00:00
Bart Van Assche d9948f2922 scst: Fix recently introduced checkpatch complaints about whitespace
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4294 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-08 21:45:57 +00:00
Bart Van Assche 862d84df64 nightly build: Kernel version updates
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4293 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-08 21:25:00 +00:00
Bart Van Assche 0aca2096d9 scst_vdisk, kernel 2.6.32: Avoid that adding a vdisk_blockio device triggers a BUG()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4292 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-08 21:09:40 +00:00
Vladislav Bolkhovitin 79b72d5606 Web updates: on Emulex request remove all references to it.
For more details see http://sourceforge.net/mailarchive/forum.php?thread_name=4FA2A8F0.9070703%40emulex.com&forum_name=scst-devel



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4291 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-08 01:48:49 +00:00
Vladislav Bolkhovitin 3b57904da6 Unify parsing of descriptors-based and internal commands
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4290 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-07 22:39:54 +00:00
Bart Van Assche 7596ffd7dd ib_srpt: Reduce RDMA_COMPL_TIMEOUT_S back to its original value now that read and write processing happens again on the context of the SCST command threads instead of the srpt completion thread
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4289 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-07 14:59:57 +00:00
Vladislav Bolkhovitin 74e1d9884c Small comments clarification
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4286 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-04 22:23:59 +00:00
Bart Van Assche 48fc76ecb4 ib_srpt: Revert most of r4282 - a channel must be added to the channel list before unlocking the spinlock such that the completion thread can safely invoke list_del()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4284 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-04 17:18:22 +00:00
Bart Van Assche 1baaaea48b ib_srpt: Test earlier during login whether a port has been disabled
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4282 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-04 13:49:04 +00:00
Bart Van Assche 4b47a45373 ib_srpt: Make the login log line easier to read
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4281 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-04 13:45:25 +00:00
Bart Van Assche 8f334bd78e ib_srpt: Fix a few (theoretical ?) race conditions
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4278 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-03 11:00:39 +00:00
Bart Van Assche 30cfdfd079 ib_srpt, Testing.txt: Add a test
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4277 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-03 09:55:41 +00:00
Bart Van Assche 5496aa9c2d ib_srpt, Testing.txt: Add a test
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4276 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-03 09:03:09 +00:00
Bart Van Assche 5710833147 ib_srpt, Testing.txt: Minor corrections
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4275 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-03 08:48:43 +00:00
Bart Van Assche 7dfb0f3b0a scst_vdisk: Add a return statement at the end of a function. This makes the nightly build succeed again with option "-u".
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4274 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-03 06:40:01 +00:00
Vladislav Bolkhovitin 8ee91132a8 Cleanup and microoptimization: it's better to use DIV_ROUND_UP is such cases
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4273 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-02 19:47:55 +00:00
Vladislav Bolkhovitin b3ca5afd06 Cleanup and compile fix for breakage reported by Bart Van Assche <bvanassche@acm.org>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4272 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-02 18:42:30 +00:00
Bart Van Assche 1d6daae29e ib_srpt: Handle thread creation failure properly
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4270 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-02 15:19:40 +00:00
Bart Van Assche dc94ba7d76 ib_srpt: Simplify login error handling code
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4269 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-02 15:18:24 +00:00
Bart Van Assche 08a2d59408 ib_srpt: Correct __srpt_close_ch() comments.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4268 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-02 15:16:40 +00:00
Bart Van Assche c2cea7b776 ib_srpt: Handle thread creation failure properly
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4267 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-02 13:57:07 +00:00
Bart Van Assche ac77b3110d ib_srpt: Rename a label
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4266 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-02 13:48:54 +00:00
Bart Van Assche 11f5cf447c ib_srpt: Add a comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4265 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-02 09:46:04 +00:00
Bart Van Assche 8d775b8f39 ib_srpt: Replace list_for_each_entry_safe() by list_for_each_entry() where this is safe
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4264 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-02 09:35:40 +00:00
Bart Van Assche 7937b1b5cb ib_srpt: Remove an unused variable
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4263 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-02 09:30:22 +00:00
Vladislav Bolkhovitin 8f289d5f8e WRITE SAME implemented
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4262 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-01 22:25:37 +00:00
Vladislav Bolkhovitin 2374c7e42e Small cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4261 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-01 18:41:26 +00:00
Bart Van Assche fcfe100b79 ib_srpt, procfs: Remove code that shows the login information - it is redundant to the ibsrpdm output anyway.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4260 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-01 18:22:30 +00:00
Bart Van Assche 1a0b957efc /etc/init.d/scst: When parsing /etc/scst.conf for "TARGET_DRIVER ... {", accept blanks at the end of the line.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4259 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-01 18:17:24 +00:00
Bart Van Assche 8f1017612b ib_srpt: Rewrite the gcc <= 4.6 compiler bug workaround such that it doesn't trigger a checkpatch complaint
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4258 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-01 06:46:28 +00:00
Bart Van Assche 96cbffaad5 scst: Fix a checkpatch complaint about whitespace
"ERROR: code indent should use tabs where possible"


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4257 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-01 06:39:37 +00:00
Vladislav Bolkhovitin aeea39f9f1 Let's enforce initializing cmd->lba the same way as for data_len.
This field also expected to be always initialized.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4256 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-30 20:50:08 +00:00
Vladislav Bolkhovitin 820d8e638a Microoptimization: there's no need to chack if op is valid for each opcode.
Instead, all empty entires can be initialized as invalid opcode handler.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4255 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-30 20:25:12 +00:00
Vladislav Bolkhovitin 474dca1fb2 scst: Move ioctx manipulation code
Move the code for obtaining and releasing an I/O context out of
scst_process_active_cmd() in order to improve source code
readability.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4254 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-30 19:41:18 +00:00
Vladislav Bolkhovitin a913a223f9 iSCSI-SCST: Add scstadmin example todocumentation
Add an scstadmin iSNSServer configuration example to the iSCSI-SCST
documentation.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4253 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-30 19:32:30 +00:00