Bart Van Assche
95993cd9fd
scstadmin/scstadmin.sysfs/scst-1.0.0/t/07-scstadmin-args.t: Filter out ib_srpt
...
The scstadmin output for the ib_srpt driver depends on whether or not an
RDMA HCA is present and also on the port GUIDs. Hence filter out the
ib_srpt data.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9153 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 22:16:05 +00:00
Bart Van Assche
8d3c1cf3a2
scstadmin: Use length($var) to test whether an argument has been specified
...
This patch fixes a bug by making it again possible to use "0" as e.g. the
name of an SCST device group. See also commit 858f50e4d3 ("scstadmin:
Improve robustness").
Reported-by: Pavel Klevtsov
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9152 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 03:20:47 +00:00
Bart Van Assche
a3266ca8f2
scstadmin: Remove support for the "new" sysfs interface
...
Around 2011 a sysfs-tree-changes branch was created in the SourceForge
repository because Greg KH asked to rework the SCST sysfs interface. That
interface is called the "new" sysfs interface. The current and only used
API is called the "old" sysfs interface. Since the "new" sysfs interface
never had any users other than myself, remove support for that interface.
See also commit a66cbc4115 ("scstadmin: Add support for the sysfs
interface provided by the code on the sysfs-tree-changes branch").
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9151 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-13 03:12:26 +00:00
Bart Van Assche
c7788ee7ac
/etc/init.d/scst: Unload target modules first
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9046 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-12 23:31:34 +00:00
Bart Van Assche
2239719d8e
/etc/init.d/scst: Really unload all SCST kernel modules
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8952 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-23 16:49:19 +00:00
Bart Van Assche
00765d8ae2
/etc/init.d/scst: Unload all SCST kernel modules
...
Also unload SCST kernel modules that have been loaded manually or that are
no longer referenced by /etc/scst.conf.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8951 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-23 16:30:42 +00:00
Bart Van Assche
9be823075d
/etc/init.d/scst: Fix a shellcheck warning
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8950 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-23 16:18:13 +00:00
Bart Van Assche
8276dc53d3
scstadmin: Make scstadmin again compatible with older Perl interpreters
...
Fix the following Perl v5.10.1 warnings:
Ambiguous use of -ENOENT resolved as -&ENOENT() at /usr/local/share/perl5/SCST/SCST.pm line ...
According to https://stackoverflow.com/questions/23215511/ambiguous-use-of-constant-resolved-as-constant
that message indicates a bug in the Perl interpreter.
Reported-by: Gilbert Standen <gilstanden@hotmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8928 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-17 16:43:13 +00:00
Bart Van Assche
d12b0a0d91
Fix spelling in documentation and source code
...
See also https://github.com/bvanassche/scst/pull/20 .
[ bvanassche: left out qla2x00t-32gbit changes and changed patch description ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8920 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-15 18:53:48 +00:00
Bart Van Assche
8de9eb487a
scstadmin: Fix -resync_dev
...
Fix the following failure:
# scstadmin -resync_dev volume01
Collecting current configuration: done.
-> Making requested changes.
-> WARNING: Device 'volume01' lacks the settable attribute 'resync_size', ignoring.
-> Done.
All done.
This patch fixes a regression that was introduced by r8171 (commit
aedcfc5997 ("scstadmin: Avoid that Perl complains about undefined values
for write-only attributes") # v3.4.
Reported-by: Marc Smith <msmith626@gmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8915 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 20:45:26 +00:00
Bart Van Assche
198cb64c8d
scstadmin: Make test 06 more robust
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8913 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:37:18 +00:00
Bart Van Assche
7d63eaf0ce
scstadmin: If modifying an SCST attribute fails, report why it fails
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8910 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:23:57 +00:00
Bart Van Assche
858f50e4d3
scstadmin: Improve robustness
...
Instead of only interpreting the empty string as "no argument passed", also
consider 'undef' as "no argument passed".
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8905 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 17:24:35 +00:00
Bart Van Assche
5b1a15d3c9
scstadmin/init.d/scst: Simplify sed expressions
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8882 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:46:59 +00:00
Bart Van Assche
17a0091804
scstadmin/init.d/scst: Fix shellcheck warnings
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8881 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-09 22:46:02 +00:00
Bart Van Assche
ecaab978f0
scst, scstadmin, ...: Bump the version number to 3.5.0-pre
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8683 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-12-06 05:28:56 +00:00
Bart Van Assche
447d25f678
scstadmin: Bump version number
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8680 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-12-04 05:00:24 +00:00
Bart Van Assche
d5c638ca1d
rpm build: Make the RPM build directory configurable
...
Signed-off-by: Daniel Ahlin <dah@pdc.kth.se >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8658 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-11-16 04:22:03 +00:00
Bart Van Assche
aedcfc5997
scstadmin: Avoid that Perl complains about undefined values for write-only attributes
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8171 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-04-08 02:16:46 +00:00
Bart Van Assche
976595dccb
scst: Also unload the qla2xxx_scst kernel module when stopping SCST
...
Make sure that the qla2xxx_scst kernel module is reloaded after an upgrade
of SCST.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8161 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-04-06 23:14:24 +00:00
Bart Van Assche
48858f0aec
scstadmin: Write output of test 09 into a file with 09 in its name
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8063 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-21 02:53:32 +00:00
Bart Van Assche
da8b868a31
scstadmin: Fix a recently enabled warning
...
Avoid that the following warning is reported when restoring a config
file that refers to a user space handler:
Use of uninitialized value $value in scalar chomp at /usr/local/share/perl5/SCST/SCST.pm line 2688.
Reported-by: Rob Turk <robtu@rtist.nl >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8062 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-20 02:07:16 +00:00
Bart Van Assche
46698cc77d
scstadmin: Enable Perl warnings
...
Make the Perl interpreter complain about dubious Perl constructs.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8024 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-10 01:01:59 +00:00
Bart Van Assche
87d82bfa8f
Remove documentation references to procfs
...
Now that procfs has been removed, remove the references to procfs from
the documentation.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8000 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-02 20:06:25 +00:00
Bart Van Assche
281801a266
scstadmin: Make $Version a local variable
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7960 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 01:51:36 +00:00
Bart Van Assche
906c18ae83
scstadmin: Update copyright
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7959 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 01:49:44 +00:00
Bart Van Assche
3a87185399
scstadmin: Avoid triggering Perl warnings
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7958 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 01:45:42 +00:00
Bart Van Assche
4ed48121e3
scstadmin: Update expected output of test 07
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7957 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 01:40:37 +00:00
Bart Van Assche
1eae6633b4
scstadmin: Fix Perl warnings
...
Modify those constructs that trigger warnings with 'use warnings'. This
patch does not modify any functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7956 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 01:38:14 +00:00
Bart Van Assche
9fb607fe12
scstadmin: Check $answer before using it
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7955 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 01:30:13 +00:00
Bart Van Assche
bf45a6162f
scstadmin: Add a test that causes scstadmin to display a prompt
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7954 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 01:29:40 +00:00
Bart Van Assche
b79fa94a27
scstadmin: Initialize container variables explicitly
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7953 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 00:46:27 +00:00
Bart Van Assche
a1b1a880af
scstadmin: Remove a superfluous declaration
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7952 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 00:41:48 +00:00
Bart Van Assche
bad428c615
scstadmin: Initialize container variables explicitly
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7951 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 00:40:23 +00:00
Bart Van Assche
c4cc4bdcbc
scstadmin: Avoid dereferencing variables that have the value undef
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7950 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 00:38:50 +00:00
Bart Van Assche
27d90a3563
scstadmin: Improve the consistency of test 07
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7949 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 00:34:48 +00:00
Bart Van Assche
4f762acebd
scstadmin: Set remote targets and remote rel_tgt_ids in test 07
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7948 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-18 00:34:03 +00:00
Bart Van Assche
f2b4c0d256
scstadmin: Restrict a source code line to 80 columns
...
This patch does not change any functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7947 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-17 22:08:58 +00:00
Bart Van Assche
2da0ddd47d
scstadmin: Avoid passing 'undef' to chomp()
...
This patch does not change any functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7946 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-17 22:07:35 +00:00
Bart Van Assche
477c49a7a6
scstadmin: Fix regression test 07
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7945 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-17 22:05:12 +00:00
Bart Van Assche
d5c1e5ba79
scstadmin: Use defined() instead of !... eq '' to check whether arguments have been specified
...
This patch does not change any functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7944 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-17 19:33:44 +00:00
Bart Van Assche
b75421e3ef
scstadmin: Add a test for the messages printed for invalid args
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7943 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-17 19:29:46 +00:00
Bart Van Assche
b347e79a40
scstadmin: Fix an ALUA command line option error message
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7942 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-17 19:26:50 +00:00
Bart Van Assche
0c676b034d
scstadmin: Avoid shadowing the errorString declaration, part 5
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7941 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-16 19:19:48 +00:00
Bart Van Assche
0f2dae492f
scstadmin: Rearrange addVirtualTarget()
...
This patch does not change any functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7940 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-16 19:11:27 +00:00
Bart Van Assche
7d9212affb
scstadmin: Avoid shadowing the errorString declaration, part 4
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7939 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-16 19:08:50 +00:00
Bart Van Assche
2b238a6abb
scstadmin: Avoid shadowing the errorString declaration, part 3
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7938 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-16 19:03:39 +00:00
Bart Van Assche
6b566f8adf
scstadmin: Avoid shadowing the errorString declaration, part 2
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7937 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-16 18:59:50 +00:00
Bart Van Assche
2a84df8445
scstadmin: Avoid shadowing the errorString declaration
...
This patch does not change any functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7936 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-16 18:44:33 +00:00
Bart Van Assche
b56d94a153
scstadmin: Make it easier to debug regression test 06
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7935 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-16 18:32:42 +00:00