Commit Graph

4574 Commits

Author SHA1 Message Date
Vladislav Bolkhovitin
350542a8cf The patch below fixes the following category of checkpatch complaints:
WARNING: externs should be avoided in .c files

The patch below has been tested by rerunning the following command
and by verifying its output:
scripts/run-regression-tests 2.6.26.8

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1263 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 18:38:18 +00:00
Vladislav Bolkhovitin
f999f978ee Exclude unneeded code from the kernel patch generation
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1262 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 18:02:25 +00:00
Vladislav Bolkhovitin
7009a257f0 Possibility to reset SGV pools statistic added
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1261 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 17:55:37 +00:00
Vladislav Bolkhovitin
36104c26c2 Remove -c sed option, because it isn't available on all systems
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1260 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 17:32:22 +00:00
Vladislav Bolkhovitin
e972601875 Printk cleanups and minor fixes
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1259 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 17:26:39 +00:00
Vladislav Bolkhovitin
42b25258f9 Major numbers cleanup
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1258 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 16:52:26 +00:00
Vladislav Bolkhovitin
ac29495cee Minor output buffer size related fixes
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1257 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 11:52:32 +00:00
Bart Van Assche
b08548b174 Added debug2perf and disable_proc configurations to the regression tests.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1256 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 10:57:36 +00:00
Bart Van Assche
942aef8387 Compiles now with CONFIG_SCST_PROC undefined.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1255 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 10:56:44 +00:00
Bart Van Assche
2d90ba1a1e Fixed a checkpatch complaint about trailing whitespace. Verified that the output of svn diff -x -w is empty for this modification.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1254 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 09:16:52 +00:00
Bart Van Assche
0af5e1b9e3 Fixed whitespace-related checkpatch errors. Verified that the output of
svn diff -x -w is empty for this changeset.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1253 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 06:59:33 +00:00
Bart Van Assche
b9916d6e55 Updated kernel versions 2.6.31.4 and 2.6.27.37 to 2.6.31.5 and 2.6.27.38 respectively.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1252 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-23 06:58:08 +00:00
Bart Van Assche
f1c41721ea Re-enabled the debug2release build.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1251 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 19:14:47 +00:00
Bart Van Assche
ef11d133df Prepared switch to "make debug2release".
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1250 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 19:05:21 +00:00
Bart Van Assche
64803db9f1 When command-line option -u is passed to scripts/generate-kernel-patch,
undefine the preprocessor symbol
CONFIG_TCP_ZERO_COPY_TRANSFER_COMPLETION_NOTIFICATION.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1249 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 18:26:19 +00:00
Vladislav Bolkhovitin
7edf6fffdf ISID 0 is perfectly valid.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1248 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 16:51:51 +00:00
Vladislav Bolkhovitin
e16c451c44 Cleanup: iscsi_is_key_declarative() name is misleading, iscsi_is_key_internal() is much better.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1247 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 16:40:38 +00:00
Vladislav Bolkhovitin
95f10bd7ca Flush device's SGV cache in dev_user_unjam_dev() for faster cleanup.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1246 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 16:35:19 +00:00
Vladislav Bolkhovitin
83c20d9344 Checkpatch and sparse cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1245 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 16:11:13 +00:00
Vladislav Bolkhovitin
29feda5143 Let's don't check if data should be copied between dev handler's and target driver's buffers on the fast path and make it a duty of a target driver who might need it.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1244 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 15:40:42 +00:00
Vladislav Bolkhovitin
6606bb50de - Use vfs_readv/vfs_writev instead of direct calls to VFS functions
- Cleanups



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1243 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 15:19:11 +00:00
Vladislav Bolkhovitin
173e97d2bd Set max_cmd_len correcty.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1242 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 15:17:38 +00:00
Vladislav Bolkhovitin
b665918dea Use of strict_strtoul() instead of simple_strtoul() as suggested by checkpatch. Other uses of simple_strtoul() are OK and can't be converted
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1241 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 12:58:55 +00:00
Vladislav Bolkhovitin
b65169a791 Doc about additional 2.6.26.x commits updated.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1240 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 12:49:18 +00:00
Vladislav Bolkhovitin
ed5513284c From ac2ef12020817c8e8edb7b4fe57f053c62cc833e Mon Sep 17 00:00:00 2001
From: Andrew Vasquez <andrew.vasquez@qlogic.com> 
Date: Thu, 14 Aug 2008 09:39:35 -0700 
Subject: qla2xxx: Set an rport's dev_loss_tmo value in a consistent manner. 
 
[ Upstream commit 85821c906cf3563a00a3d98fa380a2581a7a5ff1 ] 
 
As there's no point in adding a fixed-fudge value (originally 5 
seconds), honor the user settings only.  We also remove the 
driver's dead-callback get_rport_dev_loss_tmo function 
(qla2x00_get_rport_loss_tmo()). 
 
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com> 
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> 
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 

Submitted by Gal Rosen <galr@storwize.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1239 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 12:39:36 +00:00
Vladislav Bolkhovitin
f01c5a9355 Fix incorrect WARN_ON()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1238 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 12:33:45 +00:00
Vladislav Bolkhovitin
54b99faafa Fix compilation with enabled procfs on kernels <2.6.26. Sysfs from now will be supported only on kernels >=2.6.26.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1237 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 12:32:40 +00:00
Vladislav Bolkhovitin
9c10f10b00 Experimental optimization. Suppose that if sock_recvmsg() returned less data than requested, then next time it will return -EAGAIN, so there's no point to call it again.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1236 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-22 12:06:07 +00:00
Bart Van Assche
a8414808ab Only extract the kernel tree when it's needed, i.e. for the 2.6.26.* kernels.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1235 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-21 20:03:39 +00:00
Bart Van Assche
7c9a154e05 Added support for continued lines.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1234 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-21 19:45:35 +00:00
Bart Van Assche
99d9057717 Temporarily disabled release build testing.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1233 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-21 19:43:48 +00:00
Vladislav Bolkhovitin
ad475b15a9 LUNs replace implemented
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1232 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-21 17:41:26 +00:00
Vladislav Bolkhovitin
ef50e616e0 "Commands" attribute added for scst_user
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1231 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-21 17:14:27 +00:00
Vladislav Bolkhovitin
a09681b1fb qla2x00_schedule_rport_del() must used _irq[save,restore] spinlocks, because it can be called on the IRQ.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1230 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-21 16:51:48 +00:00
Vladislav Bolkhovitin
82b04b2a00 Merge of the sysfs branch. To enable the sysfs interface you should run "make disable_proc". To switch back on the procfs interface you should run "make disable_proc".
The sysfs intarface is mostly finished. Only initiators-oriented access control not implemented and not all target drivers are updated. Only qla2x00t has been fully updated.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1229 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-21 16:49:52 +00:00
Vladislav Bolkhovitin
a09d341a0c Fix for inconsistency in compile time warning about patch io_context for 2.6.26 kernel, noticed by Mark Buechler <mark.buechler@gmail.com>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1228 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-20 18:40:06 +00:00
Vladislav Bolkhovitin
cc83f517ea - Fix for a possible DoS, when misbehavine scst_user's handler hangs several memory allocations (= count of iSCSI read threads) and by so prevents other sessions from being served correctly. Spotted by Erez Zilber <erezzi.list@gmail.com>
- iSCSI read state machine cleanups

 - Fix a race when just freed iSCSI session accessed, because the corresponding SCST session is still being unregistered.



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1224 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-15 15:56:57 +00:00
Bart Van Assche
c0cc23e7f8 Fixed typo.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1220 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-15 07:48:39 +00:00
Bart Van Assche
c821d226f3 Run a full check not only on the first specified kernel version but also on kernel version 2.6.26.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1219 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-15 07:15:56 +00:00
Bart Van Assche
b9528d1407 Added variable generating_upstream_patch_defined. When set to 1, this
variable tells the script specialize-patch to treat the preprocessor
symbol GENERATING_UPSTREAM_PATCH as defined.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1218 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-15 07:14:54 +00:00
Bart Van Assche
c031d72333 Added command-line option -u to scripts/generate-kernel-patch, which has
the following effect:
- Exclude the put_page_callback patch.
- Enable #define GENERATING_UPSTREAM_PATCH.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1217 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-15 07:12:09 +00:00
Bart Van Assche
5a15dc1b9c Made sure that the qla2x00t patches are only included in the output of
scripts/generate-kernel-patch for kernel version 2.6.26. As a result,
during the nightly build the qla2x00t code will only be checked with
checkpatch and sparse for the 2.6.26 kernel.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1216 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-15 07:09:40 +00:00
Bart Van Assche
68e136e779 Made sure that patch generation also works for other kernel versions than 2.6.26.8.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1215 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-14 17:10:46 +00:00
Vladislav Bolkhovitin
b184e11c0a From 20246fe8e4ea34f2ab556b7c50037b976051cab7 Mon Sep 17 00:00:00 2001
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
Date: Tue, 21 Oct 2008 20:25:04 +0200
Subject: SCSI: qla2xxx: Skip FDMI registration on ISP21xx/22xx parts.

commit 031e134e5f95233d80fb1b62fdaf5e1be587597c upstream

Firmware does not have the facilities to issue management server
IOCBs.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Ferenc Wagner <wferi@niif.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Submitted by Gal Rosen <galr@storwize.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1214 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-14 16:30:44 +00:00
Vladislav Bolkhovitin
384319da18 From 61c8bd1d3a9e7e57843d98d9b133fec77ecf4e1b Mon Sep 17 00:00:00 2001
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
Date: Mon, 29 Sep 2008 15:15:04 +0000
Subject: SCSI: qla2xxx: Defer enablement of RISC interrupts until ISP initialization completes.

commit 048feec5548c0582ee96148c61b87cccbcb5f9be upstream

Josip Rodin noted
(http://article.gmane.org/gmane.linux.ports.sparc/10152) the
driver oopsing during registration of an rport to the
FC-transport layer with a backtrace indicating a dereferencing of
an shost->shost_data equal to NULL.  David Miller identified a
small window in driver logic where this could happen:

    > Look at how the driver registers the IRQ handler before the host has
    > been registered with the SCSI layer.
    >
    > That leads to a window of time where the shost hasn't been setup
    > fully, yet ISRs can come in and trigger DPC thread events, such as
    > loop resyncs, which expect the transport area to be setup.
    >
    > But it won't be setup, because scsi_add_host() hasn't finished yet.
    >
    > Note that in Josip's crash log, we don't even see the
    >
    >         qla_printk(KERN_INFO, ha, "\n"
    >             " QLogic Fibre Channel HBA Driver: %s\n"
    >             "  QLogic %s - %s\n"
    >             "  ISP%04X: %s @ %s hdma%c, host#=%ld, fw=%s\n",
    >  ...
    >
    > message yet.
    >
    > Which means that the crash occurs between qla2x00_request_irqs()
    > and printing that message.

Close this window by enabling RISC interrupts after the host has
been registered with the SCSI midlayer.

Reported-by: Josip Rodin <joy@entuzijast.net>
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Submitted by Gal Rosen <galr@storwize.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1213 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-14 16:29:08 +00:00
Vladislav Bolkhovitin
abe7cc6bdd From 1e42c5591e3a65ef36ea90c4461c09e78280417d Mon Sep 17 00:00:00 2001
From: Andrew Vasquez <andrew.vasquez@qlogic.com>
Date: Wed, 14 Oct 2009 08:51:21 +0200
Subject: [PATCH] qla2xxx: Add dev_loss_tmo_callbk/terminate_rport_io callback support.

[ Upstream commit 5f3a9a207f1fccde476dd31b4c63ead2967d934f ]

Signed-off-by: Seokmann Ju <seokmann.ju@qlogic.com>
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Submitted by Gal Rosen <galr@storwize.com>



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1212 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-14 16:25:36 +00:00
Vladislav Bolkhovitin
f07eb7a5c9 - Add raw accumulated times in the latency statistics output
- Minor cleanup



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1211 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-14 16:20:19 +00:00
Bart Van Assche
23aeb6590f Apply the 2.6.31 kmemcheck patch not only to current but also to future 2.6.31.* kernels since the change is small that the submitted patch will be integrated.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1210 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-14 14:21:19 +00:00
Bart Van Assche
2a359798cf Applied fix for sparse warning to 2.6.31.4 too.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1209 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-14 07:07:53 +00:00
Bart Van Assche
593360a1ec Updated kernel versions 2.6.27.36 and 2.6.31.3 to 2.6.27.37 and 2.6.31.4 respectively.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1208 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-10-13 19:52:46 +00:00