Commit Graph

617 Commits

Author SHA1 Message Date
Bart Van Assche
098f6bd1c5 ib_srpt: Kernel v4.4 build fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6698 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-11-18 22:10:54 +00:00
Bart Van Assche
948482551c ib_srpt: Follow-up for r6628
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6646 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-11-10 01:55:23 +00:00
Bart Van Assche
37c4911d4f ib_srpt: Use kmalloc_array() instead of kmalloc() with multiply
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6634 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-11-09 20:08:07 +00:00
Bart Van Assche
6a491c8cda ib_srpt: Avoid that checkpatch complains about using ENOSYS
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6628 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-11-09 19:09:44 +00:00
Bart Van Assche
8ac8060d69 ib_srpt: Place constants at the right-hand-side in comparisons
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6610 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-11-06 18:55:17 +00:00
Vladislav Bolkhovitin
5f7ac7f4bf Version updated to 3.2.0
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6593 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-11-06 06:17:17 +00:00
Bart Van Assche
711e3c54a5 ib_srpt: Remove one_target_per_port parameter completely
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6567 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-11-02 22:44:48 +00:00
Bart Van Assche
0acf6c0ec2 ib_srpt: Increase maximum sg-list length from 128 to 65536
This avoids that the following message appears in the target system
kernel log for SRP commands with a scatterlist with e.g. 256 elements:

Unable to complete command due to SG IO count limitation


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6546 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-10-15 22:08:47 +00:00
Bart Van Assche
4d9c05f1ee ib_srpt: Increase maximum sg-list length from 128 to 65536
This avoids that the following message appears in the target system
kernel log:
    
Unable to complete command due to SG IO count limitation


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6545 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-10-14 22:22:19 +00:00
Bart Van Assche
166c12eb49 ib_srpt: Account RDMA writes into sq_wr_avail
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6544 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-10-14 22:21:47 +00:00
Bart Van Assche
fd6e33756c ib_srpt: Fix error handling in srpt_xmit_response()
This patch fixes a regression introduced in patch "ib_srpt: Convert
srpt_xfer_data() return value" (trunk r6103).


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6543 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-10-14 22:21:26 +00:00
Bart Van Assche
b7f49e8afc ib_srpt: Fix a diagnostic message
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6542 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-10-14 22:19:12 +00:00
Bart Van Assche
cd346f8c64 ib_srpt: Remove dead code
This is a follow-up for patch "ib_srpt: Micro-optimize SCSI command
processing" (trunk r4784).


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6541 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-10-14 22:18:47 +00:00
Bart Van Assche
3438e73474 ib_srpt: Fix grammar in a source code comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6540 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-10-14 22:15:27 +00:00
Bart Van Assche
17f1770fab ib_srpt: Port to Linux kernel v4.3.0
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6520 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-09-29 00:06:08 +00:00
Bart Van Assche
cba8f3ab7e ib_srpt: Build fix for the nightly build against kernel v4.2
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6507 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-09-16 16:43:32 +00:00
Bart Van Assche
ed07ec49a8 ib_srpt: Avoid that relogin triggers a large number of FLUSH ERR messages
Reported-by: Grant Albitz <Grant@schultztechnology.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6498 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-09-10 16:31:31 +00:00
Bart Van Assche
68ce2d0ce4 ib_srpt: Port to MOFED 3.0
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6497 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-09-08 16:18:27 +00:00
Bart Van Assche
0651bc1e4e ib_srpt: Linux kernel v4.2 ib_create_cq() build fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6426 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 23:49:48 +00:00
Bart Van Assche
5f95edc612 ib_srpt: Test whether ib_create_send_mad() needs a base_version argument
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6424 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 23:24:26 +00:00
Bart Van Assche
87b6fde56d ib_srpt: Linux kernel v4.2 build fix
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6423 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-14 22:50:25 +00:00
Bart Van Assche
44542c9752 ib_srpt: Follow-up for r6410
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6411 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-09 19:11:04 +00:00
Bart Van Assche
b448c6edf4 ib_srpt: Add support for systems with more than 64 CPU's
Avoid that the following warning is reported on systems with more
than 64 CPU's:

WARNING: CPU: 0 PID: 4762 at drivers/scst/srpt/ib_srpt.c:4179 init_module+0x1d8f42/0x1db887 [ib_srpt]()
Call Trace:
 [<ffffffff8154f2ed>] dump_stack+0x46/0x58
 [<ffffffff8104b4ec>] warn_slowpath_common+0x8c/0xc0
 [<ffffffff8104b53a>] warn_slowpath_null+0x1a/0x20
 [<ffffffffa0236f42>] init_module+0x1d8f42/0x1db887 [ib_srpt]
 [<ffffffffa0233000>] ? 0xffffffffa0233000
 [<ffffffffa005e000>] ? 0xffffffffa005e000
 [<ffffffffa015d587>] ib_register_client+0x87/0xc0 [ib_core]
 [<ffffffffa005e0ef>] init_module+0xef/0x1000 [ib_srpt]
 [<ffffffffa005e000>] ? 0xffffffffa005e000
 [<ffffffff810002bc>] do_one_initcall+0x8c/0x1c0
 [<ffffffff81149022>] ? __vunmap+0xc2/0x110
 [<ffffffff810bb3e3>] load_module+0x1b03/0x22a0
 [<ffffffff810b7e80>] ? show_initstate+0x60/0x60
 [<ffffffff810bbcce>] SyS_finit_module+0x8e/0x90
 [<ffffffff81555a32>] system_call_fastpath+0x12/0x17

Reported-by: Jack Wang <xjtuwjp@gmail.com>


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6410 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-07-08 18:23:24 +00:00
Bart Van Assche
9bfdc312d3 ib_srpt: RHEL 5 build fix
Make the ib_srpt driver build again on RHEL 5 systems. See also
r6138.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6334 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-16 20:15:12 +00:00
Bart Van Assche
550ab7c1d3 ib_srpt: RHEL 7.1 build fix
With the RHEL 7.0 kernel ib_register_mad_agent() takes eight
arguments. With the RHEL 7.1 kernel the same function takes nine
arguments. Detect at build time how many arguments this function
takes.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6331 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-16 20:12:28 +00:00
Bart Van Assche
020ec68ddc ib_srpt: Change default behavior from using SRQ to not using SRQ
Although the non-SRQ mode needs more resources that mode has the
advantage that the end-to-end flow control mechanism is used.

From the IB spec:

C9-150.2.1: For QPs that are not associated with an SRQ, each HCA
receive queue shall generate end-to-end flow control credits. If
a QP is associated with an SRQ, the HCA receive queue shall not
generate end-to-end flow control credits.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6329 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-16 18:57:16 +00:00
Vladislav Bolkhovitin
906f4dfefb Merge t10-pi branch back
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6192 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-05-01 04:21:56 +00:00
Bart Van Assche
33a4bccc38 ib_srpt: Avoid that aborting a command triggers a race condition
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6181 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-10 05:39:44 +00:00
Bart Van Assche
98fb52432c ib_srpt: Specify a valid completion vector during completion queue creation
Avoid that SRP login can fail as follows:

kernel: ib_srpt: failed to create CQ: cqe 320; c.v. 17; ret -22


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6179 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-04-09 15:06:36 +00:00
Bart Van Assche
c32f79f6c1 Revert T10-PI support
The T10-PI patch (r6162) increases the time needed to run mkfs.ext4
over iSCSI from less than a second to several minutes. This is a
regression so revert the T10-PI patch until there is sufficient time
to find the root cause of this regression and to fix this regression.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6171 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-31 09:51:24 +00:00
Bart Van Assche
a3f4f28711 Build fixes - follow-up for r6162
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6164 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-29 17:32:59 +00:00
Vladislav Bolkhovitin
fe38e4acb2 Copyrights updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6146 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-19 00:01:03 +00:00
Bart Van Assche
940faa9ad4 ib_srpt: Enable building against OFED headers without patching the build system
Additionally, include the OFED flavor name in the ib_srpt version number.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6138 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-02 14:28:25 +00:00
Bart Van Assche
ef48d260d2 ib_srpt: Suppress a compiler warning when building against Mellanox OFED
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6137 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-02 14:24:33 +00:00
Vladislav Bolkhovitin
4ac6d7a26d [PATCH] scst: Drop detect() method
There is no need for a detect() method - code that is present in such
a method can be moved to module_init(). Hence declare this method
obsolete. Leave the detect pointer member in the target template for
now for out-of-tree SCST drivers.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>

with some improvements



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6113 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-21 04:32:36 +00:00
Bart Van Assche
35db9c65f3 ib_srpt: Suppress three more checkpatch warnings
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6107 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-17 07:21:01 +00:00
Bart Van Assche
f974dee9b0 ib_srpt: Suppress a checkpath complaint
Avoid that checkpatch reports the following:

WARNING: Possible unnecessary 'out of memory' message


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6106 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-17 07:08:49 +00:00
Bart Van Assche
68a9178e4a ib_srpt: Remove redundant forward declarations
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6105 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 15:47:46 +00:00
Bart Van Assche
56d3217eb0 ib_srpt: Update a source code comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6104 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 15:43:44 +00:00
Bart Van Assche
d46a3e8bab ib_srpt: Convert srpt_xfer_data() return value
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6103 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 14:49:45 +00:00
Bart Van Assche
59f25b783e ib_srpt: Eliminate an argument from srpt_xfer_data()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6102 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 14:34:00 +00:00
Bart Van Assche
5b5d944140 ib_srpt: Rename more variables
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6101 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 13:41:31 +00:00
Bart Van Assche
aa52348481 ib_srpt: Fix a checkpatch complaint
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6100 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 13:21:34 +00:00
Bart Van Assche
4ddf8b19ec ib_srpt: Clean up an error message
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6099 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 13:18:18 +00:00
Bart Van Assche
585df7c5f6 ib_srpt: Rename a few variables
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6098 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 13:16:52 +00:00
Bart Van Assche
edb4d579fb ib_srpt: Shorten a source code comment
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6097 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 12:53:12 +00:00
Bart Van Assche
c2b09b243c ib_srpt: Change type of the first argument of srpt_get_ioc()
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6096 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 12:48:36 +00:00
Bart Van Assche
460c0bdada ib_srpt: Swap the order of two declarations
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6095 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 10:56:26 +00:00
Bart Van Assche
c8e0a2c711 ib_srpt: Reorder structure members
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6094 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 10:40:05 +00:00
Bart Van Assche
b0ed8ed58c ib_srpt: Convert print and trace statements
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6093 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-02-16 10:26:21 +00:00