Bart Van Assche
fda71c077d
Include <poll.h> instead of <sys/poll.h>
...
According to the Single Unix Specification, the poll() function has been
declared in the <poll.h> header file. This makes the SCST code compatible
with the musl C library. See also https://en.wikipedia.org/wiki/Musl . See
also https://github.com/bvanassche/scst/issues/23 .
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8992 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-31 03:41:17 +00:00
Bart Van Assche
08e532715d
Remove procfs support
...
Since all RHEL/CentOS 5 users have upgraded to a newer version, procfs
support is no longer necessary. Hence remove procfs support. This patch
has been generated as follows:
git grep -lw CONFIG_SCST_PROC iscsi-scst qla2x00t scst scst_local srpt |\
while read f; do
echo ${f}
unifdef -U CONFIG_SCST_PROC ${f} >${f}.out
mv ${f}.out ${f}
done
followed by two small manual edits in scst/include/scst.h and also in
qla2x00t/qla2x00-target/qla2x00t.c.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7999 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-02 20:04:25 +00:00
Bart Van Assche
c55eaa7d5e
iscsi-scstd: Change the gcc-specific __FUNCTION__ into __func__
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7520 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 22:02:24 +00:00
Vladislav Bolkhovitin
f549829482
Copyrights updated
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7396 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-04-12 03:49:10 +00:00
Bart Van Assche
642744c9fc
Fix spelling of "Ardis Technologies"
...
Reference: http://www.ddpsan.com/support-sales/about-us .
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7165 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2017-05-02 22:32:06 +00:00
Vladislav Bolkhovitin
68fa7e1a0d
Copyright updates
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7146 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2017-04-22 03:19:52 +00:00
Vladislav Bolkhovitin
344387c40e
iscsi-scstd: replace signal() with sigaction()
...
Replace signal() with sigaction() for validity in a multithreaded process
Signed-off-by: David Butterfield <dab21774@gmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7139 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2017-04-21 01:02:25 +00:00
Vladislav Bolkhovitin
bcb87d57ec
iscsi: logging improvements for iscsi_scstd.c
...
Logging improvements for iscsi_scstd.c print more information about failures.
Signed-off-by: David Butterfield <dab21774@gmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7113 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2017-04-13 23:16:57 +00:00
Vladislav Bolkhovitin
d236725cae
create_and_open_dev() returns a (-errno), so the "if (iser_fd...)" check should
...
detect *any* negative return value as a case when fd should be set to -1.
Signed-off-by: David Butterfield <dab21774@gmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7108 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2017-04-13 22:30:25 +00:00
Bart Van Assche
3990a6ccd4
iscsi-scstd: Insert a blank line after declarations
...
Additionally, surround complex values with parentheses, declare static
char arrays const and change C++ comments into C comments.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6849 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 16:24:59 +00:00
Bart Van Assche
2681ed8bcb
iscsi-scstd: Fix checkpatch complaints about whitespace
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6847 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-03-27 16:10:45 +00:00
Vladislav Bolkhovitin
fa2f54ac9e
Copyrights updated
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6787 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2016-01-22 04:04:43 +00:00
Bart Van Assche
bb0a7c894a
iscsi-scstd: Annotate a fall-through for Coverity
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6388 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:32:27 +00:00
Bart Van Assche
74b4104994
iscsi-scstd: Avoid that Coverity complains about a use-after-free
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6374 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:25:05 +00:00
Bart Van Assche
b3f49a0a17
iscsi-scstd: Annotate fall-throughs for Coverity
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6373 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-17 00:24:25 +00:00
Bart Van Assche
6aaeca1cd9
Merge iser branch r6234 into trunk
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6235 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-06-10 15:35:26 +00:00
Vladislav Bolkhovitin
fe38e4acb2
Copyrights updated
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@6146 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2015-03-19 00:01:03 +00:00
Vladislav Bolkhovitin
00851a7501
Merge of adding iSER web page and copyright updates from the iSER branch
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@5241 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2014-01-28 05:17:26 +00:00
Vladislav Bolkhovitin
10ca1d2f20
Copyrights updated
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4767 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-02-20 02:05:29 +00:00
Vladislav Bolkhovitin
0252d5f9c9
Limit FirstBurstLength to improve TASK QUEUE FULL handling
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4764 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2013-02-19 01:17:33 +00:00
Vladislav Bolkhovitin
d3b4b46223
Patch improving handling of errors during passing connection to the kernel.
...
From Lev Vainblat <lev@zadarastorage.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4295 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-05-11 01:20:26 +00:00
Vladislav Bolkhovitin
eb95049061
Copyrights updated + cleanups
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4216 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-04-18 02:26:39 +00:00
Vladislav Bolkhovitin
5c2cde6757
Cleanup: move misc routines in misc.c
...
This patch moves the following utility functions from iscsi_scstd.c to misc.c
and makes them public (i.e. non-static):
* set_non_blocking
* sock_set_keepalive
Signed-off-by: Sergey Myasnikov <tigra564@gmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@4160 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2012-03-12 21:52:35 +00:00
Vladislav Bolkhovitin
94418431ce
Patch from Abhilash Sankar <Abhilash.S@hcl.com> with some fixes
...
Issue:
------------
The DevRegAttribute is sending a different Source Attribute (ISCSI name) which
represents the Storage Node for each target. So Microsoft isns server considers
the last request as the storage node and doesn't discover the previous targets.
Root Cause
----------------
Function ISNS_FUNC_DEV_ATTR_REG
Target A
Source attribute
ISCSI-Name = <IQN A Name>
Operating Attribute
ISCSI-Name = <IQN A Name>
Flags
Replace Access = 1
Target B
Source attribute
ISCSI-Name = <IQN B Name>
Operating Attribute
ISCSI-Name = <IQN B Name>
Replace Access = 1
So as per the request format Microsoft isns Server always takes the last target
as the source node. and register the same. Hence it doesn't discover the
targets other than last one. The Source Attribute has to be fixed for all targets. It
would be better if we use the first target iscsi name (rather than the last target
iscsi name) as source attribute iscsi name to represent the storage node.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3863 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-09-18 00:58:15 +00:00
Vladislav Bolkhovitin
8b90327419
Modified patch from Bart Van Assche <bvanassche@acm.org> fixing errors reporting
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3552 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-06-07 18:08:58 +00:00
Vladislav Bolkhovitin
aa72d67856
Patch from Stefan Hauser <st.hauser@googlemail.com> with some style changes fixing case when after a error
...
between sessions_count increment and the corresponding session creation, sessions_count is not decremented.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3353 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-04-04 17:58:59 +00:00
Vladislav Bolkhovitin
2a230b19ee
Errors reporting cleanup
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3245 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-02-09 22:48:24 +00:00
Vladislav Bolkhovitin
f3238333dd
Copyrights updated
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3200 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2011-01-06 20:02:04 +00:00
Vladislav Bolkhovitin
e24296ad98
Fix case when after INCOMING_MAX overflow no listen events requested to be provided by poll().
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3088 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-12-15 15:48:51 +00:00
Vladislav Bolkhovitin
492e33a312
- Move nl_open() after kernel_open() to avoid issues when second start could skrew netlink states for the first instance
...
- Avoid compiler warn_unused_result warning
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1837 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-07-17 16:44:22 +00:00
Vladislav Bolkhovitin
ec3640be0b
Partially merge of IET r307: allows to redirect initiators to another portals
...
+
Cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1735 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-03 19:17:52 +00:00
Vladislav Bolkhovitin
459f589b34
- Delivery error response (instead of dropping connection) fixed
...
- Race when target deleted before the session(s) removal event(s) processed fixed
- Docs updated
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1733 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-06-01 18:28:41 +00:00
Vladislav Bolkhovitin
5406a07d26
Various iSCSI initiators access control and visibility improvements. Particularly:
...
- SendTargets now returns all (allowed) portals. Particularly based on IET r230, 234, 249 and 264.
- Initiators assigned to security groups without LUNs will not see the target during discovery and forbidden to login to it
- Per portals access control added
- Negative sign added to wildcard matching
- Docs updated
- Cleanups and minor fixes
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1685 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-05-07 18:08:52 +00:00
Vladislav Bolkhovitin
7d218fb344
States cleanup and fix related login problem
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1650 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-23 11:26:39 +00:00
Vladislav Bolkhovitin
f025190b53
- Loosly merge of IET r271: fix connection and session leak on connection preparation stages
...
- Cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1645 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-21 22:17:43 +00:00
Vladislav Bolkhovitin
623c62d339
IET r219: Fixed log_debug to properly evaluate logging level.
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1640 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-21 17:51:50 +00:00
Vladislav Bolkhovitin
4d5aaf047b
Copyrights updated
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1585 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-04-06 08:57:48 +00:00
Vladislav Bolkhovitin
08e7c3fba6
Great threads handling and performance improvements:
...
- io_context not needed anymore
- Now threads pool can be per session
- Each device now can have own type of threads pool with own threads count
+ docs updates and some cleanups and minor fixes.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1563 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-03-25 19:43:41 +00:00
Vladislav Bolkhovitin
1f216064f3
Uniform max queue depth handling in iSCSI
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1556 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-03-18 11:44:39 +00:00
Vladislav Bolkhovitin
4d96089e50
Sysfs interface for targets made uniform. ISCSI-SCST made confirming the uniformity requirements. See README for details.
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1511 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-02-17 19:07:54 +00:00
Vladislav Bolkhovitin
f519e2c265
Fix spelling typos.
...
Signed-off-by: Dotan Barak <dotanba@gmail.com >
with additional spelling fixes noticed by frank zago <fzago@systemfabricworks.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1396 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-12-16 11:35:12 +00:00
Vladislav Bolkhovitin
c918eb371e
gcc 4.4.1 (as included in openSUSE 11.2) complains about the user-space iSCSI code because it breaks strict-aliasing rules. The reported warnings should be addressed because not doing so can result in the compiler generating incorrect code. The patch below fixes these compiler warnings.
...
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1352 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-11-20 19:53:12 +00:00
Vladislav Bolkhovitin
6153a079a3
iSCSI target sysfs "enabled" attribute implemented
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1324 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-11-06 18:41:37 +00:00
Bart Van Assche
6a80e5441e
Removed trailing whitespace.
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@905 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-06-16 06:29:04 +00:00
Vladislav Bolkhovitin
f572d4ff79
- Copyrights updated.
...
- Other minor updates
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@803 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-04-27 19:01:28 +00:00
Vladislav Bolkhovitin
27c5d8dcdf
The patch below fixes the following recently introduced checkpatch complaints:
...
* use tabs not spaces
* Macros with complex values should be enclosed in parenthesis.
* printk() should include KERN_ facility level.
The patch below has been verified by reviewing it carefully and by verifying the output of the following command: scripts/run-regression-tests -k 2.6.28.8
Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@707 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-03-20 12:36:01 +00:00
Vladislav Bolkhovitin
e252aadf35
- Fixed problems in reading iscsi-scst.conf
...
- Cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@698 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-03-17 18:00:26 +00:00
Vladislav Bolkhovitin
bda620b65a
- Connection reinstatement fixes
...
- Minor cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@687 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-03-04 18:31:35 +00:00
Vladislav Bolkhovitin
bc7c69bfc4
- Fixed a major IET-derived iSCSI RFC violation: sessions and connections were not working
...
- A lot of cleanups and minor fixes, mostly IET-derived
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@685 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-03-03 18:13:23 +00:00
Vladislav Bolkhovitin
293c0ee1a3
- Iscsi-scst-adm fixes. It should be fully functional now.
...
- Other iSCSI-SCST user space fixes, improvements and cleanups.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@667 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2009-02-06 19:52:34 +00:00