Bart Van Assche
0bc77ddfd2
qla2x00t, regression tests: Move QLogic target code
...
Move the QLogic target code from drivers/scst/qla2x00-target/ to
drivers/scsi/qla2xxx/.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8084 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-26 02:03:17 +00:00
Bart Van Assche
0221741457
qla2x00t: Remove instructions to rebuild the kernel
...
Since the zero-copy patch is no longer supported it is no longer necessary
to rebuild the kernel in order to use SCST.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8081 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-25 22:51:39 +00:00
Bart Van Assche
32261be1d8
qla2x00t/qla2x00-target/Makefile: Fix the path from where the SCST Modules.symvers file is read
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8080 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-25 22:36:03 +00:00
Bart Van Assche
dc7e039124
Makefiles: Remove most instances of $(SCST_INC_DIR)
...
Move the $(SCST_INC_DIR) definitions from the out-of-tree sections into
the in-kernel sections. Since SCST is now distributed as a single tar
archive, only support in-tree builds with $(SCST_INC_DIR) and $(SCST_DIR).
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8079 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-25 22:10:21 +00:00
Bart Van Assche
70d3c72779
Makefiles: Use ccflags-y instead of EXTRA_CFLAGS
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8076 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-25 19:56:17 +00:00
Bart Van Assche
74e5b31b95
Makefiles: Use cc-option instead of enable-Wextra
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8075 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-25 19:55:15 +00:00
Bart Van Assche
623d4e6d0a
Makefiles: Use build_mode instead of modifying the Makefile when switching the build mode
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8074 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-25 19:53:39 +00:00
Bart Van Assche
87d82bfa8f
Remove documentation references to procfs
...
Now that procfs has been removed, remove the references to procfs from
the documentation.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8000 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-02 20:06:25 +00:00
Bart Van Assche
08e532715d
Remove procfs support
...
Since all RHEL/CentOS 5 users have upgraded to a newer version, procfs
support is no longer necessary. Hence remove procfs support. This patch
has been generated as follows:
git grep -lw CONFIG_SCST_PROC iscsi-scst qla2x00t scst scst_local srpt |\
while read f; do
echo ${f}
unifdef -U CONFIG_SCST_PROC ${f} >${f}.out
mv ${f}.out ${f}
done
followed by two small manual edits in scst/include/scst.h and also in
qla2x00t/qla2x00-target/qla2x00t.c.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7999 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-03-02 20:04:25 +00:00
Bart Van Assche
4945ef6b3d
qla2x00t: Fix multiple checkpatch errors
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7970 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-21 16:25:17 +00:00
Bart Van Assche
1f2e6e0113
qla2x00t: Fix an out of bounds access
...
Avoid that KASAN reports the following:
BUG: KASAN: stack-out-of-bounds in q2t_async_event+0x27c/0x3a0 [qla2x00tgt]
Read of size 2 at addr ffff8880db407db0 by task swapper/0/0
CPU: 0 PID: 0 Comm: swapper/0 Tainted: G O 4.19.19-dbg+ #1
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
Call Trace:
<IRQ>
dump_stack+0xa4/0xfa
print_address_description+0x71/0x239
kasan_report.cold.6+0x242/0x301
__asan_load2+0x51/0x80
q2t_async_event+0x27c/0x3a0 [qla2x00tgt]
qla2x00_async_event+0x34f/0x2390 [qla2xxx_scst]
qla24xx_msix_default+0x2b8/0x300 [qla2xxx_scst]
__handle_irq_event_percpu+0x77/0x3c0
handle_irq_event_percpu+0x68/0xe0
handle_irq_event+0x5a/0x8b
handle_edge_irq+0x114/0x2f0
handle_irq+0x18d/0x205
do_IRQ+0x73/0x150
common_interrupt+0xf/0xf
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7917 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-02-11 00:11:01 +00:00
Bart Van Assche
d3e2f5ab99
Makefiles: Stop using $(SUBDIRS)
...
This patch avoids that the following warning is reported when building
against kernel v4.21:
================= WARNING ================
'SUBDIRS' will be removed after Linux 5.3
Please use 'M=' or 'KBUILD_EXTMOD' instead
==========================================
A quote from an upstream kernel patch:
commit 07e5823127155b3a29003aca926f87c9843f6810
Author: Andrew Morton <akpm@osdl.org >
Date: Mon Apr 12 01:05:40 2004 -0700
[PATCH] kbuild: external module support
From: Sam Ravnborg <sam@ravnborg.org >
Based on initial patch from Andreas Gruenbacher there is now better support
for building external modules with kbuild.
The preferred syntax is now:
make -C $KERNELSRC M=$PWD
but the old syntax:
make -C $KERNELSRC SUBDIRS=$PWD modules
will remain supported.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7851 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-12-31 19:03:14 +00:00
Bart Van Assche
43c6e39d3a
scst: Port to Linux kernel v4.21
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7849 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-12-31 18:56:29 +00:00
Bart Van Assche
3dcace8794
Remove trailing whitespace from multiple files
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7844 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-12-31 18:26:51 +00:00
Bart Van Assche
ab5ea2283f
qla2x00t: Read MBX_2 after MBC_PORT_NODE_NAME_LIST
...
MBX_2 contains the number of bytes required for the buffer, but
qla2x00_mailbox_command() doesn't request MBX_2 from the firmware.
Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com >
[ bvanassche: edited commit message ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7839 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-12-11 02:46:38 +00:00
Bart Van Assche
1587638134
Remove support for "make enable_proc" and "make disable_proc"
...
Since RHEL 5 and kernel versions before 2.6.26 rely on procfs support,
this patch removes support for RHEL 5.x and also for kernel versions
before 2.6.26.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7829 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-11-22 22:13:40 +00:00
Bart Van Assche
69fde133e9
Revert r7524
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7525 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-31 14:25:52 +00:00
Bart Van Assche
91b99af914
scst, srpt, iscsi-scst, qla2x00t, fcst: Bump version number to 3.4.0
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7524 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-31 14:24:20 +00:00
Bart Van Assche
e2a17c6a24
Change 'long long int' int 'long long'
...
This patch does not change any functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7505 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-10-14 03:57:53 +00:00
Bart Van Assche
e2e076cb84
qla2x00t: Add #include <linux/vmalloc.h>
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7478 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-09-27 02:22:57 +00:00
Bart Van Assche
b5c7df62aa
qla2x00t: Fix build against kernel versions >= v4.2
...
Reported-by: Pascal de Bruijn <p.debruijn@unilogic.nl >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7476 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-09-26 03:48:12 +00:00
Bart Van Assche
b1df825bbe
qla2x00t: Avoid using higher order page allocations
...
Avoid that qla2x00_get_node_name_list() fails as follows:
kworker/0:2: page allocation failure: order:4, mode:0x240c0c0(GFP_KERNEL|__GFP_COMP|__GFP_ZERO)
CPU: 0 PID: 101 Comm: kworker/0:2 Not tainted 4.9.124-scst #3
Hardware name: Supermicro SYS-1028U-E1CR4+/X10DRU-i+, BIOS 3.1 06/08/2018
Workqueue: events q2t_del_sess_work_fn [qla2x00tgt]
ffffa0954357f9e8 ffffffff9c2c2fd8 ffffffff9c721178 0000000000000001
ffffa0954357fa70 ffffffff9c13eb7a 0240c0c00240c0c0 ffffffff9c721178
ffffa0954357fa10 ffff9e6700000010 ffffa0954357fa80 ffffa0954357fa30
Call Trace:
dump_stack+0x4d/0x65
warn_alloc+0x13a/0x170
__alloc_pages_nodemask+0x486/0xd70
alloc_pages_current+0x6f/0x100
kmalloc_order+0x18/0x40
kmalloc_order_trace+0x24/0xa0
__kmalloc+0x163/0x190
qla2x00_get_node_name_list+0x249/0x3e0 [qla2xxx]
q2t_del_sess_work_fn+0xd8/0x4a0 [qla2x00tgt]
process_one_work+0x14f/0x440
worker_thread+0x48/0x4e0
kthread+0xd9/0xf0
ret_from_fork+0x22/0x30
This is a slightly modified version of a patch from Pascal de Bruijn
<p.debruijn@unilogic.nl >.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7475 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-09-23 03:03:38 +00:00
Vladislav Bolkhovitin
74b2ae36e2
qla2x00t: fix possible crash with DLM PR sync enabled
...
Reported-By: Aaron Knister <aaron.s.knister@nasa.gov >
Analyzed-by: Bart Van Assche <bvanassche@acm.org >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7468 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-08 22:25:43 +00:00
Bart Van Assche
546c6c6ebe
qla2x00t: Various coding style fixes
...
This patch does not change any functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7467 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-08 04:14:54 +00:00
Bart Van Assche
acc205d174
qla2x00t: Use %zd instead of %Zd
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7463 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-03 03:38:23 +00:00
Bart Van Assche
1a4f34578d
qla2x00t: Improve conformance with the coding standard further
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7462 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-03 03:37:32 +00:00
Bart Van Assche
8c2a32f3af
qla2x00t: Insert a space where the coding standard requires one
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7461 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-03 03:30:20 +00:00
Bart Van Assche
10961c3dfd
qla2x00t: Insert a space where the coding standard requires one
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7460 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-03 03:25:06 +00:00
Bart Van Assche
1ac05eb695
qla2x00t: Remove spaces where these are not allowed by the coding standard
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7459 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-03 03:19:17 +00:00
Bart Van Assche
d07888d5f9
qla2x00t: Change return (x) into return x
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7458 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-03 03:09:58 +00:00
Bart Van Assche
1b18174c12
qla2x00t: Fix if/else coding style
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7457 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-03 03:01:04 +00:00
Bart Van Assche
30cf7b4bda
qla2x00t: Fix more checkpatch complaints about whitespace
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7456 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-02 04:47:08 +00:00
Bart Van Assche
1c4649556d
qla2x00t: Do not initialise globals/statics to 0. Detected by checkpatch.
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7455 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-02 04:44:00 +00:00
Bart Van Assche
30c84b1282
qla2x00t: Do not initialise globals/statics to 0. Detected by checkpatch.
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7454 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-02 04:42:42 +00:00
Bart Van Assche
5f478050ae
qla2x00t: Fix checkpatch complaints about using spaces for indentation
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7453 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-02 04:41:04 +00:00
Bart Van Assche
a6d7968bd9
qla2x00t: Avoid that checkpatch complains that (foo*) should be (foo *)
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7452 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-02 04:27:58 +00:00
Bart Van Assche
8c3a885e4d
qla2x00t: Fix spelling errors
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7451 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-08-02 04:19:35 +00:00
Bart Van Assche
6864e0b759
scripts/run-regression-tests: Include the qla2xxx driver
...
Make sure that not only the qla2x00tgt but also the qla2xxx_scst driver
gets built when scripts/run-regression-tests is run.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7442 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-07-23 04:32:28 +00:00
Bart Van Assche
1c1693d06b
qla2x00t: Port to Linux kernel v4.17
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7439 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-07-23 04:29:35 +00:00
Bart Van Assche
eb2b6f6ccf
qla2xxx: Simplify the kernel v4.11 port
...
This patch does not change any functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7438 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-07-23 04:25:48 +00:00
Bart Van Assche
cf4c873849
qla2x00t: Introduce set_bsg_result()
...
This patch does not change any functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7437 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-07-23 04:25:20 +00:00
Bart Van Assche
b6949a24b1
qla2xxx: Fix two potential buffer overflows
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7436 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-07-23 04:24:16 +00:00
Vladislav Bolkhovitin
f549829482
Copyrights updated
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7396 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-04-12 03:49:10 +00:00
Bart Van Assche
a290c4ea4b
qla2x00t: Remove a cast from a debug statement
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7358 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-02-04 23:14:43 +00:00
Bart Van Assche
993cf71424
qla2x00t: Fix kernel-doc header inconsistencies
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7357 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-02-04 23:06:21 +00:00
Vladislav Bolkhovitin
9ac6a883d1
qla2x00t: fix in-kernel tree build
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7337 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-01-13 03:31:26 +00:00
Bart Van Assche
2594bc1fad
qla2x00t: Declare local functions 'static'
...
Additionally, remove the 'inline' keyword from these two functions
because today's compilers are better than humans at deciding which
functions should be inlined and which ones not. This patch avoids
that building the qla2x00t driver on RHEL 7.4 triggers two compiler
warnings.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7336 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-01-11 17:00:21 +00:00
Bart Van Assche
32ab3b1e1f
qla2x00t/extract-qla2xxx-orig: Use scripts/kernel-functions instead of duplicating it
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7335 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-01-09 00:45:26 +00:00
Bart Van Assche
52483357c7
qla2x00t: Fix build against kernel versions before v4.14
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7314 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2018-01-02 00:03:58 +00:00
Bart Van Assche
17f858726b
qla2x00t: Make qla2x00_store_class2_enabled() report failures
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@7313 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2017-12-31 20:41:24 +00:00