Bart Van Assche
af9504a0f5
iscsi-scst/usr/Makefile: Use -Werror when testing a compiler option
...
This is necessary for clang.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9430 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-05-29 01:16:42 +00:00
Bart Van Assche
c5e515b702
Address checkpatch complaints about duplicated words
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9383 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-29 03:15:01 +00:00
Bart Van Assche
095d255719
iscsi-scst: Fix a kernel-doc header
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9379 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-04-14 20:29:52 +00:00
Bart Van Assche
c0151f6cda
Bump the version number to 3.6.0
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9310 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2021-01-02 23:16:59 +00:00
Bart Van Assche
d3c92ea7aa
Bump the version number to 3.5.0
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9231 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-12-22 03:38:21 +00:00
Bart Van Assche
d10a7bf5d5
Restore support for building with clang
...
The previous commit removed support for building with clang. Restore support
for building with clang without breaking cross-compilation support.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9209 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-12-05 21:23:17 +00:00
Bart Van Assche
8eb850acce
Revert "Make it possible to build SCST with clang"
...
Since commit ecea60a694 breaks cross-compilation, revert it.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9208 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-12-05 18:39:38 +00:00
Bart Van Assche
a673470ce3
scst, iscsi-scst: Use struct kvec instead of struct iovec for kernel data
...
This patch does not change any functionality but removes multiple __force
__user casts.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9197 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-27 03:45:16 +00:00
Bart Van Assche
fd5b318880
iscsi-scst: Port to Linux kernel v5.10
...
mm_segment_t, get_fs() and set_fs() have been removed from Linux kernel
v5.10. Instead of adding more #ifdef / #endif directives, provide backports
for this typedef and these functions in iscsi_scst.h.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9189 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-11-23 15:58:00 +00:00
Bart Van Assche
a4ea5c02e1
iscsi-scst: Fix SHA-1 algorithm number
...
According to
https://www.iana.org/assignments/ppp-numbers/ppp-numbers.xml#ppp-numbers-9
the value of the SHA-1 algorithm is 6 and not 7, as it is now in
iscsi-scst/usr/chap.c. If on a client side node.session.auth.chap_algs is
SHA1, login fails.
Signed-off-by: Lev Vainblat <lev@zadarastorage.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9171 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-10-14 02:15:33 +00:00
Bart Van Assche
59f38038ab
iscsi-scst: Remove an obsolete comment
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9168 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-19 17:01:31 +00:00
Bart Van Assche
186798cec4
Use the fallthrough macro instead of a comment
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9166 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-09-16 14:28:36 +00:00
Bart Van Assche
bd3aa5d4a5
iscsi-scst: Port to Linux kernel v5.9
...
In Linux kernel v5.9 use of the KERNEL_SOCKPTR() function is mandatory
when calling setsockopt(). Implement that function for kernels before v5.9.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9149 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 21:16:47 +00:00
Bart Van Assche
f872ffa8a9
iscsi-scst/kernel/isert-scst/Kbuild: Fix the isert-scst build
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9140 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-29 15:52:09 +00:00
Bart Van Assche
c22a2d11b1
iscsi-scst: Fix the CONFIG_IPV6=n build
...
See also https://github.com/bvanassche/scst/issues/23 .
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9095 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-02 22:54:39 +00:00
Bart Van Assche
1b5e2eb482
isert-scst: Fail login if max_sge is too small
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9090 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-02 21:21:38 +00:00
Bart Van Assche
ecea60a694
Make it possible to build SCST with clang
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9089 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-08-02 21:19:24 +00:00
Bart Van Assche
86d602973b
iscsi-scst: Make this kernel module again independent of (M)OFED
...
This patch reverts f58c8248dd ("iscst-scst: Fix the OFED build"). This
patch partially reverts bd3355500a ("iscsi-scst, srpt: Rename the
PRE_CFLAGS variable into CONFTEST_FLAGS").
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9085 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 23:52:40 +00:00
Bart Van Assche
f58c8248dd
iscst-scst: Fix the OFED build
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9083 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 03:34:55 +00:00
Bart Van Assche
bd3355500a
iscsi-scst, srpt: Rename the PRE_CFLAGS variable into CONFTEST_FLAGS
...
The latter name reflects better the role of this variable. Remove the
CPPFLAGS assignment from srpt/src/Kbuild because it is not useful.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9082 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 03:34:35 +00:00
Bart Van Assche
93c2711530
iscsi-scst, srpt: Modify the message that reports which kernel headers are used
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9080 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 03:31:02 +00:00
Bart Van Assche
856bd8c1a1
configure tests: Rename Makefiles into Kbuild
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9078 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 02:52:51 +00:00
Bart Van Assche
2029062924
iscsi-scst, ib_srpt: Add a MODULE_LICENSE() to the configure tests
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9077 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 00:53:52 +00:00
Bart Van Assche
203d427368
iscsi-scst/kernel/isert-scst/Kbuild: Revert r9075 because it triggers duplicate symbol warnings on x86
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9076 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-26 00:49:48 +00:00
Bart Van Assche
4f36320d77
ib_srpt, iscsi-scst: Add the configure tests necessary for building against kernel v5.8
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9073 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:42:04 +00:00
Bart Van Assche
8a22ef6289
ib_srpt, iscsi-scst: Port to Linux kernel v5.8
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9060 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:09:23 +00:00
Bart Van Assche
64276e3dfb
Rename the iSCSI kernel module Makefiles into Kbuild
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9059 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-25 14:04:21 +00:00
Bart Van Assche
0a0a1bebe1
Ignore */conftest/*/build-output*.txt files
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9057 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-19 02:55:33 +00:00
Bart Van Assche
a7446766c5
isert-scst Makefile: Add the SCST Module.symvers file
...
This patch fixes a linker error when cross-compiling for ARM on x86_64.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9055 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-19 01:19:49 +00:00
Bart Van Assche
7569ddaf2e
Makefiles: Remove -Wextra
...
Since not all kernel header files are compatible with -Wextra, remove -Wextra.
To enable -Wextra, build SCST with W=1.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9054 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-19 01:18:24 +00:00
Bart Van Assche
cf909e3e16
Makefiles: If both KDIR and KVER have been set, preserve KDIR
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9052 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-19 00:00:49 +00:00
Bart Van Assche
47403656ee
Make 'make clean' remove all build files
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9038 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-05 02:08:55 +00:00
Bart Van Assche
212fd12cba
iscsi-scst, srpt: Improve run_conftest
...
Add -Wno-deprecated-declarations to the compiler flags for RHEL and CentOS.
Save the output of the build process such that it can be inspected easily.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9037 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-07-05 02:06:21 +00:00
Bart Van Assche
f7b704ee99
scst, iscsi-scst: Port to RHEL / CentOS 8.2
...
Apparently the Linux kernel v4.20 iov_iter_kvec() function has been
backported to RHEL / CentOS 8.2. This patch fixes the following kernel
warning:
WARNING: CPU: 26 PID: 21141 at lib/iov_iter.c:1083 iov_iter_kvec+0x25/0x30
Call Trace:
fileio_exec_async+0x216/0x3a0 [scst_vdisk]
fileio_exec_write+0x3b9/0x450 [scst_vdisk]
vdev_do_job+0x34/0xc0 [scst_vdisk]
scst_do_real_exec+0x54/0x100 [scst]
scst_exec_check_blocking+0xbb/0x210 [scst]
scst_process_active_cmd+0x64d/0x1550 [scst]
scst_cmd_thread+0x170/0x5a0 [scst]
kthread+0x112/0x130
ret_from_fork+0x35/0x40
See also https://github.com/bvanassche/scst/issues/26 .
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9026 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-06-17 01:35:53 +00:00
Bart Van Assche
c51cf132e1
iscsi-scst: Add network namespace support
...
This patch makes it possible to run the SCST iSCSI target software inside
a Docker container that uses another network namespace than the default.
See also https://github.com/bvanassche/scst/issues/24 .
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9002 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-06-06 16:27:41 +00:00
Bart Van Assche
c647d76ef2
Fix compiler warnings triggered by building against the musl C library
...
See also https://github.com/bvanassche/scst/issues/23 .
Reported-by: Lucian Cristian lucian.cristian@gmail.com
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9001 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-06-01 04:52:50 +00:00
Bart Van Assche
9be61ba538
Move KBUILD_EXTRA_SYMBOLS definitions into the kernel Makefiles
...
$(KBUILD_EXTRA_SYMBOLS) is not only used at compile time but also at link
time. Move the $(KBUILD_EXTRA_SYMBOLS) definitions such that it is
available both at compile time and at link time.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@9000 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-06-01 02:15:47 +00:00
Bart Van Assche
80ac4d2810
Use $(src) instead of $(KBUILD_EXTMOD)
...
While $(src) is always defined, $(KBUILD_EXTMOD) is only defined when
building code as an external module.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8999 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-06-01 02:12:09 +00:00
Bart Van Assche
f7fe23928f
Change $(MODULE_SYMVERS) into Module.symvers
...
Or in other words, drop support for kernel versions before 2.6.18.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8998 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-06-01 02:11:16 +00:00
Bart Van Assche
fda71c077d
Include <poll.h> instead of <sys/poll.h>
...
According to the Single Unix Specification, the poll() function has been
declared in the <poll.h> header file. This makes the SCST code compatible
with the musl C library. See also https://en.wikipedia.org/wiki/Musl . See
also https://github.com/bvanassche/scst/issues/23 .
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8992 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-31 03:41:17 +00:00
Bart Van Assche
75d059e9f0
iscsi-scstd: Fix a gcc 10 compiler warning
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8954 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-23 17:14:21 +00:00
Bart Van Assche
d12b0a0d91
Fix spelling in documentation and source code
...
See also https://github.com/bvanassche/scst/pull/20 .
[ bvanassche: left out qla2x00t-32gbit changes and changed patch description ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8920 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-15 18:53:48 +00:00
Bart Van Assche
bcdfc28dd8
iscsi-scst: Add a hint what to look for if no userspace process is connected
...
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru >
[ bvanassche: edited description and patch ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8907 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 20:48:12 +00:00
Bart Van Assche
08ba5d8f1a
iscsi-scst: Remove unnecessary %s format modifiers
...
See also https://github.com/bvanassche/scst/pull/18 .
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8903 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-12 14:57:00 +00:00
Bart Van Assche
3f97a8d3cb
iscsi-scst, srpt: Fix the build against MOFED 5
...
Reported-by: Grant Albitz <Cryptz@Cryptz.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8866 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-06 03:26:38 +00:00
Bart Van Assche
69d90841b6
iscsi-scstd: Fix a memory leak in conn_free()
...
Signed-off-by: Lev Vainblat <lev@zadarastorage.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8783 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-03-05 02:35:34 +00:00
Bart Van Assche
f0e474c4d8
iscsi-scst: Suppress multiple Coverity complaints
...
Suppress several Coverity "tainted scalar" complaints and also two other
false positive Coverity complaints.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8761 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-01-12 05:37:34 +00:00
Bart Van Assche
422d670126
srpt, isert-scst: Fix the build against MOFED
...
This patch is a fix for commit a169500590 ("Makefiles:
Use KBUILD_EXTRA_SYMBOLS instead of copying Module.symvers"; r8686).
Reported-by: Grant Albitz <GAlbitz@All-Bits.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8758 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-12-28 04:28:19 +00:00
Bart Van Assche
d85e33dbcc
iscsi-scst: Serialize socket disconnect calls properly
...
This patch fixes the following kernel complaint:
WARNING: suspicious RCU usage
include/net/sock.h:1907 suspicious rcu_dereference_protected() usage!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
no locks held by iscsi_conn_clea/18329.
stack backtrace:
Call Trace:
dump_stack+0xa5/0xe6
lockdep_rcu_suspicious+0x107/0x111
tcp_disconnect+0x9ee/0xa60
iscsi_tcp_conn_close+0x5d/0x90 [iscsi_scst]
close_conn+0xcfe/0x1470 [iscsi_scst]
close_conn_thr+0x54/0x80 [iscsi_scst]
kthread+0x1bc/0x210
ret_from_fork+0x24/0x30
Fixes: commit ba3062fe6b ("iscsi-scst: Improve connection shutdown time";
r297).
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8693 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-12-23 18:51:02 +00:00
Bart Van Assche
1379918d8a
iscsi-scst/Makefile: Avoid duplicate exported symbol warnings for kernel v5.5
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8687 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2019-12-17 04:24:55 +00:00