Commit Graph

272 Commits

Author SHA1 Message Date
Bart Van Assche
8e0e19c9de ib_srpt (sysfs): Converted login_info from a device attribute into a tgt attribute.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3003 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-12-10 09:47:29 +00:00
Bart Van Assche
17cb105213 Made sure that srpt_release() doesn't oops if srpt_add_one() fails after
having registered the target and before the srpt_post_recv() loop started.

Reported-by: Frank Zago <fzago@systemfabricworks.com>.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2963 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-12-07 16:59:19 +00:00
Bart Van Assche
1fe5da1dea ib_srpt: Source code formatting cleanup.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2951 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-12-07 09:25:23 +00:00
Bart Van Assche
7e158b0c68 Handle iWARP devices graciously - ib_srpt does not work with at least Intel
iWARP devices.

Reported-by: Frank Zago <fzago@systemfabricworks.com>.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2950 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-12-07 09:21:16 +00:00
Bart Van Assche
1d520654cb ib_srpt: Pass correct atomic context information to scst_rx_cmd().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2912 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-12-03 11:29:47 +00:00
Bart Van Assche
83a967d3a3 ib_srpt: Made sure that accessing sysfs entries during target creation is harmless.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2703 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-11-14 09:32:03 +00:00
Bart Van Assche
6297569bce ib_srpt: Builds again on RHEL 5 (enable_proc).
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2696 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-11-13 22:29:12 +00:00
Bart Van Assche
f14f14a31e ib_srpt: Converted req_lim and req_lim_delta from device-specific attributes into session-specific attributes, which makes a lot more sense.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2692 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-11-13 17:28:18 +00:00
Bart Van Assche
7025e1a732 Should have been included in r2686.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2688 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-11-13 14:58:11 +00:00
Bart Van Assche
79a4dcc4e5 ib_srpt: Made sure that no credits are lost because of SCSI task abortion.
ib_srpt: Exported req_lim and req_lim_delta values via sysfs because this is convenient for debugging purposes.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2686 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-11-13 14:38:44 +00:00
Bart Van Assche
8b248b67c1 ib_srpt: Added a comment.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2459 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-24 18:32:14 +00:00
Bart Van Assche
d07bd65ba1 ib_srpt: Moved a source code comment.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2458 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-24 11:58:34 +00:00
Bart Van Assche
b9c17588fa ib_srpt: Changed queue full message severity level from ERROR to WARNING since this condition is not fatal.
ib_srpt: Micro-optimization: pass the number of bytes that will be sent to ib_dma_sync_single_for_device() instead of the size of the entire DMA buffer.
ib_srpt: Fixed two bugs in the code for tracking the number of elements available in the IB send queue and that could be triggered by a send queue overflow.

git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2456 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-24 09:30:40 +00:00
Bart Van Assche
172c211176 ib_srpt: Fixed bug in IB send queue overflow handling.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2455 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-23 14:32:15 +00:00
Bart Van Assche
8be8b4e66d svn merge -r2380:2441 https://scst.svn.sourceforge.net/svnroot/scst/branches/srpt-separate-rx-tx-buffers .
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2442 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-21 19:21:10 +00:00
Bart Van Assche
bb540fa9f8 ib_srpt: Removed an unused variable.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2379 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-09 07:25:55 +00:00
Bart Van Assche
ac5a366941 ib_srpt: Further improved robustness against HCA firmware bugs.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2375 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-08 19:02:35 +00:00
Bart Van Assche
92b70d4f83 ib_srpt: Report firmware bugs instead of silently ignoring these.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2346 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-04 16:57:03 +00:00
Bart Van Assche
c42c4159ed Fixed a checkpatch complaint.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2343 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-03 07:26:03 +00:00
Bart Van Assche
c130e11f44 ib_srpt: race-at-session-unregistration-fix (partially reverted r2339).
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2342 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-02 17:45:57 +00:00
Bart Van Assche
c935c8e28d ib_srpt: Increased ib_wc array size back from 4 to 16.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2341 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-02 16:05:54 +00:00
Bart Van Assche
d45f587bdc Fixed a race between session unregistration and queueing new commands.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2339 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-02 15:54:39 +00:00
Bart Van Assche
1df8d51091 Source code comment update.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2337 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-02 15:09:12 +00:00
Bart Van Assche
cc48d8ac94 Reduced stack usage of srpt_process_completion.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2336 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-02 15:08:45 +00:00
Bart Van Assche
5c955fad01 Changes:
- Removed a superfluous state transition in srpt_abort_scst_cmd() and
  cleaned up the source code of this function a bit.
- Implemented a workaround for the InfiniBand kernel stack bug that could
  result in IB_WC_RECV error completions to be delivered with an incorrect
  wr_id.
- RDMA read error completions and SRP_CRED_REQ send error completions are now
  processed correctly.
- If posting an SRP_RSP fails, don't set the delivery status because sending
  the response will be retried anyway.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2335 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-02 15:08:18 +00:00
Bart Van Assche
91f966ec33 Minor source code comment edit.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2332 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-10-02 12:52:57 +00:00
Bart Van Assche
ba111e1804 Converted the two remaining scst_cmd_get_resp_data_len() calls.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2310 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-29 19:04:31 +00:00
Bart Van Assche
6213d95400 ib_srpt: fix SCSI residual handling.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2306 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-29 17:47:14 +00:00
Bart Van Assche
986844622a Fixed a performance regression caused by r2109.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2248 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-24 19:07:17 +00:00
Bart Van Assche
4a9ed0a7e1 Replaced cpu_to_be...() by __constant_cpu_to_be...() where appropriate.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2230 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-24 07:10:42 +00:00
Bart Van Assche
9f20d45776 Version number update.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2140 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-17 06:02:51 +00:00
Bart Van Assche
f5736f2b6a ib_srpt performance optimization.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2109 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-12 18:57:04 +00:00
Bart Van Assche
72fb7b3644 Shortened a kernel module parameter description.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2106 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-12 10:03:06 +00:00
Bart Van Assche
9878d2533f Reverted r2099.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2102 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-12 07:31:33 +00:00
Bart Van Assche
1c90d919d5 Removed unused code.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2099 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-11 18:20:59 +00:00
Bart Van Assche
6aa2ebca55 Send back the proper error code when an SRP task management command fails.
Replaced a numeric constant by a symbolic one.
Renamed a function.
Updated several comments.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2097 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-11 17:51:40 +00:00
Bart Van Assche
a40fdacb5f Pre-2.6.31 kernel compiler warning fix.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2092 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-11 08:21:35 +00:00
Bart Van Assche
ec2712759f Un-break nightly build.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2072 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-09 13:57:30 +00:00
Bart Van Assche
5edde5ec25 Eliminated the include/scst include path from the upstream ib_srpt Makefile.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2071 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-09 09:46:18 +00:00
Bart Van Assche
a86577a276 Only include the procfs header files when necessary.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2070 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-09 09:23:36 +00:00
Bart Van Assche
d84ec4d8ce Removed a superfluous include path.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2069 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-09 09:18:00 +00:00
Vladislav Bolkhovitin
c66ae1850e - get_transport_version() function changed to get target on entry
- transport versions propageted to user space handlers



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2061 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-06 21:45:48 +00:00
Vladislav Bolkhovitin
961d59ff40 - Version descriptors added
- Multi-transport support added to scst_local
 - Sysfs attributes "version" and "trace_level" added to scst_local



git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2060 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-09-06 21:21:49 +00:00
Bart Van Assche
edac418f66 SRP_CRED_REQ autodetection is now disabled by default.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2026 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-08-31 06:30:59 +00:00
Bart Van Assche
725e090a94 Print an informational message instead of an error message for MRA (Message
Receipt Acknowledgement) messages.


git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2016 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-08-28 07:12:26 +00:00
Bart Van Assche
6c3b1e55be Corrected an error message.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1965 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-08-21 08:27:28 +00:00
Bart Van Assche
894190c09e Removed superfluous __attribute__((packed)).
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1952 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-08-15 10:02:10 +00:00
Bart Van Assche
ed195d5e4f Added more comments.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1939 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-08-06 17:28:04 +00:00
Bart Van Assche
23a55be361 Fixed a compiler warning that was only reported on RHEL 5.x.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1905 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-08-02 17:01:06 +00:00
Bart Van Assche
e30376945f Changes:
- Made sure that in mode thread=1 not only send completions but also receive completions are processed in thread context.
- Merged IB send and receive completion queues again such that both types of completions are processed in a fairly.

git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1904 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2010-08-02 16:50:14 +00:00