SCST_VERSION_STRING will be incorrect because it gets defined before
CONFIG_SCST_PROC is defined. (merge r3489 and r3490 from trunk)
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.2.0.x@3993 d57e44dd-8a1f-0410-8b47-8ef2f437770f
https://vlnb@scst.svn.sourceforge.net/svnroot/scst/trunk
........
r3799 | vlnb | 2011-08-04 22:07:35 -0400 (Thu, 04 Aug 2011) | 37 lines
Modified patch from Bart Van Assche <bvanassche@acm.org>:
The range unmapped by the scst_vdisk handler when processing an UNMAP command
is not correct. The patch below fixes that and also prevents that the following
kernel crash can be triggered on the target:
Call Trace:
[<ffffffffa06b5350>] ? srpt_post_send+0xd0/0x140 [ib_srpt]
[<ffffffff811bb595>] ? cpumask_next_and+0x35/0x50
[<ffffffff810e6296>] shmem_truncate_range+0x7a6/0xa50
[<ffffffffa0612ceb>] ? scst_get_buf_full+0x16b/0x270 [scst]
[<ffffffffa069beb6>] vdisk_exec_unmap+0x1d6/0x4b0 [scst_vdisk]
[<ffffffff813c0cb6>] ? _raw_spin_unlock+0x16/0x40
[<ffffffffa069dadc>] vdisk_do_job+0x5fc/0x950 [scst_vdisk]
[<ffffffffa0605402>] scst_do_real_exec+0xb2/0x400 [scst]
[<ffffffffa06076a7>] scst_exec+0xd7/0x240 [scst]
[<ffffffffa06079b6>] scst_send_for_exec+0x1a6/0x2f0 [scst]
[<ffffffffa06086f8>] scst_process_active_cmd+0x4f8/0x790 [scst]
[<ffffffffa0608a29>] scst_do_job_active+0x99/0x170 [scst]
[<ffffffffa060a3da>] scst_cmd_thread+0x15a/0x3b0 [scst]
[<ffffffff81047470>] ? default_wake_function+0x0/0x20
[<ffffffffa060a280>] ? scst_cmd_thread+0x0/0x3b0 [scst]
[<ffffffff8106dc26>] kthread+0x96/0xa0
[<ffffffff81003cd4>] kernel_thread_helper+0x4/0x10
[<ffffffff8103db01>] ? finish_task_switch+0x51/0xb0
[<ffffffff813c0c7c>] ? _raw_spin_unlock_irq+0x1c/0x40
[<ffffffff813c18b1>] ? restore_args+0x0/0x30
[<ffffffff8106db90>] ? kthread+0x0/0xa0
[<ffffffff81003cd0>] ? kernel_thread_helper+0x0/0x10
Invoking truncate_range() with an end len that is not page-size aligned
triggers it. In other words, with a block size that is below
PAGE_CACHE_SIZE some UNMAP commands could trigger a kernel bug. I think
it's better to print an error message and to skip an UNMAP command
instead of triggering a kernel oops.
........
r3800 | vlnb | 2011-08-08 21:04:57 -0400 (Mon, 08 Aug 2011) | 3 lines
Update of SCST_Gentoo_HOWTO.txt to SCST 2.x. Thanks to Willem Boterenbrood <w.boterenbrood@gmail.com>!
........
r3818 | vlnb | 2011-08-17 20:17:06 -0400 (Wed, 17 Aug 2011) | 3 lines
Fix for forgotten devt initialization in preparing internal commands
........
r3819 | vlnb | 2011-08-17 20:27:12 -0400 (Wed, 17 Aug 2011) | 6 lines
Disable accepting initiator mode commands if initiator mode not enabled
for 23xx- chips as well as suggested by ido benda <idombd@gmail.com>.
This is extension of r3261 to qla2x00_queuecommand().
........
r3823 | vlnb | 2011-08-19 19:20:22 -0400 (Fri, 19 Aug 2011) | 3 lines
Update of SCST_Gentoo_HOWTO.txt from Willem Boterenbrood <w.boterenbrood@gmail.com>
........
r3824 | vlnb | 2011-08-19 19:55:31 -0400 (Fri, 19 Aug 2011) | 3 lines
Fix for one more forgotten initialization in preparing internal commands spotted by kordex@gmail.com
........
r3825 | bvassche | 2011-08-20 10:04:52 -0400 (Sat, 20 Aug 2011) | 1 line
documentation, spelling: Change phisical into physical
........
r3828 | bvassche | 2011-08-22 15:19:56 -0400 (Mon, 22 Aug 2011) | 11 lines
scst: Avoid triggering BUG() on uniprocessor systems
On uniprocessor systems with lock debugging disabled spin_is_locked()
returns false. Disable the spin_is_locked() checks if CONFIG_SMP has not
been defined.
Reported-by: Frank <frank@debian-nas.org>
Signed-off-by: Dave Carroll <dcarroll@astekcorp.com>
Cc: scst-devel <scst-devel@lists.sourceforge.net>
Cc: Frank <frank@debian-nas.org>
........
r3831 | vlnb | 2011-08-25 14:08:45 -0400 (Thu, 25 Aug 2011) | 3 lines
Fix possible crash on rel_tgt_id set on transports without is_target_enabled() defined.
........
r3833 | vlnb | 2011-09-01 14:22:27 -0400 (Thu, 01 Sep 2011) | 5 lines
- Fix possible deadlock between vdev_sysfs_process_get_filename() and vdisk_del_device()
- Cleanups
........
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.1.0.x@3836 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- Let's always do extraclean on Makefiles modifications, because they can affect data layout in header files, which could not be detected by all target drivers/dev handlers makes
- Cleanups
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/2.1.0.x@3505 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- Docs updated
- Returning of DIRECT contexts by scst_estimate_context() disabled (see comment in the patch why)
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@3203 d57e44dd-8a1f-0410-8b47-8ef2f437770f
theory it is possible that scst_tgt_get_tgt_priv() is invoked before
scst_register_target() returns. The patch below implements such a check and
also removes some superfluous casts.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2691 d57e44dd-8a1f-0410-8b47-8ef2f437770f
versions of the kernel. Also, use correct specifiers in some places, ie %zd
where a negative number could be printed.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2149 d57e44dd-8a1f-0410-8b47-8ef2f437770f
style fix conforms to the kernel coding standard and uses if (!xxx) rather
than if (NULL == xxx).
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2138 d57e44dd-8a1f-0410-8b47-8ef2f437770f
seems to have removed the setting of hpnt->max_id, so it seems the default is
7. Set it to 0 because we only want one ID on the device, and we don't do
any checking ...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2110 d57e44dd-8a1f-0410-8b47-8ef2f437770f
Also, this approach changes the default behavior for people who are using
CONFIG_SCST_PROC because the default was that a single host/tgt was added,
but now they have to change their /etc/modules.d/scst.conf or whatever to
add add_default_tgt=1.
I am not sure that is a good thing.
With the last few commits and this one, I have tested on 2.6.34.1 and 2.6.28
and things seem to work. I am now looking at the problem Vlad reported with
CONFIG_SCST_PROC where local devices show up under SCSI bus or device from 0
to 7.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2108 d57e44dd-8a1f-0410-8b47-8ef2f437770f
oops when we try to unload scst_local. This is because we were unregistering
the driver if we did not add a default target, but we try to do that again
when we try to unload the driver.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2101 d57e44dd-8a1f-0410-8b47-8ef2f437770f
root device rather than using a statically allocated structure in the driver.
Tested with 2.6.24 ... now testing with an earlier version.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@2100 d57e44dd-8a1f-0410-8b47-8ef2f437770f
