Bart Van Assche
8276dc53d3
scstadmin: Make scstadmin again compatible with older Perl interpreters
...
Fix the following Perl v5.10.1 warnings:
Ambiguous use of -ENOENT resolved as -&ENOENT() at /usr/local/share/perl5/SCST/SCST.pm line ...
According to https://stackoverflow.com/questions/23215511/ambiguous-use-of-constant-resolved-as-constant
that message indicates a bug in the Perl interpreter.
Reported-by: Gilbert Standen <gilstanden@hotmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8928 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-17 16:43:13 +00:00
Bart Van Assche
f2a86dbfb8
Merge branch 'svn-trunk'
2020-05-16 09:02:38 -07:00
Bart Van Assche
4525b04b23
scst: Reject inconsistent COMPARE AND WRITE commands
...
Reject COMPARE AND WRITE commands if the size of the data buffer does not
match the number of logical blocks specified in the CDB. This patch makes
two more libiscsi conformance tests pass.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8927 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-16 16:02:32 +00:00
Bart Van Assche
d5e13d6453
scst: Introduce a new local variable in scst_cmp_wr_local()
...
This patch does not change any functionality.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8926 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-16 16:01:00 +00:00
Bart Van Assche
981501a9fa
scst.h: Remove an obsolete comment
...
This is a follow-up for commit 57d9df0717 ("scst: Remove an empty
function") / r8908.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8925 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-16 15:59:30 +00:00
Bart Van Assche
d9a684a9c3
scst.h: Add a comment above sg_next_inline()
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8924 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-16 15:57:45 +00:00
Bart Van Assche
c84dbccf5c
scst: Complain loudly if scst_adjust_sg_get_tail() fails
...
Apparently certain libiscsi COMPARE AND WRITE tests cause
scst_adjust_sg_get_tail() to fail. Complain if that happens even if
"EXTRACHECKS" are disabled.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8923 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-16 15:57:21 +00:00
Bart Van Assche
b07dea49d4
scripts/run-regression-tests: Do not create a -.o file
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8922 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-16 15:55:46 +00:00
Bart Van Assche
d53deb3372
Merge branch 'svn-trunk'
2020-05-16 08:54:53 -07:00
Bart Van Assche
0736635b62
scripts/list-source-files: exclude build artifacts when not in vcs tree
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8921 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-16 15:54:19 +00:00
Ville Skyttä and Bart Van Assche
e9202cb257
scripts/list-source-files: exclude build artifacts when not in vcs tree
2020-05-16 08:53:59 -07:00
Bart Van Assche
5243ff47dd
Merge branch 'svn-trunk'
2020-05-15 11:53:56 -07:00
Bart Van Assche
d12b0a0d91
Fix spelling in documentation and source code
...
See also https://github.com/bvanassche/scst/pull/20 .
[ bvanassche: left out qla2x00t-32gbit changes and changed patch description ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8920 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-15 18:53:48 +00:00
Bart Van Assche
b440f2b84f
scripts/list-source-files: Use /bin/sh as interpreter instead of bash
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8919 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-15 18:53:18 +00:00
Ville Skyttä and Bart Van Assche
c9ea63d0f2
Fix spelling in documentation and source code
...
See also https://github.com/bvanassche/scst/pull/20 .
[ bvanassche: left out qla2x00t-32gbit changes and changed patch description ]
2020-05-15 11:50:01 -07:00
Bart Van Assche
f31c03a0cc
scripts/list-source-files: Use /bin/sh as interpreter instead of bash
2020-05-15 11:49:06 -07:00
Bart Van Assche
77c786af7d
Merge branch 'svn-trunk'
2020-05-14 13:48:27 -07:00
Bart Van Assche
8de9eb487a
scstadmin: Fix -resync_dev
...
Fix the following failure:
# scstadmin -resync_dev volume01
Collecting current configuration: done.
-> Making requested changes.
-> WARNING: Device 'volume01' lacks the settable attribute 'resync_size', ignoring.
-> Done.
All done.
This patch fixes a regression that was introduced by r8171 (commit
aedcfc5997 ("scstadmin: Avoid that Perl complains about undefined values
for write-only attributes") # v3.4.
Reported-by: Marc Smith <msmith626@gmail.com >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8915 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 20:45:26 +00:00
Bart Van Assche
3b9d078113
Merge branch 'svn-trunk'
2020-05-14 09:40:28 -07:00
Bart Van Assche
d045ff5e26
srpt: Make zero-copy mode compatible with the scst_user device handler
...
The scst_user device handler allocates its own data buffers. If ib_srpt
uses zero-copy mode, copy data as required between the device handler and
zero-copy buffer.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8914 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:40:05 +00:00
Bart Van Assche
198cb64c8d
scstadmin: Make test 06 more robust
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8913 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:37:18 +00:00
Bart Van Assche
29548a4ad7
scst: Remove the on_alua_state_change_*() callback functions
...
Remove these callback functions because:
- Since the introduction of the 'active' attribute, these callback functions
are no longer essential. See also commit 9d21169f8c ("scst: implement
BLOCKIO devices "active" attribute").
- The current implementation may break I/O. The following ALUA configuration
is sufficient to break I/O (because a remote group with state 'standby'
occurs last):
DEVICE_GROUP dgroup1 {
DEVICE disk01
TARGET_GROUP tgroup1 {
group_id 256
preferred 1
state active
TARGET scst_local_tgt
}
TARGET_GROUP tgroup2 {
group_id 257
state standby
TARGET scst_local_tgt_remote {
rel_tgt_id 7
}
}
}
See also commit 2b202209ca ("ALUA DRBD compatibility").
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8912 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:36:30 +00:00
Bart Van Assche
80d2dac38e
vdisk_blockio: Remove support for unaligned buffers
...
Submitting an unaligned buffer is a bug. Additionally, the patch that added
support for unaligned buffers negatively affected performance of the ib_srpt
and scst_local drivers.
This patch reverts 85f8ac3a1e ("vdisk_blockio: Add support for unaligned
buffers").
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8911 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:27:32 +00:00
Bart Van Assche
7d63eaf0ce
scstadmin: If modifying an SCST attribute fails, report why it fails
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8910 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-14 16:23:57 +00:00
Bart Van Assche
c6da74b1a7
Merge branch 'svn-trunk'
2020-05-13 14:27:20 -07:00
Bart Van Assche
041ef55247
scripts/kernel-functions: Fix the RHEL 6.x build
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8909 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 21:27:11 +00:00
Bart Van Assche
12a94137ca
Merge branch 'svn-trunk'
2020-05-13 13:52:37 -07:00
Bart Van Assche
57d9df0717
scst: Remove an empty function
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8908 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 20:52:23 +00:00
Bart Van Assche
b1687999ba
Merge branch 'svn-trunk'
2020-05-13 13:48:41 -07:00
Bart Van Assche
bcdfc28dd8
iscsi-scst: Add a hint what to look for if no userspace process is connected
...
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru >
[ bvanassche: edited description and patch ]
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8907 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 20:48:12 +00:00
Bart Van Assche
c91c6d5e1f
Merge branch 'svn-trunk'
2020-05-13 13:46:56 -07:00
Konstantin Kharlamov and Bart Van Assche
054c738f63
iscsi-scst: Add a hint what to look for if no userspace process is connected
...
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru >
[ bvanassche: edited description and patch ]
2020-05-13 13:46:41 -07:00
Konstantin Kharlamov and Bart Van Assche
af1dfc9873
iscsi-scst: Remove unnecessary %s format modifiers
...
See also https://github.com/bvanassche/scst/pull/18 .
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8903 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 13:46:20 -07:00
Bart Van Assche
115ec5be90
scripts/kernel-functions: Only apply RHEL patches on RHEL kernels
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8906 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 20:37:30 +00:00
Bart Van Assche
858f50e4d3
scstadmin: Improve robustness
...
Instead of only interpreting the empty string as "no argument passed", also
consider 'undef' as "no argument passed".
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8905 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 17:24:35 +00:00
Bart Van Assche
ee0328f6f7
scst: Drop support for scst_register_target(..., NULL)
...
Support for autogenerated target names was declared obsolete in 2011. Remove
support for autogenerated target names. See also commit 21d503cbb7
("Autogenerated SCST target names made deprecated").
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8904 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-13 17:23:14 +00:00
Bart Van Assche
08ba5d8f1a
iscsi-scst: Remove unnecessary %s format modifiers
...
See also https://github.com/bvanassche/scst/pull/18 .
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru >
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8903 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-12 14:57:00 +00:00
Bart Van Assche
90f5d5f5bf
Merge branch 'svn-trunk'
2020-05-11 18:04:49 -07:00
Bart Van Assche
95893200f2
scst_user: Fix a recently introduced coding style issue
...
See also commit b2facc91c9 ("scst/src/dev_handlers/scst_user: Simplify dev_user_reply_get_multi()").
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8902 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-12 01:04:32 +00:00
Bart Van Assche
e9f065b375
Merge branch 'svn-trunk'
2020-05-11 13:38:33 -07:00
Bart Van Assche
58a1ea5bd7
scripts/generate-kernel-patch: Use read instead of readarray and fix shellcheck warnings
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8901 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-11 20:38:25 +00:00
Bart Van Assche
056f426165
scripts/kernel-functions: Make this script compatible with bash versions that do not support readarray
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8900 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-11 20:37:43 +00:00
Bart Van Assche
9429a9930f
scripts/rhel-rpm-functions: Use ${...//...} instead of setting the IFS variable
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8899 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-11 20:36:04 +00:00
Bart Van Assche
bec6dfbec1
Merge branch 'svn-trunk'
2020-05-10 13:47:42 -07:00
Bart Van Assche
04b4ee34fe
scripts/run-regression-tests: Fix the CentOS 6.x build
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8894 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 20:47:33 +00:00
Bart Van Assche
41cad5fdcc
Merge branch 'svn-trunk'
2020-05-10 12:00:52 -07:00
Bart Van Assche
f40d96c8a0
scripts/run-regression-tests: Make the CentOS build less noisy
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8893 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 19:00:39 +00:00
Bart Van Assche
ab4f2f5077
scripts/generate-kernel-patch: Use the generic drivers Makefile for CentOS 6.x
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8892 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:59:38 +00:00
Bart Van Assche
3d066f3ea1
Merge branch 'svn-trunk'
2020-05-10 11:58:14 -07:00
Bart Van Assche
30488c97b9
nightly/conf/nightly.conf: Add CentOS kernel versions
...
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@8891 d57e44dd-8a1f-0410-8b47-8ef2f437770f
2020-05-10 18:39:34 +00:00