- Changed default value of srp_max_message_size from 4096 to 2116. This
size corresponds to the size of an SRP_CMD request message containing
an indirect buffer list with 128 elements.
- A warning is now printed when an SRP_CMD request is received containing
more than one CDB -- this kind of messages is not yet supported.
- Switched back from multiple ib_dma_sync_single_for_cpu() calls to a
single call because the latter results in better performance.
- An error message is now printed if a corrupt SRP_CMD request has been
received. Before these were ignored silently.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1377 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- Removed a spinlock that became superfluous.
- Fixed checkpatch and sparse complaints.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1370 d57e44dd-8a1f-0410-8b47-8ef2f437770f
srpt_release_channel_by_cmid().
- Removed tracing statements from srpt_unmap_sg_to_ib_sge() because this
function is now invoked while performing I/O.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1369 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- Fixed system lockup triggered by "rmmod ib_srpt" while the SRP was writing
data. This lockup occurred because srpt_reset_ioctx() was not resetting
the pointers to the memory it freed, which indirectly triggered a kernel
oops in the IB interrupt handler.
- Fixed BUG() during "rmmod ib_srpt" triggered by calling scst_rx_cmd()
after scst_unregister_session(). This has been fixed by making sure that
the channel state is set to RDMA_CHANNEL_DISCONNECTING before calling
scst_unregister_session().
Performance improvements:
- Simplified cmd_wait_list manipulation code.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1368 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- Fixed races on srpt_ioctx::state manipulation by declaring this variable
atomic.
- Fixed races on srpt_rdma_ch::state manipulation by declaring this variable
atomic.
- Fixed bug in srpt_abort_scst_cmd(): SRPT_STATE_DATA_IN was not yet handled.
- Fixed races on srpt_rdma_ch::cm_id destruction. Clearly documented which
object owns the cm_id at which time.
Performance improvements:
- Eliminated the list of active commands (active_scmnd_list) because this
list was a duplicated of a list already kept by the SCST core.
- Switched to double-checked locking in srpt_handle_new_iu(). This saves one
spin_lock_irqsave() and one spin_unlock_irqrestore() call in the common
case (that is, a live channel).
- Eliminated RDMA channel state tests in SCST command handling callback
functions -- removed the function srpt_abort_if_disconnecting().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1367 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- The message that sense data is truncated is now generated via the
PRINT_WARNING() macro instead of TRACE_DBG().
- Cleaned up code for sense data truncation.
- Compiles again on RHEL and CentOS systems.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1363 d57e44dd-8a1f-0410-8b47-8ef2f437770f
the per-channel queue pair. This counter is used to prevent that
ib_post_send() triggers a queue overflow.
- Fixed error handling in srpt_xfer_data(): srpt_unmap_sg_to_ib_sge() is now
called before returning an error code.
- Simplified implementation of the sysfs attribute login_info.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1353 d57e44dd-8a1f-0410-8b47-8ef2f437770f
sense, replaced this expression by "sizeof(*sense)" and a BUILD_BUG_ON()
statement that verifies that sizeof(*sense) is a multiple of four. Should
the first expression have been "roundup(sizeof(*sense), 4)" ?
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1336 d57e44dd-8a1f-0410-8b47-8ef2f437770f
ib_dma_sync_for_cpu() calls do now only synchronize the data areas used.
- Removed per-command mutex again because it's not a full solution with
regard to avoiding races between module unloading / IB error handling and
SCST's command handling.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1335 d57e44dd-8a1f-0410-8b47-8ef2f437770f
code.
- Fixed the bug that new commands could be queued for a channel that was
being closed.
- Bug fix: ib_dma_unmap_sg() is now called by srpt_xmit_response() when
aborting commands.
- Changed default value of the kernel module parameter 'thread' from zero
to one because using thread=0 can cause the Linux and the OFED SRP
initiator to lock up -- see also
http://bugzilla.kernel.org/show_bug.cgi?id=14235 and
https://bugs.openfabrics.org/show_bug.cgi?id=1745.
- Made disconnect logging more detailed -- added cm_id in output.
- Changed argument type of second argument of srpt_release_channel() from
int to bool.
- Eliminated srpt_abort_scst_cmd's 'tell_initiator' argument because this
argument always has the same value (i.e. true).
- Simplified abortion of commands in state SRPT_STATE_NEW. Simplified
implementation of srpt_on_free_cmd().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1332 d57e44dd-8a1f-0410-8b47-8ef2f437770f
As a result, the maximum number of sg list elements that an initiator
can pass in one message increased from 58 to 251.
- Added kernel module parameter srp_max_message_size, which allows to
specify the maximum size of SRP control messages.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1328 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- Introduced new kernel module parameter srp_max_rdma_size. This parameter
allows to configure the maximum size of SRP RDMA transfers.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1312 d57e44dd-8a1f-0410-8b47-8ef2f437770f
- Inserted tests such that ib_dma_unmap_sg() is never called with a NULL
second argument.
- Fixed race conditions triggered by ioctx->state manipulations.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1307 d57e44dd-8a1f-0410-8b47-8ef2f437770f
SRPT_STATE_NEW are now aborted properly too. Until now aborting an
SCST command that had state SRPT_STATE_NEW triggered a sBUG_ON()
statement in scst_tgt_cmd_done().
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1153 d57e44dd-8a1f-0410-8b47-8ef2f437770f
allows to control by how much the srpt_completion() function (which runs
in interrupt context) will be delayed.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1128 d57e44dd-8a1f-0410-8b47-8ef2f437770f
a command that has already been aborted, changed the message that
reports this from an error message to an informational message.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1123 d57e44dd-8a1f-0410-8b47-8ef2f437770f
replaced dma_*map* calls by ib_dma_*map* calls. Added the conversion
of dma_sync_single_for_device() to ib_dma_sync_single_for_device().
This only changes the behavior of SRPT for those IB interfaces whose
driver implements the ib_dma_mapping_ops operations.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1118 d57e44dd-8a1f-0410-8b47-8ef2f437770f
The OFED commit made a.o. ib_srpt.c compile on 2.6.30 and later kernels.
Although the SCST ib_srpt.c code already compiles on a 2.6.30 kernel, this
commit has been ported to SCST because the source code of the OFED
implementation is cleaner. This commit does not change any functionality
of SCST's SRPT.
git-svn-id: http://svn.code.sf.net/p/scst/svn/trunk@1117 d57e44dd-8a1f-0410-8b47-8ef2f437770f
