Commit Graph

  • 08161076f8 - New main Makefile target fcst added - Preliminary fixes to compile on 2.6.33 Vladislav Bolkhovitin 2010-02-20 20:08:10 +00:00
  • 6023f1ad34 This patch adds a new target module for SCST and libfc that accepts FCP requests from libfc HBAs running Fibre Channel over Ethernet (FCoE) and passes them to SCST. Vladislav Bolkhovitin 2010-02-20 20:02:02 +00:00
  • 21140e2a07 Fixed incorrect condition in scst_hw_pending_work_fn() noticed by Joe Eykholt <jeykholt@cisco.com> Vladislav Bolkhovitin 2010-02-19 18:45:53 +00:00
  • 2d4d49f304 Fixed two WARN_ON() statements. Bart Van Assche 2010-02-19 12:03:48 +00:00
  • 4d96089e50 Sysfs interface for targets made uniform. ISCSI-SCST made confirming the uniformity requirements. See README for details. Vladislav Bolkhovitin 2010-02-17 19:07:54 +00:00
  • 9b82ea19be Works now when started with a relative path too. Bart Van Assche 2010-02-15 19:09:48 +00:00
  • 9c8f290140 Added to repository. Bart Van Assche 2010-02-15 17:34:22 +00:00
  • c519012fb2 Factored out channel unregistration code into a new function srpt_unregister_channel(). Bart Van Assche 2010-02-14 12:51:14 +00:00
  • 4f7e597345 Fixed a memory leak in an error path. Bart Van Assche 2010-02-14 12:11:54 +00:00
  • 40869e57d1 Moved srpt_unmap_sg_to_ib_sge(ch, ioctx) call back into srpt_abort_scst_cmd(). Bart Van Assche 2010-02-14 12:08:47 +00:00
  • add3508a0c Changes: - Fixed race condition between SCST session registration and IB channel event handler in srpt_add_one(): at least in theory it was possible that sdev->scst_tgt was accessed before being initialized properly. - A kernel WARN_ON() is no longer triggered when a DREQ has been received after SCST session deregistration started. - Made sure that srpt_unmap_sg_to_ib_sge() does not call ib_dma_unmap_sg() twice. - Moved srpt_unmap_sg_to_ib_sge() call out of srpt_reset_ioctx() and srpt_abort_scst_cmd() into the callers of these functions. - Renamed some of the SRPT command states. Bart Van Assche 2010-02-14 11:36:34 +00:00
  • cedf31579e Removed handling of AESOLNT, CRSOLNT and LOSOLNT flags again. Bart Van Assche 2010-02-12 19:42:00 +00:00
  • 26866a1e28 Simplified implementation of the thread=1 mode. Bart Van Assche 2010-02-12 19:37:43 +00:00
  • 8981044fb8 Updated test instructions. Bart Van Assche 2010-02-12 19:30:08 +00:00
  • 7eee1392b8 Compiles again without warnings. Bart Van Assche 2010-02-12 18:59:15 +00:00
  • 82e07ddb73 Commented out required by iSCSI RFC, but not needed for processing, check of LUN field in Data-Out PDU, because some initiators (Windows, at least) don't care to correctly set it. Vladislav Bolkhovitin 2010-02-12 13:12:58 +00:00
  • 8a4b3a1732 Those files were deleted moving to new pass-through implementation, but should have been resurrected when that implementation was limited to 2.6.30+ kernels only. Fixing. Vladislav Bolkhovitin 2010-02-12 13:07:23 +00:00
  • 492e570df0 Made ib_srpt easier to build on a multiboot system where multiple kernels have been installed -- one kernel with OFED and one or more kernels without OFED. Bart Van Assche 2010-02-11 19:28:58 +00:00
  • 7c04f47a6b Fixed two MODULE_PARM_DESC() clauses. Bart Van Assche 2010-02-11 19:27:49 +00:00
  • b611a22ed0 Patch from Christian Motschke <motschke@itso-berlin.de>: Vladislav Bolkhovitin 2010-02-10 19:32:31 +00:00
  • d880bdab9d cmnd_reject() should return supplied reason, not hardcoded ISCSI_REASON_INVALID_PDU_FIELD Vladislav Bolkhovitin 2010-02-10 19:22:39 +00:00
  • 8ed82e1dbe Updated kernel revisions. Bart Van Assche 2010-02-09 15:46:10 +00:00
  • 2032370cca svn merge -c1492 https://scst.svn.sourceforge.net/svnroot/scst/branches/srpt-separate-rx-tx-buffers/scripts Bart Van Assche 2010-02-07 09:06:03 +00:00
  • f42a81e94a Web updates Vladislav Bolkhovitin 2010-02-02 17:16:58 +00:00
  • 0b3861da48 Added a blank line. Bart Van Assche 2010-01-29 19:09:06 +00:00
  • 773ec6e974 Updated kernel revisions. Bart Van Assche 2010-01-29 11:54:38 +00:00
  • 28ed0ed7e3 session_active_commands_attr attribute must have active_commands name. Vladislav Bolkhovitin 2010-01-26 13:02:13 +00:00
  • f7f8c13456 Updated kernel revisions. Bart Van Assche 2010-01-26 11:52:01 +00:00
  • 4c3a1c3e9e Updated kernel revisions. Bart Van Assche 2010-01-23 08:54:06 +00:00
  • fa91abb965 Updated kernel revisions. Bart Van Assche 2010-01-19 11:37:41 +00:00
  • 30fef168be Moved comma's in table header to the proper place. Bart Van Assche 2010-01-17 17:36:50 +00:00
  • 421dbafa7c Changes: - The entire receive queue can be used again instead of only SRPT_RQ_SIZE - 1 elements (as in r1470). - Added initiator-lockup-avoidance code to SRP_TSK_MGMT processing code too. Bart Van Assche 2010-01-17 13:07:46 +00:00
  • 5ce3870372 Updated test instructions. Bart Van Assche 2010-01-16 19:38:08 +00:00
  • e3d9724359 Updated copyright statement. Bart Van Assche 2010-01-16 19:36:29 +00:00
  • c654261e03 Changes: - Updated copyright statement. - Micro-optimized the function srpt_req_lim_delta(). - Made sure that SRPT does not cause a lockup in (at least) the Linux SRP initiator. See also http://bugzilla.kernel.org/show_bug.cgi?id=14235. Bart Van Assche 2010-01-14 20:35:37 +00:00
  • 3d9011443c Removed a trailing space because checkpatch complained about it. Bart Van Assche 2010-01-14 13:37:56 +00:00
  • 6384c37e83 Enabled sparse checking for the 2.6.23.17 kernel. Bart Van Assche 2010-01-14 13:28:26 +00:00
  • cedb20d8d4 Merge of trunk r1466: Vladislav Bolkhovitin 2010-01-14 13:18:35 +00:00
  • 5b77c89fbd Patch from Gilad H <gilad.public2@gmail.com> with improvements fixing the following scenario: Vladislav Bolkhovitin 2010-01-14 13:14:30 +00:00
  • 04cb08ec2d Improve handling of aborts of done commands Vladislav Bolkhovitin 2010-01-14 12:59:13 +00:00
  • ee0767206c Removed SRP_CRED_REQ support again. Bart Van Assche 2010-01-13 20:19:54 +00:00
  • 354d74e675 Fixed the following category of checkpatch errors: 3 ERROR: code indent should use tabs where possible Bart Van Assche 2010-01-13 19:33:21 +00:00
  • eada62f329 Fixed processing of REQUEST SENSE and INQUIRY commands for not existing LUNs Vladislav Bolkhovitin 2010-01-13 18:10:10 +00:00
  • 138cd01268 Regular reservations cleanup Vladislav Bolkhovitin 2010-01-13 14:03:55 +00:00
  • dc45f111c6 Fixed a compiler warning about a format specification mismatch. Bart Van Assche 2010-01-13 13:21:08 +00:00
  • b9ad2bae2b Made sure that the EXTRACHECKS_BUG_ON() macro does not trigger a compiler warning about an empty controlled statement in a release or perf build. Bart Van Assche 2010-01-13 13:20:00 +00:00
  • e90930ed6d Made sure that none of the EXTRACHECKS_BUG_ON(), EXTRACHECKS_WARN_ON() or EXTRACHECKS_WARN_ON_ONCE() macros trigger a compiler warning about an empty controlled statement in a release or perf build. Bart Van Assche 2010-01-13 13:13:03 +00:00
  • ddbaa159ca Fixed the following checkpatch complaint: 1 WARNING: braces {} are not necessary for single statement blocks Bart Van Assche 2010-01-13 08:21:39 +00:00
  • 21476c4b9c Docs about QLA FW version updated Vladislav Bolkhovitin 2010-01-12 20:10:56 +00:00
  • 89345ab95c Custom commands parsing cleanups Vladislav Bolkhovitin 2010-01-12 19:05:27 +00:00
  • e5a195516c Link to PRs patch to test updated. Vladislav Bolkhovitin 2010-01-12 15:05:25 +00:00
  • c32ef099ce Patch from Daniel Fernandes <dfernandes1978@hotmail.com> fixing broken link to the Marvell logo after Marvell redesigned their site. Vladislav Bolkhovitin 2010-01-12 14:53:33 +00:00
  • 4a2fcb870b - Logging cleanups. Particularly, TRACE_MGMT_MINOR level was removed - Docs updates - Other minor fixes and cleanups Vladislav Bolkhovitin 2010-01-12 13:29:01 +00:00
  • 2610bf1d0a Fixed a race condition (use-after-free) that could trigger a kernel bug report during module unloading. Bart Van Assche 2010-01-12 08:52:08 +00:00
  • 9b5aec7b7f Web update Vladislav Bolkhovitin 2010-01-11 19:44:15 +00:00
  • 5b930aa9a4 - Improved handling of commands with TASK ABORTED status Vladislav Bolkhovitin 2010-01-11 19:41:23 +00:00
  • a0b91ecc55 Let's experimantally disable SCST_MAX_DEV_COMMANDS and cmd->dev_cmd_count functionality and see if users will complain about it. If not, we will remove it. Vladislav Bolkhovitin 2010-01-11 19:27:07 +00:00
  • 23accb2e12 When converting the SCST source code into a series of upstream patches, SCST is built via the kbuild infastructure. In kernel version 2.6.24 (commit f77bf01425b11947eeb3b5b54685212c302741b8) the kbuild variable ccflags-y has been introduced and the use of EXTRA_CFLAGS in kbuild makefiles has been deprecated. The patch below converts SCST's in-tree makefiles such that these use ccflags-y instead of EXTRA_CFLAGS when generating kernel patches for kernel 2.6.24 or later. Vladislav Bolkhovitin 2010-01-11 19:16:38 +00:00
  • b85002b263 Made sure that if a work completion reports an error status that completion queue processing is not aborted but that the remaining completion queue entries are processed. Bart Van Assche 2010-01-11 19:00:03 +00:00
  • 530ecf06c2 Converted a WARN_ON() into a PRINT_ERROR() statement. Bart Van Assche 2010-01-11 18:41:55 +00:00
  • 661ecd52d2 Close IB channel after session unregistration instead of before in order to prevent the following errors to occur: ib_srpt: srpt_completion:1737:***ERROR***: failed sending response status= 4 ib_srpt: srpt_completion:1737:***ERROR***: failed sending response status= 5 Bart Van Assche 2010-01-11 11:30:08 +00:00
  • 0cd53b65ef Made sure that the pre-cflags patches are uniform to the other in-tree kernel patches, i.e. that -p1 has to be used to apply these patches. Bart Van Assche 2010-01-10 13:16:28 +00:00
  • 048a338747 Backported some 2.6.32 IB bug fixes to the 2.6.30 kernel. Bart Van Assche 2010-01-10 13:14:28 +00:00
  • 5cc522712e Fixed the following race conditions: - With thread=1, the kernel thread was stopped before all I/O was stopped. This could result in IB completions for responses sent to the initiator not being processed, scst_tgt_cmd_done() not being called for certain SCST commands and hence this race could cause "rmmod ib_srpt" to hang. - ib_unregister_event_handler() was called after cancel_work_sync(). This could cause srpt_event_handler() to queue new work, work that could be executed after the data it operates on had been deallocated. Change: simplified module unloading by calling ib_destroy_cm_id(sdev->cm_id) before calling scst_unregister(). This made the variable "cleaning_up" superfluous. Bart Van Assche 2010-01-09 20:14:13 +00:00
  • 1660fe1c3c Fixed the following category of checkpatch complaints: 2 ERROR: code indent should use tabs where possible Bart Van Assche 2010-01-09 15:01:59 +00:00
  • e6ac85312b Commands can be aborted by other transports, so cmnd_rx_continue() should check scst_cmd_aborted(). Vladislav Bolkhovitin 2010-01-08 16:19:31 +00:00
  • c6e5febf06 Mark "completed" should be cleared from being retried commands. Vladislav Bolkhovitin 2010-01-08 16:14:49 +00:00
  • deac5b1d81 Patch from Alexey Obitotskiy <alexeyo1@open-e.com> with 2 fixes and cleanups implementing initiator-oriented access control in sysfs interface. Vladislav Bolkhovitin 2010-01-08 16:11:13 +00:00
  • 6a65d02d9b Web updates Vladislav Bolkhovitin 2010-01-08 16:06:21 +00:00
  • 3ec2a5c02c Updated kernel revisions. Bart Van Assche 2010-01-07 12:41:46 +00:00
  • 7bf99a3584 Removed some TRACE_ENTRY() / TRACE_EXIT() statements. Bart Van Assche 2010-01-06 20:47:08 +00:00
  • 754d139673 Fixed checkpatch complaints about whitespace (use tabs instead of spaces / trailing whitespace) and the sparse complaint about using '0' as a pointer. Bart Van Assche 2010-01-06 20:22:15 +00:00
  • ca9004962d Changes: - srpt_release_channel_by_cmid(): the sdev->spinlock and scst_mgmt_lock are no longer locked nested. - srpt_find_channel(): does now return NULL when the channel is not found (which never happens). Bart Van Assche 2010-01-06 20:11:24 +00:00
  • 05d1bbfedc A huge chunk of related to each other changes, which had to be tested together. Vladislav Bolkhovitin 2010-01-06 13:02:22 +00:00
  • 6a523b3c13 Added more debugging code. Bart Van Assche 2010-01-04 20:56:00 +00:00
  • 45c93135f8 Changes: - Removed references to SCST core internal state names. - Does no longer accept new connections while unloading. - Module unloading should now really no longer cause a hang. Bart Van Assche 2010-01-04 20:26:19 +00:00
  • af086e27a8 Merged two lines. Bart Van Assche 2010-01-04 20:13:04 +00:00
  • af5ae6eeb7 Do not try to include files marked for deletion. Bart Van Assche 2010-01-04 20:05:53 +00:00
  • 388c38bfd9 Fixed typos. Bart Van Assche 2010-01-03 08:34:21 +00:00
  • a8a72c1b51 Fixed sporadic lockup triggered by removing the ib_srpt kernel module. The following complaint was logged by the kernel when this happened: Bart Van Assche 2010-01-02 13:56:12 +00:00
  • d124f1cc8e Changes: - Decreased number of target-to-initiator request send buffers from two to one such that a clear error message can be printed when the SRP initiator did not respond to the SRP_CRED_REQ information unit. - Bug fix: don't modify ch->last_response_req_lim when sending an SRP information unit that contains the REQUEST LIMIT DELTA field failed. Bart Van Assche 2010-01-02 12:27:32 +00:00
  • e1de778c3a Changes related to credit-based SRP buffer management: - Bug fix: don't set the REQUEST LIMIT DELTA field to SRPT_RQ_SIZE when sending the first reponse to the initiator but to the proper value (a small integer). - An SRP_CRED_REQ information unit is now sent to the initiator if the number of I/O contexts available for receiving dropped below two I/O contexts (see also the SRP standard for more information). This change is required to fix the SRP initiator lockup that happens when the initiator sends requests faster than the target can process them. In order to fix the lockup, it is also necessary to implement SRP_CRED_REQ support in the SRP initiator in the vanilla Linux kernel and in OFED. Neither kernel version 2.6.32 nor OFED 1.5 nor any previous version of these components supports SRP_CRED_REQ information units. See also http://bugzilla.kernel.org/show_bug.cgi?id=14235 for more information about the initiator lockup. Bart Van Assche 2010-01-01 17:48:07 +00:00
  • 0d4ba05ae8 Added and commented out the following statement: EXTRA_CFLAGS += -DCONFIG_SCST_EXTRACHECKS Bart Van Assche 2010-01-01 17:06:38 +00:00
  • ad4cde8bfe The patch below fixes the following two issues in the iscsi-scst-howto.txt document: * For some Linux distro's the command iscsi-iname is installed in /usr/sbin and for others in /sbin. * The scst and scst_vdisk modules must be loaded before the sample scstadmin commands work. Vladislav Bolkhovitin 2009-12-28 19:58:39 +00:00
  • bab121a720 Compilation of the SCST's sysfs code triggers a section mismatch because the function scst_sysfs_cleanup() is declared as an exit-only function while it is also called from init_scst(). The patch below fixes this section mismatch. Vladislav Bolkhovitin 2009-12-28 19:55:45 +00:00
  • d1e5f40622 Changes: - Convert sense data to/from fixed format / descriptor format before sending back a response. - Print an error message to the kernel log when an unsupported IB event has been received. - Return the SCSI status BUSY instead of CHECK CONDITION when allocating an SCST command failed (until r1409, the SCSI status in the SRP_RSP information unit was set to TASK SET FULL in this case). Bart Van Assche 2009-12-28 19:31:51 +00:00
  • 8d13d15332 Follow-up for r1415: compiles again without warnings on both 32-bit and 64-bit systems. Bart Van Assche 2009-12-26 18:57:17 +00:00
  • cea7193e0f Updated to do list. Bart Van Assche 2009-12-26 09:23:39 +00:00
  • 2fbe389419 Behavior changes: - Fixed: the SCSOLNT and UCSOLNT bits were ignored in received SRP requests, and the SOLNT bit was not set in responses when required. This is required by the SRP protocol specification. - Fixed: SRP_RSP messages must be limited to the MAXIMUM TARGET TO INITIATOR IU LENGTH field indicated in the SRP_LOGIN_RSP response instead of the maximum message size supported by SRPT. This is also required by the SRP protocol specification. - Fixed: the STATUS field of response messages with status GOOD and that contain sense data is no longer modified into CHECK CONDITION. Internal changes (refactoring): - Replaced the SCSI sense data handling data structures and code in SRPT by those of the SCST core. - Moved the code for building an error response from srpt_handle_cmd() and srpt_handle_tsk_mgmt() to srpt_handle_new_iu(). - Removed the ioctx::data_len member. Bart Van Assche 2009-12-25 15:26:42 +00:00
  • b895a01ca7 Fixed a recently introduced format specification mismatch. Bart Van Assche 2009-12-25 09:10:10 +00:00
  • 3c45b44aee Move all the code from scst_cdbprobe.h to scst_lib.c where it should really belong. Vladislav Bolkhovitin 2009-12-24 19:46:20 +00:00
  • 0075ec260e Limiting MaxOutstandingR2T to 1, because this code is known to crash sometimes. The proper fix is too big for the stable branch. Vladislav Bolkhovitin 2009-12-24 19:33:16 +00:00
  • 370a015ad8 Web updates. Vladislav Bolkhovitin 2009-12-24 13:54:49 +00:00
  • 14fe1bed1e - Die if /proc/scsi_tgt/version doesn't exist. - Replace croak() with die() in the module. Mark Buechler 2009-12-23 19:55:07 +00:00
  • c79bc30298 Updated kernel versions 2.6.27.41, 2.6.31.8 and 2.6.32.1 to 2.6.27.42, 2.6.31.9 and 2.6.32.2 respectively. Bart Van Assche 2009-12-19 10:46:17 +00:00
  • 50c6585066 Made sure that all log lines generated by the ib_srpt kernel module have an "ib_srpt: " prefix. Thanks to Stanley Sufficool for the patch. Bart Van Assche 2009-12-18 19:11:24 +00:00
  • 539edfaf9b Better handling of devices, which don't support MODE SENSE control mode page Vladislav Bolkhovitin 2009-12-18 17:21:27 +00:00
  • 0afea875bc Made sure that checkpatch doesn't complain about missing whitespace around the minus character in the following expression: tgt_dev->curr_sn = (typeof(tgt_dev->curr_sn)) -300 Bart Van Assche 2009-12-18 17:16:03 +00:00
  • 9ebb42805f Small cleanup: there's no need to have SN's long + test on SNs overflow added Vladislav Bolkhovitin 2009-12-17 12:57:24 +00:00
  • 8e8abd54b5 Fixed the following category of complaints reported by the 2.6.32 checkpatch: 11 ERROR: that open brace { should be on the previous line Bart Van Assche 2009-12-16 20:01:08 +00:00