Commit Graph

  • 5f6db09212 Minor cleanup Vladislav Bolkhovitin 2009-09-14 18:02:11 +00:00
  • e25dd44fad Small cleanup: don't do anything if on resync_size command size of the device remained the same Vladislav Bolkhovitin 2009-09-14 17:47:47 +00:00
  • 4decd55808 - Removed blank lines from kernel log. - When a session is being released, it is now logged why. Bart Van Assche 2009-09-13 19:13:31 +00:00
  • 9d78dc61b7 - Renamed PFX macro to LOG_PFX such that it is recognized by the PRINT_INFO() and related macro's. - Replaced printk(KERN_INFO PFX and printk(KERN_ERROR PFX by PRINT_INFO( and PRINT_ERROR( respectively. Bart Van Assche 2009-09-13 18:15:05 +00:00
  • 663e046df0 Made sure that there is only a single blank line before scsi_end_async() in the output of scripts/generate-kernel-patch. Bart Van Assche 2009-09-10 18:26:06 +00:00
  • 6f455c9c30 Replaced kernel versions 2.6.27.31 and 2.6.30.5 by 2.6.27.32 and 2.6.30.6 respectively. Bart Van Assche 2009-09-09 18:30:50 +00:00
  • bd4f1748dd Maintainer's address added Vladislav Bolkhovitin 2009-09-08 11:31:48 +00:00
  • 596fee74a4 Don't try and stop a kernel thread that hasn't started- this will fix some reported oopses. Dotan Barak 2009-09-08 01:45:52 +00:00
  • 72d038f1b6 If we're running newer than 3.0.16 firmware and are in target mode, tell the firmware to not automatically issue a PRLI after a PLOGI. This should solve the problem of being in N-port topology where we have to issue a PLOGI which by default is followed by a PRLI, which makes us an illegal target. Dotan Barak 2009-09-08 01:40:39 +00:00
  • 613542b923 Remove obsolete documentation. Dotan Barak 2009-09-08 01:36:17 +00:00
  • 95032dca33 The patch below fixes occurrences of the following recently introduced checkpatch warning: "do not use assignment in if condition". Vladislav Bolkhovitin 2009-09-07 12:09:16 +00:00
  • 103f8bb8ec Microcleanup to combine the vars alltogether Vladislav Bolkhovitin 2009-09-07 12:02:47 +00:00
  • a003cea218 Do not only remove references of SCSI_EXEC_REQ_FIFO_DEFINED / SCST_IO_CONTEXT but also their definition. Bart Van Assche 2009-09-06 12:02:49 +00:00
  • 9d4e2f9399 Refinements / bug fixes of the changes introduced in the previous commit: - Only replace sBUG/sBUG_ON by BUG/BUG_ON when this macro is being used, not in its definition. - Fixed bugs in algorithm for preserving the original code during a sparse run. Bart Van Assche 2009-09-06 11:09:21 +00:00
  • bea5b6dfc8 Bump up SCSI version to SCSI-3 Vladislav Bolkhovitin 2009-09-04 15:49:41 +00:00
  • 9e18cc659e Whitespace-only changes. Fixed the following categories of checkpatch complaints: - code indent should use tabs where possible. - trailing whitespace. - else should follow close brace '}'. Bart Van Assche 2009-09-03 18:31:22 +00:00
  • 70d66b181f Fix for a problem found by Saar David <liorg@ged-I.com>: the missed << 24 added. Vladislav Bolkhovitin 2009-09-03 16:52:34 +00:00
  • 003204c5e7 The patch below fixes the spelling of a few function names. This patch has been tested by running the following command and verifying its output: scripts/run-regression-tests 2.6.30.4 Vladislav Bolkhovitin 2009-09-03 12:09:33 +00:00
  • f8f89ad8be - Some docs and web updates with minor fixes. Vladislav Bolkhovitin 2009-09-03 11:53:48 +00:00
  • 7d65deaac8 Updated SRPT to do list. Bart Van Assche 2009-09-02 16:43:54 +00:00
  • aaf2ed455d Modified scripts invoked during a regression test run such that the line numbers printed by sparse match those of the SCST source files present in the Subversion repository. Bart Van Assche 2009-09-02 16:42:26 +00:00
  • 4684d781c7 Updated Subversion ignore list. Bart Van Assche 2009-09-02 16:38:27 +00:00
  • 56c36f8ebf Trace_level cleanups Vladislav Bolkhovitin 2009-09-02 09:59:37 +00:00
  • 56440d9262 Minor SGV docs improvements Vladislav Bolkhovitin 2009-09-02 09:58:31 +00:00
  • 0785ab7746 Web fixes and new images from Daniel Fernandes <dfernandes1978@hotmail.com> Vladislav Bolkhovitin 2009-09-02 09:57:23 +00:00
  • 27204db16a Update copyright date on LICENSE. Dotan Barak 2009-08-23 04:10:13 +00:00
  • 9137f7efa0 Updated kernel version 2.6.27.30 to 2.6.27.31. Bart Van Assche 2009-08-17 16:01:06 +00:00
  • 4c429ee3e8 Updated kernel versions: 2.6.30.4 to 2.6.30.5 and 2.6.27.29 to 2.6.27.30. Bart Van Assche 2009-08-17 10:43:28 +00:00
  • 097f5151cb Refinements for SRPT command processing state management. Bart Van Assche 2009-08-16 13:27:01 +00:00
  • d9bc8bbff8 Fixed bug introduced in the previous revision of the specialize-patch script: empty lines after #if ... #else ... #endif blocks were deleted. Bart Van Assche 2009-08-16 12:18:52 +00:00
  • f5248dc2ab Update firmware to that we have in Feral cvs repository. Stanislaw Gruszka 2009-08-15 14:10:08 +00:00
  • 28cb02f78b Minor documentation updates. Bart Van Assche 2009-08-15 13:54:36 +00:00
  • 1e1b800f8b - Changed the identification string displayed by the ibsrpdm tool from "Mellanox OFED SRP target" to "SCST SRP target" to reflect that this version of the SRP target is distributed through the SCST project. - Added kernel parameter use_port_guid_in_session_name that allows to use the original session naming scheme of the SRP target. This should make it again possible to connect to a multiport SRP target by masking out redundant paths on the target. - Made sure that whenever a login is rejected that a kernel message is generated (printk()) such that this information ends up in /var/log/messages. Bart Van Assche 2009-08-15 13:48:12 +00:00
  • 6f191159e9 Added more comments. Bart Van Assche 2009-08-15 13:33:24 +00:00
  • 8c029b22ec Whether or not SCSI_EXEC_REQ_FIFO_DEFINED and SCST_IO_CONTEXT are defined does now depend on their definition in the per kernel-version patches. Bart Van Assche 2009-08-14 19:34:55 +00:00
  • a6d09fdd28 Versions changed on 1.0.1.2 Vladislav Bolkhovitin 2009-08-14 19:22:35 +00:00
  • befe0a36fa Chenge logs and TAGS updated Vladislav Bolkhovitin 2009-08-14 19:19:04 +00:00
  • d8fcc078d1 1.0.1.1 release Vladislav Bolkhovitin 2009-08-14 19:18:05 +00:00
  • 8befa6faad 1.0.1.1 web updates Vladislav Bolkhovitin 2009-08-14 19:16:53 +00:00
  • dedefa34de Rearranged preprocessor statements containing version checks such that these are now processed correctly by scripts/specialize-patch. Bart Van Assche 2009-08-14 18:53:10 +00:00
  • 2232922dd9 - The expression "defined(SCST_IO_CONTEXT)" is now replaced by "1". - The following two lines and the first blank line below are now removed: +#define SCSI_EXEC_REQ_FIFO_DEFINED +#define SCST_IO_CONTEXT - Hunks that do no longer contain any modifications because of the previous steps are now removed from the output because patch otherwise complains. - Added support for evaluating expressions containing the arithmetic operators *, /, +, -. - Removed support for partial evaluation of expressions because it is too tricky to get this right due to operator precedence. Bart Van Assche 2009-08-14 18:26:58 +00:00
  • e6bd69006a Changed terminology in comments and one printk() message such that it matches the terminology used in the SRP spec. Bart Van Assche 2009-08-13 19:05:31 +00:00
  • edb8da8616 - Remove the line "+#define SCSI_EXEC_REQ_FIFO_DEFINED" from the generated patch. - Substitute "defined(SCSI_EXEC_REQ_FIFO_DEFINED)" by "1" in preprocessor statements. Bart Van Assche 2009-08-13 18:29:59 +00:00
  • f748e87fb3 The patch below fixes several recently introduced sparse warnings and errors. The patch below has been tested by verifying the output of the following commands: scripts/run-regression-tests 2.6.29 scripts/run-regression-tests 2.6.30.4 Vladislav Bolkhovitin 2009-08-13 17:34:32 +00:00
  • b9b9ab44f5 Whitespace-only change -- fixed the following checkpatch error: ERROR: space required after that ',' (ctx:VxV). Bart Van Assche 2009-08-13 12:06:04 +00:00
  • fdfb159727 Fixed typo. Bart Van Assche 2009-08-13 09:33:28 +00:00
  • aedd521030 Joined a few preprocessor statements on a single line that were split over multiple lines such that scripts/generate-kernel-patch and scripts/run-regression-tests can process these. Bart Van Assche 2009-08-12 18:01:19 +00:00
  • d3d1fa2d29 New implementation of the pass-through commands execution. Changes: Vladislav Bolkhovitin 2009-08-12 17:13:26 +00:00
  • 63b8d248ce Removed the one_guid_per_ioc kernel parameter again because it did not solve the connectivity problem between WinOF and an SRP target equipped with multiple IB ports. Bart Van Assche 2009-08-11 19:58:48 +00:00
  • 92ef2de4a5 Added a note about the size of struct ib_qp_attr. Bart Van Assche 2009-08-11 19:24:30 +00:00
  • dda7f2f71b - Added "replace" command to replace one LUN by another and generate INQUIRY DATA HAS CHANGED Unit Attention - Sending INQUIRY DATA HAS CHANGED Unit Attention through AENs added - Minor fixes and cleanups Vladislav Bolkhovitin 2009-08-10 16:59:16 +00:00
  • fb6bad5bd9 Should have been included in the previous commit (r1034). Bart Van Assche 2009-08-10 15:44:22 +00:00
  • 64f93b6add - Implemented kernel module parameter one_guid_per_ioc. Setting this parameter to true should make it possible to connect from a WinOF initiator to an SRP target when there is more than one IB path between initiator and target. - Renamed mellanox_ioc_guid into global_ioc_guid. Bart Van Assche 2009-08-10 15:28:03 +00:00
  • cc171de600 Whitespace-only change: fixed a checkpatch complaint about trailing whitespace. Bart Van Assche 2009-08-10 12:39:13 +00:00
  • fbaed7ab3b Whitespace-only changes: fixed checkpatch complaints reported against a 2.6.27 kernel. Bart Van Assche 2009-08-10 12:32:06 +00:00
  • a6189e9096 - Adds generation of INQUERY DATA HAS CHANGED UA for changed devices during automatic sessions reassignment - Requeue global UAs on delivery failure added - Minor fixes and cleanups Vladislav Bolkhovitin 2009-08-10 12:27:29 +00:00
  • 3d227b8f73 - Added consistency checking for the SRPT command state management introduced in r1026. - Removed WARN_ON() statements that could trigger a warning when nothing was wrong because these were reading uninitialized memory. These statements were introduced in r1026. The call stack of the warning logged in the kernel log is as follows: <IRQ> [<ffffffffa057f578>] ? srpt_handle_new_iu+0x818/0xaf0 [ib_srpt] [<ffffffff80243f18>] warn_slowpath_common+0x78/0xd0 [<ffffffff80243f7f>] warn_slowpath_null+0xf/0x20 [<ffffffffa057f578>] srpt_handle_new_iu+0x818/0xaf0 [ib_srpt] [<ffffffffa057f9ab>] srpt_completion+0x15b/0x230 [ib_srpt] [<ffffffffa04351f2>] mlx4_ib_cq_comp+0x12/0x20 [mlx4_ib] [<ffffffffa01eb1aa>] mlx4_cq_completion+0x3a/0x80 [mlx4_core] [<ffffffffa01ec475>] mlx4_eq_int+0x2a5/0x2e0 [mlx4_core] [<ffffffffa01ec59a>] mlx4_msi_x_interrupt+0x6a/0x90 [mlx4_core] [<ffffffff8027c0aa>] handle_IRQ_event+0x3a/0xf0 [<ffffffff8027dee1>] handle_edge_irq+0xc1/0x160 [<ffffffff8020ec3f>] handle_irq+0x1f/0x30 [<ffffffff8020e37a>] do_IRQ+0x6a/0xf0 [<ffffffff8020c7d3>] ret_from_intr+0x0/0xa <EOI> [<ffffffffa0012e52>] ? acpi_idle_enter_simple+0x159/0x187 [processor] [<ffffffffa0012e48>] ? acpi_idle_enter_simple+0x14f/0x187 [processor] [<ffffffff804323e5>] ? cpuidle_idle_call+0xa5/0x100 [<ffffffff8020b0a2>] ? cpu_idle+0x62/0xd0 [<ffffffff804be614>] ? rest_init+0x84/0x90 [<ffffffff8067ecc5>] ? start_kernel+0x35a/0x415 [<ffffffff8067e289>] ? x86_64_start_reservations+0x99/0xb9 [<ffffffff8067e389>] ? x86_64_start_kernel+0xe0/0xf2 Bart Van Assche 2009-08-10 09:57:30 +00:00
  • bbad4dfcaa - Fixed memory leak in srpt_handle_tsk_mgmt() error path. - Modified srpt_build_cmd_rsp() and srpt_build_tskmgmt_rsp() such that these two functions now return the number of bytes of the response PDU built. - Converted a printk() statement to TRACE_DBG(). Bart Van Assche 2009-08-08 15:02:19 +00:00
  • 375a72b685 Added more comments. Bart Van Assche 2009-08-08 14:59:28 +00:00
  • 79e1938ff3 Update README.scst a bit. Stanislaw Gruszka 2009-08-08 13:50:16 +00:00
  • 1b516fab15 Implemented SRPT command state management. The SRPT target code does no longer rely on the struct scst_cmd state managed by the SCST core. Bart Van Assche 2009-08-08 11:52:46 +00:00
  • 10ec474914 Updated Subversion ignore list. Bart Van Assche 2009-08-07 14:17:40 +00:00
  • c7572cd2cb Updated SRPT documentation. Bart Van Assche 2009-08-07 14:14:19 +00:00
  • 4588200994 Patch from Bart Van Assche <bart.vanassche@gmail.com>: Vladislav Bolkhovitin 2009-08-06 17:18:28 +00:00
  • b9cc1d34a2 - Atomic move of a security name from one security group to another implemented - Cleanups Vladislav Bolkhovitin 2009-08-06 16:28:23 +00:00
  • 79b9d3141c Fixed the following checkpatch complaint: return is not a function, parentheses are not required. Bart Van Assche 2009-08-06 13:42:28 +00:00
  • eb9a1f15c3 Web updates Vladislav Bolkhovitin 2009-08-06 11:49:05 +00:00
  • a65caa9b9b Automatic sessions reassignment implemented Vladislav Bolkhovitin 2009-08-06 11:47:18 +00:00
  • 7286d22319 Fixed data races on manipulation of the srpt_devices list by eliminating this list. Only the number of IB devices is relevant for the SRPT implementation. Introduced a new counter that tracks the number of IB devices. Bart Van Assche 2009-08-06 10:05:10 +00:00
  • e9feb2e818 - Refactoring: split srpt_ch_qp_rtr_rts() into two functions, namely srpt_ch_qp_rtr() and srpt_ch_qp_rts(). - Replaced dynamic memory allocation (kmalloc()/kfree()) in the aforementioned two functions by stack allocation. - Compiles again on pre-2.6.22 kernels (RHEL / CentOS systems). Bart Van Assche 2009-08-06 09:12:37 +00:00
  • 8ca3e36e99 - Fixed race conditions related to channel state manipulation. - Inlined srpt_disconnect_channel(). - Modified error handling coding style in srpt_cm_req_recv() to the usual kernel coding style: upon error, jump to the error handling code. - Added more comments. Bart Van Assche 2009-08-05 19:48:16 +00:00
  • 0e1890f3c7 Minor docs update Vladislav Bolkhovitin 2009-08-05 09:50:11 +00:00
  • 6dc8835e7e - Bug fix: if processing of any of the SRP task management functions by the SCST core fails (abort task, LUN reset, ...), an SRP_RSP PDU is now sent back to the initiator. - Added more debug tracing statements. - Improved readability of some parts of the source code. - Added more comments. - Partially reverted one hunk of r1003: while casting an unsigned 64-bit value to the type u64 and printing such values via %llx works fine on x86 systems, the same code triggers a compiler warning on PowerPC systems. So while r1003 changed some (unsigned long long) casts to (u64) casts, this revision changes these back to (unsigned long long) casts. Bart Van Assche 2009-08-04 18:45:46 +00:00
  • b06a932d2c Web updates Vladislav Bolkhovitin 2009-08-04 17:50:43 +00:00
  • cef4a0ec28 A minor SAM violation fixed. Vladislav Bolkhovitin 2009-08-04 17:17:16 +00:00
  • c722a2b159 Minor typo noticed by Bart Van Assche <bart.vanassche@gmail.com> Vladislav Bolkhovitin 2009-08-04 16:59:09 +00:00
  • 05e2ad3452 Merge of r1007: Vladislav Bolkhovitin 2009-08-04 12:03:53 +00:00
  • 01c113dbb4 Patch from Smadar Gonen <smadar.gn@gmail.com>: Vladislav Bolkhovitin 2009-08-04 11:59:15 +00:00
  • 24f4743f68 Web updates Vladislav Bolkhovitin 2009-08-04 11:10:18 +00:00
  • 70110ec078 Fixed race conditions on RDMA channel manipulations found via source reading: - Added a second argument to srpt_find_channel() that specified whether or not the channel should be removed from the channel list if found. - Moved list_del() statement from the body of the srpt_release_channel() function to its callers. Bart Van Assche 2009-08-03 16:00:36 +00:00
  • 7234de012f Multiple cosmetic source code changes. Bart Van Assche 2009-08-03 15:06:00 +00:00
  • 47d7742f4e - Enabled the LUN reset task management function. - Changed return type of srpt_release_channel() from int to void because the return value did depend in a trivial way on the function arguments. Changed the return type of srpt_find_and_release_channel() and several of its callers also from int to void. Instead srpt_cm_handler() now directly sets its own return value. - Converted a list_for_each_entry_safe() into a list_for_each_entry() loop because no elements are added or deleted in the loop body. - Converted debug-printk() statements into TRACE_DBG(). - Changed indentation of one statement from 12 to 16 (was not reported by checkpatch). Bart Van Assche 2009-08-02 18:57:48 +00:00
  • 7cb9d95684 Added even more comments. Bart Van Assche 2009-08-02 18:45:40 +00:00
  • 4d249a4112 Added command-line option -f, which allows to skip the test whether there is still data present. Bart Van Assche 2009-08-02 18:04:21 +00:00
  • c49f89cec1 Whitespace-only change: fixed a checkpatch complaint. Bart Van Assche 2009-08-01 06:50:36 +00:00
  • 7c25f55ad9 Only call scst_tgt_cmd_done() if scst_rx_data() has not been called. Bart Van Assche 2009-08-01 06:03:55 +00:00
  • 58eb630bd0 Fixed the issue that 'rmmod ib_srpt' with ongoing SRP I/O could trigger a deadlock. Bart Van Assche 2009-07-31 11:40:10 +00:00
  • f5097d6263 Whitespace-only changes: fixed checkpatch complaints introduced in the previous commit. Bart Van Assche 2009-07-31 11:33:26 +00:00
  • 221ce1846b Added more comments. Bart Van Assche 2009-07-31 11:27:54 +00:00
  • e843a7c308 Merge of r994: Vladislav Bolkhovitin 2009-07-31 10:54:25 +00:00
  • 3fd8348c46 Patch from Smadar Gonen <smadar.gn@gmail.com> fixing some minor corner cases Vladislav Bolkhovitin 2009-07-31 10:52:40 +00:00
  • ec9041654c Upgraded kernel versions 2.6.27.28 and 2.6.30.3 to 2.6.27.29 and 2.6.30.4 respectively. Bart Van Assche 2009-07-31 06:21:31 +00:00
  • 745a852fbe - Fixed a buffer overrun: a service entry name occupying 35 bytes was written into a buffer with a size of 32 bytes. Enlarged the buffer to 36 bytes. - Converted sprintf() calls to snprintf() calls. - Added more TRACE_ENTRY() / TRACE_EXIT() statements. Bart Van Assche 2009-07-30 12:48:06 +00:00
  • 57f4019ed5 Moved /sys/class/infiniband_srpt/trace_level to /proc/scsi_tgt/ib_srpt/trace_level such that the behavior of the ib_srpt target is consistent with that of other SCST drivers. Bart Van Assche 2009-07-30 08:32:23 +00:00
  • 3bf7d6dca1 Compiles again with tracing disabled. Bart Van Assche 2009-07-30 06:38:15 +00:00
  • 3e18defd73 Should have been included in the previous commit (r988). Bart Van Assche 2009-07-29 18:14:41 +00:00
  • 5d67fefe37 - Fixed a race condition found via source reading: srpt_remove_one() did not wait until srpt_refresh_port_work() finished. This race condition could be triggered during module removal. - Added a kernel module parameter called "trace_flag" that allows to set the trace flags for the ib_srpt module before module initialization starts. - Added sysfs variable /sys/class/infiniband_srpt/trace_level that allows to display and to modify the enabled trace flags in a human-readable form. - Added several TRACE_ENTRY() / TRACE_EXIT() statements. - Added more comments. Bart Van Assche 2009-07-29 16:57:00 +00:00
  • 606ef2bea5 Whitespace-only changes: removed trailing whitespace because checkpatch complained about it. Bart Van Assche 2009-07-29 15:46:46 +00:00
  • d257a9541d - Possibility to operate with single size entries as well as control of the reclamation time added to the SGV caache Vladislav Bolkhovitin 2009-07-29 12:49:17 +00:00
  • e2b8393690 Web updates Vladislav Bolkhovitin 2009-07-28 11:01:22 +00:00