Gleb Chesnokov
714bfca753
Integrate iSCSI test objects in out-of-tree module builds. Move transmit state names to a private header and link a separate suite with task-scoped socket and completion boundaries. Exercise data, padding and digest progress, retries, short sends and TX_END completion. Preserve socket arguments and completion order without creating a socket or initiator session.
3.8 KiB
iSCSI-SCST
Ownership and boundaries
This directory owns the SCST iSCSI target across kernel and user space:
kernel/ implements the target and network data path, usr/ implements
iscsi-scstd and its control/configuration logic, include/ holds their
shared control interfaces, and kernel/isert-scst/ adds the optional iSER/RDMA
transport. It depends on the SCST core and does not own generic SCST LUN/device
semantics or the top-level scst.conf grammar.
Where to verify behavior
include/iscsi_scst.his the shared kernel/daemon ioctl and netlink ABI.kernel/config.c,kernel/event.c,usr/ctldev.c, andusr/event.care its principal producers/consumers. Preserve fixed-width layout, compat handling, andISCSI_SCST_INTERFACE_VERSIONregistration checks.kernel/iscsi_hdr.handusr/iscsi_hdr.hexpress the same wire protocol in environment-specific forms; they are not generated copies. Audit both sides for a protocol PDU, field, digest, or byte-order change.include/iscsit_transport.his the private kernel transport boundary used by the base iSCSI code and iSER. Changes require auditing both implementations.- Verify behavior in current code,
Makefile, Kbuild/Kconfig files, and conftests. UseREADME, HOWTOs, and man pages to locate workflows and compatibility intent, then recheck their commands, defaults, and interfaces against the implementation. The daemon is part of the functioning target, not a replaceable convenience utility. usr/config.cimplements the retained/etc/iscsi-scstd.confparser, andusr/iscsi_adm.cimplements the legacy runtime administration client. Treat both as compatibility interfaces. New persistent configuration belongs toscstadminand/etc/scst.conf, whose grammar is outside this directory.
Coupled changes
- Change the kernel and daemon together for control messages, target/session/
connection parameters, authentication policy, events, or daemon-open state.
Keep the generated interface hash/version check; never edit
include/iscsi_scst_itf_ver.hdirectly. - Sysfs attributes and
[key]metadata are consumed byscstadmin; audit its discovery, write, and configuration serialization paths when changing them. - Command receive, write-data completion, response, abort, task management,
connection close, session unregister, and target teardown cross the SCST and
network lifecycles. Re-derive exact reference, locking, and completion order
from current kernel code and
scst/include/scst.h. - iSER compatibility is selected by RDMA/OFED conftests and symbols. Do not replace feature tests with an assumed kernel-version boundary.
Generated files, validation, and safety
Conftest results/build logs, the interface-version header, .depend*, objects,
modules, Module.symvers, and usr/iscsi-scstd/usr/iscsi-scst-adm are build
artifacts. Change their sources or recipes instead.
The focused compile entry point is top-level make iscsi or make -C iscsi-scst; it builds both user and kernel parts and may run compatibility
conftests. Use repository CI, checkpatch, and regression entry points as
appropriate. Before changing tests under kernel/kunit/, read
the KUnit guide for build and execution entry points,
private interfaces and fixture cleanup.
Do not install or run the daemon, open portals, apply iSCSI configuration,
create targets/sessions/connections, perform discovery/login/logout, manipulate
CHAP secrets, or alter TCP, network-namespace, iSER, or RDMA state without
explicit authorization for both endpoints and the network. Legacy
iscsi-scst-adm account operations can expose CHAP secrets through process
arguments and shell history; do not invoke them with real credentials unless
that exposure and cleanup are explicitly accepted.