mirror of
https://github.com/SCST-project/scst.git
synced 2026-10-22 14:12:33 +00:00
Gleb Chesnokov
8eea926316
Use direct pointer truth tests, put scalar constants on the right and remove redundant parentheses from conditions and address expressions. Preserve required precedence, dereferenced-pointer semantics and short-circuit evaluation. Keep preprocessor expressions and disabled debug alternatives intact. Use __func__ for unchanged parameter-error diagnostics and correct the byte-order diagnostic spelling. Source review also identified eight negated negative-index tests in the daemon's parameter lookup chains. Use explicit >= 0 comparisons while retaining assignment order and short-circuit evaluation. This readability cleanup does not remove assignment-in-condition findings. Checkpatch reports COMPARISON_TO_NULL: Comparison to NULL could be written "target" Checkpatch reports UNNECESSARY_PARENTHESES: Unnecessary parentheses around tlv->value Checkpatch reports CONSTANT_COMPARISON, COMPARISON_TO_NULL. One example: Comparisons should place the constant on the right side of the test Checkpatch reports CONSTANT_COMPARISON, EMBEDDED_FUNCTION_NAME, TYPO_SPELLING. One example: Comparisons should place the constant on the right side of the test
143 lines
3.3 KiB
C
143 lines
3.3 KiB
C
/*
|
|
* debug.c
|
|
*
|
|
* Copyright (C) 2004 - 2018 Vladislav Bolkhovitin <vst@vlnb.net>
|
|
* Copyright (C) 2004 - 2005 Leonid Stoljar
|
|
* Copyright (C) 2007 - 2018 Western Digital Corporation
|
|
*
|
|
* Contains helper functions for execution tracing and error reporting.
|
|
* Intended to be included in main .c file.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation, version 2
|
|
* of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <time.h>
|
|
#include <pthread.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <sys/syscall.h>
|
|
|
|
#include "debug.h"
|
|
|
|
pid_t gettid(void)
|
|
{
|
|
return syscall(__NR_gettid);
|
|
}
|
|
|
|
#if defined(DEBUG) || defined(TRACING)
|
|
|
|
#define TRACE_BUF_SIZE 512
|
|
|
|
static char trace_buf[TRACE_BUF_SIZE];
|
|
static pthread_spinlock_t trace_buf_lock;
|
|
|
|
int debug_print_prefix(unsigned long flags, const char *prefix,
|
|
const char *func, int line)
|
|
{
|
|
int i = 0;
|
|
|
|
pthread_spin_lock(&trace_buf_lock);
|
|
|
|
if (flags & TRACE_TIME) {
|
|
struct tm t;
|
|
time_t tt;
|
|
|
|
time(&tt);
|
|
localtime_r(&tt, &t);
|
|
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "%d:%d:%d ",
|
|
t.tm_hour, t.tm_min, t.tm_sec);
|
|
}
|
|
if (flags & TRACE_PID)
|
|
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "[%d]: ",
|
|
gettid());
|
|
if (prefix)
|
|
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "%s:", prefix);
|
|
if (flags & TRACE_FUNCTION)
|
|
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "%s:", func);
|
|
if (flags & TRACE_LINE)
|
|
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "%i:", line);
|
|
|
|
if (i > 0)
|
|
PRINTN(LOG_INFO, "%s", trace_buf);
|
|
|
|
pthread_spin_unlock(&trace_buf_lock);
|
|
|
|
return i;
|
|
}
|
|
|
|
void debug_print_buffer(const void *data, int len)
|
|
{
|
|
int z, z1, i;
|
|
const unsigned char *buf = (const unsigned char *) data;
|
|
|
|
if (!buf)
|
|
return;
|
|
|
|
pthread_spin_lock(&trace_buf_lock);
|
|
|
|
PRINT(LOG_INFO, " (h)___0__1__2__3__4__5__6__7__8__9__A__B__C__D__E__F");
|
|
for (z = 0, z1 = 0, i = 0; z < len; z++) {
|
|
if (z % 16 == 0) {
|
|
if (z != 0) {
|
|
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i,
|
|
" ");
|
|
for (; (z1 < z) && (i < TRACE_BUF_SIZE - 1);
|
|
z1++) {
|
|
if (buf[z1] >= 0x20 &&
|
|
buf[z1] < 0x80)
|
|
trace_buf[i++] = buf[z1];
|
|
else
|
|
trace_buf[i++] = '.';
|
|
}
|
|
trace_buf[i] = '\0';
|
|
PRINT(LOG_INFO, "%s", trace_buf);
|
|
i = 0;
|
|
}
|
|
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i,
|
|
"%4x: ", z);
|
|
}
|
|
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, "%02x ",
|
|
buf[z]);
|
|
}
|
|
i += snprintf(&trace_buf[i], TRACE_BUF_SIZE - i, " ");
|
|
for (; (z1 < z) && (i < TRACE_BUF_SIZE - 1); z1++) {
|
|
if (buf[z1] > 0x20 && buf[z1] < 0x80)
|
|
trace_buf[i++] = buf[z1];
|
|
else
|
|
trace_buf[i++] = '.';
|
|
}
|
|
trace_buf[i] = '\0';
|
|
PRINT(LOG_INFO, "%s", trace_buf);
|
|
|
|
pthread_spin_unlock(&trace_buf_lock);
|
|
}
|
|
|
|
int debug_init(void)
|
|
{
|
|
int res;
|
|
|
|
res = pthread_spin_init(&trace_buf_lock, PTHREAD_PROCESS_PRIVATE);
|
|
if (res != 0) {
|
|
res = errno;
|
|
PRINT_ERROR("pthread_spin_init() failed: %s", strerror(res));
|
|
}
|
|
|
|
return res;
|
|
}
|
|
|
|
void debug_done(void)
|
|
{
|
|
pthread_spin_destroy(&trace_buf_lock);
|
|
}
|
|
|
|
#endif /* DEBUG || TRACING */
|