mirror of
https://github.com/SCST-project/scst.git
synced 2026-08-19 21:56:31 +00:00
svn+ssh://yanb123@svn.code.sf.net/p/scst/svn/trunk
........
r5875 | bvassche | 2014-11-16 19:58:07 +0200 (Sun, 16 Nov 2014) | 1 line
nightly build: Update kernel versions
........
r5878 | bvassche | 2014-11-19 02:17:41 +0200 (Wed, 19 Nov 2014) | 1 line
srpt/Makefile: Add double quotes around a path
........
r5879 | bvassche | 2014-11-19 02:20:20 +0200 (Wed, 19 Nov 2014) | 1 line
scripts/generate-release-archive: Accept an optional list of file names
........
r5880 | bvassche | 2014-11-22 13:12:29 +0200 (Sat, 22 Nov 2014) | 1 line
nightly build: Update kernel versions
........
r5881 | bvassche | 2014-11-24 19:59:14 +0200 (Mon, 24 Nov 2014) | 4 lines
ib_srpt: Add support for HCA's that do not support SRQ
Based on a patch provided by Parav Pandit <Parav.Pandit@Emulex.Com>
........
r5882 | vlnb | 2014-11-26 09:02:17 +0200 (Wed, 26 Nov 2014) | 3 lines
Update for kernels 3.17.x
........
r5883 | bvassche | 2014-11-26 10:05:09 +0200 (Wed, 26 Nov 2014) | 1 line
Add kernel 3.17 build infrastructure
........
r5884 | bvassche | 2014-11-26 10:07:08 +0200 (Wed, 26 Nov 2014) | 1 line
nightly build: Add kernel 3.17
........
r5885 | bvassche | 2014-11-26 10:16:44 +0200 (Wed, 26 Nov 2014) | 6 lines
Fix kernel 3.17 checkpatch warnings about 'long long unsigned'
Avoid that checkpatch reports the following warning:
WARNING: type 'long long unsigned' should be specified in 'unsigned long long' order.
........
r5886 | bvassche | 2014-11-26 15:38:52 +0200 (Wed, 26 Nov 2014) | 1 line
Build fixes for RHEL 6.6 kernel 2.6.32-504
........
r5887 | bvassche | 2014-11-26 16:39:51 +0200 (Wed, 26 Nov 2014) | 1 line
ib_srpt: Make the send queue full messages more informational
........
r5888 | bvassche | 2014-11-26 18:25:57 +0200 (Wed, 26 Nov 2014) | 1 line
scripts/specialize-patch: Support blanks around numbers inside parentheses
........
r5889 | bvassche | 2014-11-26 21:42:10 +0200 (Wed, 26 Nov 2014) | 1 line
scripts/specialize-patch: Reduce noise in nightly build output
........
r5890 | vlnb | 2014-11-27 06:36:33 +0200 (Thu, 27 Nov 2014) | 3 lines
Cleanup
........
r5891 | bvassche | 2014-11-27 17:18:58 +0200 (Thu, 27 Nov 2014) | 1 line
scst.h: Add uintptr_t
........
r5892 | bvassche | 2014-11-27 17:19:21 +0200 (Thu, 27 Nov 2014) | 1 line
ib_srpt: Add support for immediate data
........
r5893 | bvassche | 2014-11-27 17:24:17 +0200 (Thu, 27 Nov 2014) | 1 line
ib_srpt: Log reject reason
........
r5894 | bvassche | 2014-11-27 17:29:29 +0200 (Thu, 27 Nov 2014) | 1 line
ib_srpt: Rework the max_sge computation changes from r5795
........
r5895 | bvassche | 2014-11-28 11:16:37 +0200 (Fri, 28 Nov 2014) | 1 line
scst: Add scripts/rebuild-rhel-kernel-rpm to the SCST release archive
........
r5903 | bvassche | 2014-12-03 13:50:06 +0200 (Wed, 03 Dec 2014) | 4 lines
scripts/rebuild-rhel-kernel-rpm: Fix an error message
Reported-by: Hiroyuki Sato <hiroysato@gmail.com>
........
r5904 | bvassche | 2014-12-03 19:06:57 +0200 (Wed, 03 Dec 2014) | 1 line
iscsi-scst/kernel/patches/rhel/put_page_callback-2.6.32-504.patch: Add
........
r5905 | bvassche | 2014-12-03 19:07:31 +0200 (Wed, 03 Dec 2014) | 1 line
scripts/rebuild-rhel-kernel-rpm: Add support for RHEL 6.6
........
r5910 | bvassche | 2014-12-04 13:50:58 +0200 (Thu, 04 Dec 2014) | 1 line
scripts/generate-kernel-patch: Swap two filters
........
r5912 | bvassche | 2014-12-04 14:19:56 +0200 (Thu, 04 Dec 2014) | 4 lines
/etc/init.d/scst: Exit with status code 0 upon 'start' if already running
Reported-by: Dimitar Tanev <dimitar@linuxdevgroup.org>
........
r5913 | vlnb | 2014-12-05 01:41:52 +0200 (Fri, 05 Dec 2014) | 3 lines
FORMAT commands should be strictly serialized
........
r5914 | vlnb | 2014-12-05 01:43:51 +0200 (Fri, 05 Dec 2014) | 3 lines
Oops, fix for the previous commit
........
r5928 | vlnb | 2014-12-06 07:02:27 +0200 (Sat, 06 Dec 2014) | 3 lines
Web updates
........
r5929 | bvassche | 2014-12-09 14:33:16 +0200 (Tue, 09 Dec 2014) | 1 line
rpm build: Add support for qla2x00t driver in QLogic git repository
........
r5931 | vlnb | 2014-12-11 06:27:17 +0200 (Thu, 11 Dec 2014) | 3 lines
Docs update
........
r5932 | vlnb | 2014-12-11 06:34:36 +0200 (Thu, 11 Dec 2014) | 8 lines
scst_vdisk: Increase virtual device name length
This change makes integration with OpenStack easier since OpenStack GUIDs
are 36 characters long: 32 hex characters and four dashes.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
r5933 | vlnb | 2014-12-11 06:38:04 +0200 (Thu, 11 Dec 2014) | 11 lines
vdisk_blockio: Report invalid scatterlists
It is possible for a target driver to pass a scatterlist via
scst_cmd_set_tgt_sg() that is valid for the vdisk_fileio handler
but not for the vdisk_blockio handler. Complain loudly if an invalid
scatterlist is passed to vdisk_blockio because such scatterlists
cause silent data corruption with most Linux block drivers.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
r5934 | bvassche | 2014-12-11 14:31:03 +0200 (Thu, 11 Dec 2014) | 1 line
scst_vdisk: Follow-up for r5932
........
r5935 | bvassche | 2014-12-11 14:37:02 +0200 (Thu, 11 Dec 2014) | 1 line
ib_srpt: Log P_Key during login
........
r5936 | bvassche | 2014-12-12 11:29:42 +0200 (Fri, 12 Dec 2014) | 1 line
scripts/generate-kernel-patch: Include scst_pg.sgml instead of sgv_cache.sgml
........
r5937 | bvassche | 2014-12-12 11:34:55 +0200 (Fri, 12 Dec 2014) | 1 line
doc/scst_pg.sgml: Remove trailing whitespace
........
r5938 | bvassche | 2014-12-17 09:48:40 +0200 (Wed, 17 Dec 2014) | 1 line
nightly build: Update kernel versions
........
r5939 | vlnb | 2014-12-19 05:50:58 +0200 (Fri, 19 Dec 2014) | 3 lines
Fallback to the old qla driver if the git one not detected
........
r5940 | vlnb | 2014-12-19 05:55:14 +0200 (Fri, 19 Dec 2014) | 7 lines
Replace in cases, where sporadic failures are possible, HARDWARE ERROR
by INTERNAL TARGET FAILURE, which is retriable (some OS'es don't retry
HARDWARE ERROR)
Reported and suggested by Shahar Salzman <shahar.salzman@kaminario.com>
........
r5941 | vlnb | 2014-12-20 05:48:07 +0200 (Sat, 20 Dec 2014) | 7 lines
scst_vdisk: Only accept NAA IDs allowed by SPC
See also paragraph 7.8.6.6 NAA designator format in SPC-4.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
r5942 | vlnb | 2014-12-20 05:49:23 +0200 (Sat, 20 Dec 2014) | 11 lines
scst_vdisk: Remove superfluous llseek() calls
vfs_read() and vfs_write() ignore the file offset set by llseek().
Hence remove the llseek() calls that occur just before vfs_read() and
vfs_write(). See also the implementation in the Linux kernel of the
pread64() and pwrite64() system calls for examples of code that uses
vfs_read() and vfs_write().
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
r5943 | bvassche | 2014-12-22 14:28:13 +0200 (Mon, 22 Dec 2014) | 1 line
Source code spelling fix: Equivilant -> Equivalent
........
r5944 | bvassche | 2014-12-22 14:28:56 +0200 (Mon, 22 Dec 2014) | 1 line
Source code spelling fix: accesss -> access
........
r5945 | bvassche | 2014-12-22 14:29:51 +0200 (Mon, 22 Dec 2014) | 1 line
Source code spelling fix: addres -> address
........
r5946 | bvassche | 2014-12-22 14:31:08 +0200 (Mon, 22 Dec 2014) | 1 line
Source code spelling fix: authentification -> authentication
........
r5947 | bvassche | 2014-12-22 14:32:30 +0200 (Mon, 22 Dec 2014) | 1 line
Source code comment spelling fix: explicitely -> explicitly
........
r5948 | bvassche | 2014-12-22 14:33:06 +0200 (Mon, 22 Dec 2014) | 1 line
Source code comment spelling fix: hander -> handler
........
r5949 | bvassche | 2014-12-22 14:33:37 +0200 (Mon, 22 Dec 2014) | 1 line
Source code comment spelling fix: loosing -> losing
........
r5950 | bvassche | 2014-12-22 14:35:00 +0200 (Mon, 22 Dec 2014) | 1 line
Spelling fix: occured -> occurred
........
r5951 | bvassche | 2014-12-22 14:35:51 +0200 (Mon, 22 Dec 2014) | 1 line
Source code comment spelling fix: refering -> referring
........
r5952 | bvassche | 2014-12-22 14:36:47 +0200 (Mon, 22 Dec 2014) | 1 line
Spelling fix: shrinked -> shrunk
........
r5953 | bvassche | 2014-12-22 15:08:34 +0200 (Mon, 22 Dec 2014) | 1 line
Spelling fix: choosen -> chosen
........
r5954 | bvassche | 2014-12-22 15:09:20 +0200 (Mon, 22 Dec 2014) | 1 line
Spelling fix: existant -> existent
........
r5955 | bvassche | 2014-12-22 15:10:41 +0200 (Mon, 22 Dec 2014) | 1 line
Update for kernel 3.18
........
r5956 | bvassche | 2014-12-22 15:15:55 +0200 (Mon, 22 Dec 2014) | 1 line
Spelling fix: immediatelly -> immediately
........
r5957 | bvassche | 2014-12-24 16:28:36 +0200 (Wed, 24 Dec 2014) | 1 line
nightly build: Add kernel 3.18
........
r5958 | bvassche | 2014-12-29 14:14:52 +0200 (Mon, 29 Dec 2014) | 1 line
scst_lib: Convert spaces into tabs (reported by checkpatch)
........
r5959 | bvassche | 2015-01-06 15:25:28 +0200 (Tue, 06 Jan 2015) | 1 line
scst_calc_block_shift: Log block shift and sector size upon mismatch
........
r5960 | bvassche | 2015-01-07 11:20:06 +0200 (Wed, 07 Jan 2015) | 4 lines
scst_local: Fix unique per session sas address
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
........
r5961 | bvassche | 2015-01-09 14:23:25 +0200 (Fri, 09 Jan 2015) | 4 lines
scst_sysfs: return EINVAL on too big LUN
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
........
r5962 | bvassche | 2015-01-10 17:52:57 +0200 (Sat, 10 Jan 2015) | 1 line
nightly build: Update kernel versions
........
r5963 | bvassche | 2015-01-13 10:42:28 +0200 (Tue, 13 Jan 2015) | 10 lines
scst: Switch to thread context before executing a reservation command
Persistent reservation commands need thread context because
scst_pr_is_cmd_allowed() locks the PR mutex. Reservation commands
either need BH or thread context. Hence switch from atomic to
thread context before processing such commands.
Reported-by: Shahar Salzman <shahar.salzman@kaminario.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
r5964 | bvassche | 2015-01-13 10:51:08 +0200 (Tue, 13 Jan 2015) | 5 lines
scst_parse_unmap_descriptors(): Avoid using GFP_KERNEL in atomic context
Reported-by: Shahar Salzman <shahar.salzman@kaminario.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
r5965 | bvassche | 2015-01-13 10:55:46 +0200 (Tue, 13 Jan 2015) | 68 lines
qla2x00t: Copy entire SCST sense buffer to q2x ctio
There seems to be a bug in passing sense information to QLA HBAs, where
the last 2 bytes of the sense data (ASC, ASCQ) are not copied to the low
level sense buffer.
We encountered this in ESX, which relies on these 2 bytes to parse the
MISCOMPARE sense code (0xE1, 0x1D, 0x00).
Bellow is a simple test to recreate this issue, but during vMotion
operations (where VMs are moved from one host to another), this may
cause the operation to fail leaving the VM in an inconsistent state.
The test I ran to verify that we are indeed missing the bytes is the
following:
1. Create a SCST based device
2. Expose the device to 2 ESX hosts
3. Format the device as VMFS5, create a test directory
4. From both hosts, I start writing to this directory (no VMs involved,
just write normal files)
At this stage, both ESX hosts try to take access to the directory.
The VMFS filesystem contains a per-directory lock which is managed by
COMPARE AND WRITE command.
Each ESX will attempt to change the VMFS lock location from unlocked to
locked to create the new file.
Obviously there are bound to be failures (which are equivalent to
programming locking conflicts), these are reported by the MISCOMPARE
sense code.
Upon these MISCOMPARE errors, the host will re-try taking the lock until
it succeeds, and will then proceed to perform the write operation on the
directory.
Due to the bug in copying the sense buffer from the SCST core to the QLA
ctio, instead of the full sense code, only the key (0xE) is sent, and
ESX does not know how to handle it resulting in IO error.
Here are the errors as they appear on the command line:
/vmfs/volumes/54a297c4-ca5af1cc-7f94-002219d20f28/ats_test #
./open_close_test-esx2.sh
./open_close_test-esx2.sh: line 8: can't create
ats_fileoptest-esx2_1.txt: Input/output error
./open_close_test-esx2.sh: line 8: can't create
ats_fileoptest-esx2_21.txt: Input/output error
./open_close_test-esx2.sh: line 8: can't create
ats_fileoptest-esx2_110.txt: Input/output error
./open_close_test-esx2.sh: line 8: can't create
ats_fileoptest-esx2_111.txt: Input/output error
In the /var/log/vmkernel.log, we can see that the sense information is
missing (0xE, 0x0, 0x0) instead of (0xE, 0x1D, 0x0).
2014-12-30T12:13:20.714Z cpu6:33519)ScsiDeviceIO: 2338:
Cmd(0x412e84f957c0) 0x89, CmdSN 0x234d from world 519051 to dev
"eui.0024f400d5020007" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0xe 0x0 0x0.
2014-12-30T12:13:20.766Z cpu6:33519)ScsiDeviceIO: 2338:
Cmd(0x412e84f91d00) 0x89, CmdSN 0x2350 from world 519051 to dev
"eui.0024f400d5020007" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0xe 0x0 0x0.
2014-12-30T12:13:20.766Z cpu6:33519)ScsiDeviceIO: 2338:
Cmd(0x412e80449fc0) 0x89, CmdSN 0x234f from world 519051 to dev
"eui.0024f400d5020007" failed H:0x0 D:0x2 P:0x0 Valid sense data: 0xe 0x0 0x0.
This patch fixes this issue, the test will run without a problem with the
fix (no IO errors, all the files are properly written to the directory).
Signed-off-by: Shahar Salzman <shahar.salzman@kaminario.com>
Reviewed-by: Eran Mann <eran.mann@kaminario.com>
[bvanassche: simplified implementation]
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
........
r5966 | bvassche | 2015-01-13 11:38:09 +0200 (Tue, 13 Jan 2015) | 5 lines
qla2x00t: Register for RSCNs in target mode
The QLogic firmware and qla2xxx do not register for RSCNs in
target-only mode, so do that explicitly.
........
r5967 | bvassche | 2015-01-14 10:06:12 +0200 (Wed, 14 Jan 2015) | 1 line
scst_targ: Use tabs instead of spaces for indentation (detected by checkpatch)
........
r5968 | bvassche | 2015-01-15 10:58:39 +0200 (Thu, 15 Jan 2015) | 4 lines
scst_targ: Avoid triggering a kernel panic if dev_user_parse() returns SCST_CMD_STATE_STOP
Reported-by: Ilan Steinberg <ilan.steinberg@kaminario.com>
........
r5969 | vlnb | 2015-01-16 03:21:10 +0200 (Fri, 16 Jan 2015) | 3 lines
Fix READ BUFFER and WRITE BUFFER commands
........
r5970 | vlnb | 2015-01-16 05:16:26 +0200 (Fri, 16 Jan 2015) | 3 lines
Follow up for r5968
........
r5971 | vlnb | 2015-01-16 05:53:29 +0200 (Fri, 16 Jan 2015) | 5 lines
Report during user devices unjam LUN NOT SUPPORTED sense
Reported-By: shahar.salzman <shahar.salzman@kaminario.com>
........
r5972 | bvassche | 2015-01-16 15:01:58 +0200 (Fri, 16 Jan 2015) | 2 lines
scst.spec.in: Rename variable kver into kversion
........
r5973 | bvassche | 2015-01-16 15:12:22 +0200 (Fri, 16 Jan 2015) | 2 lines
scst.spec.in: Pass kernel version via RPM-variable %{kversion} instead of shell variable ${KVER}
........
r5974 | bvassche | 2015-01-16 15:16:06 +0200 (Fri, 16 Jan 2015) | 6 lines
scst.spec.in: Determine version number correctly on a koji server
This patch has been tested on a koji build server and also on four
different RPM-based distributions (CentOS 7, Fedora 20, openSuSE 13.2
and SLES 11 SP3).
........
r5975 | bvassche | 2015-01-16 18:12:38 +0200 (Fri, 16 Jan 2015) | 1 line
scst.spec.in: Leave out kernel version from RPM name
........
r5976 | bvassche | 2015-01-16 18:20:10 +0200 (Fri, 16 Jan 2015) | 1 line
scst.spec.in: Add DKMS support
........
r5977 | vlnb | 2015-01-20 06:18:07 +0200 (Tue, 20 Jan 2015) | 3 lines
Revert r5964 as not needed
........
r5978 | vlnb | 2015-01-20 06:20:13 +0200 (Tue, 20 Jan 2015) | 3 lines
Revert r5963 as not needed
........
r5979 | bvassche | 2015-01-20 17:04:23 +0200 (Tue, 20 Jan 2015) | 13 lines
scst: Rework SCSI pass-through support for kernel versions >= 2.6.30
Changes in this patch:
- Rework the SCSI pass-through code such that for kernel versions
>= 2.6.30 the scst_exec_req_fifo patch is no longer needed.
- Modify the pass-through code such that blk_rq_append_bio() is only
called for kernel version 2.6.30. For later kernel versions
blk_make_request() is called instead.
- Rework scst_scsi_exec_async().
- Add debug tracing of SCSI pass-through result status.
- Add a lockdep_assert_held() call in scsi_end_async().
........
r5980 | bvassche | 2015-01-20 19:13:13 +0200 (Tue, 20 Jan 2015) | 1 line
nightly build: Update kernel versions
........
r5981 | vlnb | 2015-01-21 06:15:42 +0200 (Wed, 21 Jan 2015) | 3 lines
Follow up for r5979
........
r5982 | vlnb | 2015-01-21 06:20:53 +0200 (Wed, 21 Jan 2015) | 5 lines
Fix returning changeable values for caching mode page
Reported by Consus <consus@gmx.com>
........
r5983 | bvassche | 2015-01-21 15:11:56 +0200 (Wed, 21 Jan 2015) | 1 line
scst.h: Fix a sparse warning for kernels 2.6.29..2.6.31
........
r5984 | vlnb | 2015-01-22 07:03:17 +0200 (Thu, 22 Jan 2015) | 9 lines
[PATCH] scst_local: Fix bidirectional command support
scsi_setup_cmnd() sets sc_data_direction to DMA_TO_DEVICE for bidirectional
commands. Hence test SCpnt->request->next_rq instead of sc_data_direction
to figure out whether or not a command is bidirectional.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
........
r5985 | vlnb | 2015-01-22 07:06:45 +0200 (Thu, 22 Jan 2015) | 12 lines
[PATCH] scst_main: Suppress a checkpatch warning triggered by INIT_CACHEP{,_ALIGN}
Avoid that checkpatch v3.18 reports the following warning for these
two macros:
WARNING: Macros with flow control statements should be avoided
This patch does not change any functionality.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
........
r5986 | vlnb | 2015-01-22 07:09:17 +0200 (Thu, 22 Jan 2015) | 9 lines
scst_vdisk: Micro-optimize vdisk_caching_pg
This patch does not change any behavior but micro-optimizes
vdisk_caching_pg(). Declaring the array caching_pg[] const reduces
11 bytes from the assembler code of this function.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
........
r5987 | vlnb | 2015-01-22 07:10:42 +0200 (Thu, 22 Jan 2015) | 10 lines
scst: Suppress a smatch warning in vdisk_unmap_range()
Avoid that the static source code analysis tool 'smatch' reports
the following warning:
vdisk_unmap_range() warn: should 'blocks << cmd->dev->block_shift' be a 64 bit type?
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
........
r5988 | vlnb | 2015-01-22 07:13:59 +0200 (Thu, 22 Jan 2015) | 27 lines
scst_vdisk: Fix zero-copy read for tmpfs
For some filesystems, e.g. tmpfs, address_space.readpage is NULL.
Disable zero-copy reading for such filesystems. See also shmem_aops
in mm/shmem.c. See also inode_init_always() and empty_aops in fs/inode.c.
This patch avoids that the following call trace is triggered:
BUG: unable to handle kernel NULL pointer dereference at (null)
Call Trace:
[<ffffffffa0547d66>] prepare_read+0x106/0x1d0 [scst_vdisk]
[<ffffffffa0547f20>] fileio_alloc_data_buf+0xf0/0x330 [scst_vdisk]
[<ffffffffa046fc9b>] scst_prepare_space+0x9b/0x6e0 [scst]
[<ffffffffa047d4d5>] scst_process_active_cmd+0x545/0x840 [scst]
[<ffffffffa047dad2>] scst_cmd_init_done+0x302/0x5d0 [scst]
[<ffffffffa0563ab2>] scst_cmd_init_stage1_done.constprop.37+0x12/0x20 [iscsi_scst]
[<ffffffffa056a9ea>] scsi_cmnd_start+0x25a/0x550 [iscsi_scst]
[<ffffffffa056b4a8>] cmnd_rx_start+0x148/0x1a0 [iscsi_scst]
[<ffffffffa056e4f8>] process_read_io+0x3b8/0x800 [iscsi_scst]
[<ffffffffa056ea07>] scst_do_job_rd+0xc7/0x220 [iscsi_scst]
[<ffffffffa056efed>] istrd+0x16d/0x2e0 [iscsi_scst]
[<ffffffff81079efd>] kthread+0xed/0x110
[<ffffffff817227fc>] ret_from_fork+0x7c/0xb0
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
........
r5989 | vlnb | 2015-01-24 07:37:57 +0200 (Sat, 24 Jan 2015) | 5 lines
scst_local: Rework data direction detection code
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
........
r5990 | bvassche | 2015-01-26 13:32:32 +0200 (Mon, 26 Jan 2015) | 1 line
ib_srpt: Detect Mellanox OFED 2.3 correctly
........
r5991 | vlnb | 2015-01-28 07:07:46 +0200 (Wed, 28 Jan 2015) | 3 lines
Cleanups
........
git-svn-id: http://svn.code.sf.net/p/scst/svn/branches/iser@5993 d57e44dd-8a1f-0410-8b47-8ef2f437770f
1309 lines
27 KiB
C
1309 lines
27 KiB
C
/*
|
|
* Copyright (C) 2004 - 2005 FUJITA Tomonori <tomof@acm.org>
|
|
* Copyright (C) 2007 - 2014 Vladislav Bolkhovitin
|
|
* Copyright (C) 2007 - 2014 Fusion-io, Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include "iscsi.h"
|
|
|
|
/* Protected by target_mgmt_mutex */
|
|
int ctr_open_state;
|
|
|
|
#ifdef CONFIG_SCST_PROC
|
|
|
|
#include <linux/proc_fs.h>
|
|
|
|
#define ISCSI_PROC_VERSION_NAME "version"
|
|
|
|
#if defined(CONFIG_SCST_DEBUG) || defined(CONFIG_SCST_TRACING)
|
|
|
|
#define ISCSI_PROC_LOG_ENTRY_NAME "trace_level"
|
|
|
|
static struct scst_trace_log iscsi_local_trace_tbl[] = {
|
|
{ TRACE_D_WRITE, "d_write" },
|
|
{ TRACE_CONN_OC, "conn" },
|
|
{ TRACE_CONN_OC_DBG, "conn_dbg" },
|
|
{ TRACE_D_IOV, "iov" },
|
|
{ TRACE_D_DUMP_PDU, "pdu" },
|
|
{ TRACE_NET_PG, "net_page" },
|
|
{ 0, NULL }
|
|
};
|
|
|
|
static int iscsi_log_info_show(struct seq_file *seq, void *v)
|
|
{
|
|
int res = 0;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
res = scst_proc_log_entry_read(seq, trace_flag,
|
|
iscsi_local_trace_tbl);
|
|
|
|
TRACE_EXIT_RES(res);
|
|
return res;
|
|
}
|
|
|
|
static ssize_t iscsi_proc_log_entry_write(struct file *file,
|
|
const char __user *buf, size_t length, loff_t *off)
|
|
{
|
|
int res = 0;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
res = scst_proc_log_entry_write(file, buf, length, &trace_flag,
|
|
ISCSI_DEFAULT_LOG_FLAGS, iscsi_local_trace_tbl);
|
|
|
|
TRACE_EXIT_RES(res);
|
|
return res;
|
|
}
|
|
|
|
#endif /* DEBUG or TRACE */
|
|
|
|
static int iscsi_version_info_show(struct seq_file *seq, void *v)
|
|
{
|
|
TRACE_ENTRY();
|
|
|
|
seq_printf(seq, "%s\n", ISCSI_VERSION_STRING);
|
|
|
|
#ifdef CONFIG_SCST_EXTRACHECKS
|
|
seq_printf(seq, "EXTRACHECKS\n");
|
|
#endif
|
|
|
|
#ifdef CONFIG_SCST_TRACING
|
|
seq_printf(seq, "TRACING\n");
|
|
#endif
|
|
|
|
#ifdef CONFIG_SCST_DEBUG
|
|
seq_printf(seq, "DEBUG\n");
|
|
#endif
|
|
|
|
#ifdef CONFIG_SCST_ISCSI_DEBUG_DIGEST_FAILURES
|
|
seq_printf(seq, "DEBUG_DIGEST_FAILURES\n");
|
|
#endif
|
|
|
|
TRACE_EXIT();
|
|
return 0;
|
|
}
|
|
|
|
static struct scst_proc_data iscsi_version_proc_data = {
|
|
SCST_DEF_RW_SEQ_OP(NULL)
|
|
.show = iscsi_version_info_show,
|
|
};
|
|
|
|
#if defined(CONFIG_SCST_DEBUG) || defined(CONFIG_SCST_TRACING)
|
|
static struct scst_proc_data iscsi_log_proc_data = {
|
|
SCST_DEF_RW_SEQ_OP(iscsi_proc_log_entry_write)
|
|
.show = iscsi_log_info_show,
|
|
};
|
|
#endif
|
|
|
|
static __init int iscsi_proc_log_entry_build(struct scst_tgt_template *templ)
|
|
{
|
|
int res = 0;
|
|
struct proc_dir_entry *p, *root;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
root = scst_proc_get_tgt_root(templ);
|
|
if (root) {
|
|
p = scst_create_proc_entry(root, ISCSI_PROC_VERSION_NAME,
|
|
&iscsi_version_proc_data);
|
|
if (p == NULL) {
|
|
PRINT_ERROR("Not enough memory to register "
|
|
"target driver %s entry %s in /proc",
|
|
templ->name, ISCSI_PROC_VERSION_NAME);
|
|
res = -ENOMEM;
|
|
goto out;
|
|
}
|
|
|
|
#if defined(CONFIG_SCST_DEBUG) || defined(CONFIG_SCST_TRACING)
|
|
/* create the proc file entry for the device */
|
|
iscsi_log_proc_data.data = (void *)templ->name;
|
|
p = scst_create_proc_entry(root, ISCSI_PROC_LOG_ENTRY_NAME,
|
|
&iscsi_log_proc_data);
|
|
if (p == NULL) {
|
|
PRINT_ERROR("Not enough memory to register "
|
|
"target driver %s entry %s in /proc",
|
|
templ->name, ISCSI_PROC_LOG_ENTRY_NAME);
|
|
res = -ENOMEM;
|
|
goto out_remove_ver;
|
|
}
|
|
#endif
|
|
}
|
|
|
|
out:
|
|
TRACE_EXIT_RES(res);
|
|
return res;
|
|
|
|
#if defined(CONFIG_SCST_DEBUG) || defined(CONFIG_SCST_TRACING)
|
|
out_remove_ver:
|
|
remove_proc_entry(ISCSI_PROC_VERSION_NAME, root);
|
|
goto out;
|
|
#endif
|
|
}
|
|
|
|
static void iscsi_proc_log_entry_clean(struct scst_tgt_template *templ)
|
|
{
|
|
struct proc_dir_entry *root;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
root = scst_proc_get_tgt_root(templ);
|
|
if (root) {
|
|
#if defined(CONFIG_SCST_DEBUG) || defined(CONFIG_SCST_TRACING)
|
|
remove_proc_entry(ISCSI_PROC_LOG_ENTRY_NAME, root);
|
|
#endif
|
|
remove_proc_entry(ISCSI_PROC_VERSION_NAME, root);
|
|
}
|
|
|
|
TRACE_EXIT();
|
|
return;
|
|
}
|
|
|
|
struct proc_entries {
|
|
const char *name;
|
|
const struct file_operations *const fops;
|
|
};
|
|
|
|
static struct proc_entries iscsi_proc_entries[] = {
|
|
{"session", &session_seq_fops},
|
|
};
|
|
|
|
static struct proc_dir_entry *proc_iscsi_dir;
|
|
|
|
void iscsi_procfs_exit(void)
|
|
{
|
|
unsigned int i;
|
|
|
|
if (!proc_iscsi_dir)
|
|
return;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(iscsi_proc_entries); i++)
|
|
remove_proc_entry(iscsi_proc_entries[i].name, proc_iscsi_dir);
|
|
|
|
iscsi_proc_log_entry_clean(&iscsi_template);
|
|
}
|
|
|
|
int __init iscsi_procfs_init(void)
|
|
{
|
|
unsigned int i;
|
|
int err = 0;
|
|
struct proc_dir_entry *ent;
|
|
|
|
proc_iscsi_dir = scst_proc_get_tgt_root(&iscsi_template);
|
|
if (proc_iscsi_dir == NULL) {
|
|
err = -ESRCH;
|
|
goto out;
|
|
}
|
|
|
|
#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 30)
|
|
proc_iscsi_dir->owner = THIS_MODULE;
|
|
#endif
|
|
|
|
err = iscsi_proc_log_entry_build(&iscsi_template);
|
|
if (err < 0)
|
|
goto out;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(iscsi_proc_entries); i++) {
|
|
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 25)
|
|
ent = proc_create(iscsi_proc_entries[i].name, 0, proc_iscsi_dir,
|
|
iscsi_proc_entries[i].fops);
|
|
#else
|
|
/*
|
|
* proc_create() was introduced via commit "proc: fix
|
|
* ->open'less usage due to ->proc_fops flip"
|
|
* (2d3a4e3666325a9709cc8ea2e88151394e8f20fc).
|
|
*/
|
|
ent = create_proc_entry(iscsi_proc_entries[i].name, 0,
|
|
proc_iscsi_dir);
|
|
if (ent)
|
|
ent->proc_fops = iscsi_proc_entries[i].fops;
|
|
#endif
|
|
if (!ent) {
|
|
err = -ENOMEM;
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
out:
|
|
return err;
|
|
|
|
err:
|
|
if (proc_iscsi_dir)
|
|
iscsi_procfs_exit();
|
|
goto out;
|
|
}
|
|
|
|
#else /* CONFIG_SCST_PROC */
|
|
|
|
/* Protected by target_mgmt_mutex */
|
|
static LIST_HEAD(iscsi_attrs_list);
|
|
|
|
static ssize_t iscsi_version_show(struct kobject *kobj,
|
|
struct kobj_attribute *attr, char *buf)
|
|
{
|
|
TRACE_ENTRY();
|
|
|
|
sprintf(buf, "%s\n", ISCSI_VERSION_STRING);
|
|
|
|
#ifdef CONFIG_SCST_EXTRACHECKS
|
|
strcat(buf, "EXTRACHECKS\n");
|
|
#endif
|
|
|
|
#ifdef CONFIG_SCST_TRACING
|
|
strcat(buf, "TRACING\n");
|
|
#endif
|
|
|
|
#ifdef CONFIG_SCST_DEBUG
|
|
strcat(buf, "DEBUG\n");
|
|
#endif
|
|
|
|
#ifdef CONFIG_SCST_ISCSI_DEBUG_DIGEST_FAILURES
|
|
strcat(buf, "DEBUG_DIGEST_FAILURES\n");
|
|
#endif
|
|
|
|
TRACE_EXIT();
|
|
return strlen(buf);
|
|
}
|
|
|
|
static struct kobj_attribute iscsi_version_attr =
|
|
__ATTR(version, S_IRUGO, iscsi_version_show, NULL);
|
|
|
|
static ssize_t iscsi_open_state_show(struct kobject *kobj,
|
|
struct kobj_attribute *attr, char *buf)
|
|
{
|
|
switch (ctr_open_state) {
|
|
case ISCSI_CTR_OPEN_STATE_CLOSED:
|
|
sprintf(buf, "%s\n", "closed");
|
|
break;
|
|
case ISCSI_CTR_OPEN_STATE_OPEN:
|
|
sprintf(buf, "%s\n", "open");
|
|
break;
|
|
case ISCSI_CTR_OPEN_STATE_CLOSING:
|
|
sprintf(buf, "%s\n", "closing");
|
|
break;
|
|
default:
|
|
sprintf(buf, "%s\n", "unknown");
|
|
break;
|
|
}
|
|
|
|
return strlen(buf);
|
|
}
|
|
|
|
static struct kobj_attribute iscsi_open_state_attr =
|
|
__ATTR(open_state, S_IRUGO, iscsi_open_state_show, NULL);
|
|
|
|
const struct attribute *iscsi_attrs[] = {
|
|
&iscsi_version_attr.attr,
|
|
&iscsi_open_state_attr.attr,
|
|
NULL,
|
|
};
|
|
|
|
#endif /* CONFIG_SCST_PROC */
|
|
|
|
/* target_mgmt_mutex supposed to be locked */
|
|
static int add_conn(void __user *ptr)
|
|
{
|
|
int err, rc;
|
|
struct iscsi_session *session;
|
|
struct iscsi_kern_conn_info info;
|
|
struct iscsi_target *target;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
rc = copy_from_user(&info, ptr, sizeof(info));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy %d user's bytes", rc);
|
|
err = -EFAULT;
|
|
goto out;
|
|
}
|
|
|
|
target = target_lookup_by_id(info.tid);
|
|
if (target == NULL) {
|
|
PRINT_ERROR("Target %d not found", info.tid);
|
|
err = -ENOENT;
|
|
goto out;
|
|
}
|
|
|
|
mutex_lock(&target->target_mutex);
|
|
|
|
session = session_lookup(target, info.sid);
|
|
if (!session) {
|
|
PRINT_ERROR("Session %lld not found",
|
|
(unsigned long long int)info.tid);
|
|
err = -ENOENT;
|
|
goto out_unlock;
|
|
}
|
|
|
|
err = __add_conn(session, &info);
|
|
|
|
out_unlock:
|
|
mutex_unlock(&target->target_mutex);
|
|
|
|
out:
|
|
TRACE_EXIT_RES(err);
|
|
return err;
|
|
}
|
|
|
|
/* target_mgmt_mutex supposed to be locked */
|
|
static int del_conn(void __user *ptr)
|
|
{
|
|
int err, rc;
|
|
struct iscsi_session *session;
|
|
struct iscsi_kern_conn_info info;
|
|
struct iscsi_target *target;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
rc = copy_from_user(&info, ptr, sizeof(info));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy %d user's bytes", rc);
|
|
err = -EFAULT;
|
|
goto out;
|
|
}
|
|
|
|
target = target_lookup_by_id(info.tid);
|
|
if (target == NULL) {
|
|
PRINT_ERROR("Target %d not found", info.tid);
|
|
err = -ENOENT;
|
|
goto out;
|
|
}
|
|
|
|
mutex_lock(&target->target_mutex);
|
|
|
|
session = session_lookup(target, info.sid);
|
|
if (!session) {
|
|
PRINT_ERROR("Session %llx not found",
|
|
(unsigned long long int)info.sid);
|
|
err = -ENOENT;
|
|
goto out_unlock;
|
|
}
|
|
|
|
err = __del_conn(session, &info);
|
|
|
|
out_unlock:
|
|
mutex_unlock(&target->target_mutex);
|
|
|
|
out:
|
|
TRACE_EXIT_RES(err);
|
|
return err;
|
|
}
|
|
|
|
/* target_mgmt_mutex supposed to be locked */
|
|
static int add_session(void __user *ptr)
|
|
{
|
|
int err, rc;
|
|
struct iscsi_kern_session_info *info;
|
|
struct iscsi_target *target;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
lockdep_assert_held(&target_mgmt_mutex);
|
|
|
|
info = kzalloc(sizeof(*info), GFP_KERNEL);
|
|
if (info == NULL) {
|
|
PRINT_ERROR("Can't alloc info (size %zd)", sizeof(*info));
|
|
err = -ENOMEM;
|
|
goto out;
|
|
}
|
|
|
|
rc = copy_from_user(info, ptr, sizeof(*info));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy %d user's bytes", rc);
|
|
err = -EFAULT;
|
|
goto out_free;
|
|
}
|
|
|
|
info->initiator_name[sizeof(info->initiator_name)-1] = '\0';
|
|
#ifdef CONFIG_SCST_PROC
|
|
info->user_name[sizeof(info->user_name)-1] = '\0';
|
|
#endif
|
|
info->full_initiator_name[sizeof(info->full_initiator_name)-1] = '\0';
|
|
|
|
target = target_lookup_by_id(info->tid);
|
|
if (target == NULL) {
|
|
PRINT_ERROR("Target %d not found", info->tid);
|
|
err = -ENOENT;
|
|
goto out_free;
|
|
}
|
|
|
|
err = __add_session(target, info);
|
|
|
|
out_free:
|
|
kfree(info);
|
|
|
|
out:
|
|
TRACE_EXIT_RES(err);
|
|
return err;
|
|
}
|
|
|
|
/* target_mgmt_mutex supposed to be locked */
|
|
static int del_session(void __user *ptr)
|
|
{
|
|
int err, rc;
|
|
struct iscsi_kern_session_info *info;
|
|
struct iscsi_target *target;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
info = kzalloc(sizeof(*info), GFP_KERNEL);
|
|
if (info == NULL) {
|
|
PRINT_ERROR("Can't alloc info (size %zd)", sizeof(*info));
|
|
err = -ENOMEM;
|
|
goto out;
|
|
}
|
|
|
|
rc = copy_from_user(info, ptr, sizeof(*info));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy %d user's bytes", rc);
|
|
err = -EFAULT;
|
|
goto out_free;
|
|
}
|
|
|
|
info->initiator_name[sizeof(info->initiator_name)-1] = '\0';
|
|
#ifdef CONFIG_SCST_PROC
|
|
info->user_name[sizeof(info->user_name)-1] = '\0';
|
|
#endif
|
|
|
|
target = target_lookup_by_id(info->tid);
|
|
if (target == NULL) {
|
|
PRINT_ERROR("Target %d not found", info->tid);
|
|
err = -ENOENT;
|
|
goto out_free;
|
|
}
|
|
|
|
mutex_lock(&target->target_mutex);
|
|
err = __del_session(target, info->sid);
|
|
mutex_unlock(&target->target_mutex);
|
|
|
|
out_free:
|
|
kfree(info);
|
|
|
|
out:
|
|
TRACE_EXIT_RES(err);
|
|
return err;
|
|
}
|
|
|
|
/* target_mgmt_mutex supposed to be locked */
|
|
static int iscsi_params_config(void __user *ptr, int set)
|
|
{
|
|
int err, rc;
|
|
struct iscsi_kern_params_info info;
|
|
struct iscsi_target *target;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
rc = copy_from_user(&info, ptr, sizeof(info));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy %d user's bytes", rc);
|
|
err = -EFAULT;
|
|
goto out;
|
|
}
|
|
|
|
target = target_lookup_by_id(info.tid);
|
|
if (target == NULL) {
|
|
PRINT_ERROR("Target %d not found", info.tid);
|
|
err = -ENOENT;
|
|
goto out;
|
|
}
|
|
|
|
mutex_lock(&target->target_mutex);
|
|
err = iscsi_params_set(target, &info, set);
|
|
mutex_unlock(&target->target_mutex);
|
|
|
|
if (err < 0)
|
|
goto out;
|
|
|
|
if (!set) {
|
|
rc = copy_to_user(ptr, &info, sizeof(info));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy to user %d bytes", rc);
|
|
err = -EFAULT;
|
|
goto out;
|
|
}
|
|
}
|
|
|
|
out:
|
|
TRACE_EXIT_RES(err);
|
|
return err;
|
|
}
|
|
|
|
/* target_mgmt_mutex supposed to be locked */
|
|
static int iscsi_initiator_allowed(void __user *ptr)
|
|
{
|
|
int err = 0, rc;
|
|
struct iscsi_kern_initiator_info cinfo;
|
|
struct iscsi_target *target;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
rc = copy_from_user(&cinfo, ptr, sizeof(cinfo));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy %d user's bytes", rc);
|
|
err = -EFAULT;
|
|
goto out;
|
|
}
|
|
|
|
cinfo.full_initiator_name[sizeof(cinfo.full_initiator_name)-1] = '\0';
|
|
|
|
target = target_lookup_by_id(cinfo.tid);
|
|
if (target == NULL) {
|
|
PRINT_ERROR("Target %d not found", cinfo.tid);
|
|
err = -ENOENT;
|
|
goto out;
|
|
}
|
|
|
|
err = scst_initiator_has_luns(target->scst_tgt,
|
|
cinfo.full_initiator_name);
|
|
|
|
out:
|
|
TRACE_EXIT_RES(err);
|
|
return err;
|
|
}
|
|
|
|
#ifndef CONFIG_SCST_PROC
|
|
|
|
/* target_mgmt_mutex supposed to be locked */
|
|
static int mgmt_cmd_callback(void __user *ptr)
|
|
{
|
|
int err = 0, rc;
|
|
struct iscsi_kern_mgmt_cmd_res_info cinfo;
|
|
struct scst_sysfs_user_info *info;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
rc = copy_from_user(&cinfo, ptr, sizeof(cinfo));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy %d user's bytes", rc);
|
|
err = -EFAULT;
|
|
goto out;
|
|
}
|
|
|
|
cinfo.value[sizeof(cinfo.value)-1] = '\0';
|
|
|
|
info = scst_sysfs_user_get_info(cinfo.cookie);
|
|
TRACE_DBG("cookie %u, info %p, result %d", cinfo.cookie, info,
|
|
cinfo.result);
|
|
if (info == NULL) {
|
|
err = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
info->info_status = 0;
|
|
|
|
if (cinfo.result != 0) {
|
|
info->info_status = cinfo.result;
|
|
goto out_complete;
|
|
}
|
|
|
|
switch (cinfo.req_cmd) {
|
|
case E_ENABLE_TARGET:
|
|
case E_DISABLE_TARGET:
|
|
{
|
|
struct iscsi_target *target;
|
|
|
|
target = target_lookup_by_id(cinfo.tid);
|
|
if (target == NULL) {
|
|
PRINT_ERROR("Target %d not found", cinfo.tid);
|
|
err = -ENOENT;
|
|
goto out_status;
|
|
}
|
|
|
|
target->tgt_enabled = (cinfo.req_cmd == E_ENABLE_TARGET) ? 1 : 0;
|
|
break;
|
|
}
|
|
|
|
case E_GET_ATTR_VALUE:
|
|
info->data = kstrdup(cinfo.value, GFP_KERNEL);
|
|
if (info->data == NULL) {
|
|
PRINT_ERROR("Can't duplicate value %s", cinfo.value);
|
|
info->info_status = -ENOMEM;
|
|
goto out_complete;
|
|
}
|
|
break;
|
|
}
|
|
|
|
out_complete:
|
|
complete(&info->info_completion);
|
|
|
|
out:
|
|
TRACE_EXIT_RES(err);
|
|
return err;
|
|
|
|
out_status:
|
|
info->info_status = err;
|
|
goto out_complete;
|
|
}
|
|
|
|
static ssize_t iscsi_attr_show(struct kobject *kobj,
|
|
struct kobj_attribute *attr, char *buf)
|
|
{
|
|
int pos;
|
|
struct iscsi_attr *tgt_attr;
|
|
void *value;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
tgt_attr = container_of(attr, struct iscsi_attr, attr);
|
|
|
|
pos = iscsi_sysfs_send_event(
|
|
(tgt_attr->target != NULL) ? tgt_attr->target->tid : 0,
|
|
E_GET_ATTR_VALUE, tgt_attr->name, NULL, &value);
|
|
|
|
if (pos != 0)
|
|
goto out;
|
|
|
|
pos = scnprintf(buf, SCST_SYSFS_BLOCK_SIZE, "%s\n", (char *)value);
|
|
|
|
kfree(value);
|
|
|
|
out:
|
|
TRACE_EXIT_RES(pos);
|
|
return pos;
|
|
}
|
|
|
|
static ssize_t iscsi_attr_store(struct kobject *kobj,
|
|
struct kobj_attribute *attr, const char *buf, size_t count)
|
|
{
|
|
int res;
|
|
char *buffer;
|
|
struct iscsi_attr *tgt_attr;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
buffer = kzalloc(count+1, GFP_KERNEL);
|
|
if (buffer == NULL) {
|
|
res = -ENOMEM;
|
|
goto out;
|
|
}
|
|
memcpy(buffer, buf, count);
|
|
buffer[count] = '\0';
|
|
|
|
tgt_attr = container_of(attr, struct iscsi_attr, attr);
|
|
|
|
TRACE_DBG("attr %s, buffer %s", tgt_attr->attr.attr.name, buffer);
|
|
|
|
res = iscsi_sysfs_send_event(
|
|
(tgt_attr->target != NULL) ? tgt_attr->target->tid : 0,
|
|
E_SET_ATTR_VALUE, tgt_attr->name, buffer, NULL);
|
|
|
|
kfree(buffer);
|
|
|
|
if (res == 0)
|
|
res = count;
|
|
|
|
out:
|
|
TRACE_EXIT_RES(res);
|
|
return res;
|
|
}
|
|
|
|
/*
|
|
* target_mgmt_mutex supposed to be locked. If target != 0, target_mutex
|
|
* supposed to be locked as well.
|
|
*/
|
|
int iscsi_add_attr(struct iscsi_target *target,
|
|
const struct iscsi_kern_attr *attr_info)
|
|
{
|
|
int res = 0;
|
|
struct iscsi_attr *tgt_attr;
|
|
struct list_head *attrs_list;
|
|
const char *name;
|
|
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 34)
|
|
#ifdef CONFIG_DEBUG_LOCK_ALLOC
|
|
static struct lock_class_key __key;
|
|
#endif
|
|
#endif
|
|
|
|
TRACE_ENTRY();
|
|
|
|
if (target != NULL) {
|
|
attrs_list = &target->attrs_list;
|
|
name = target->name;
|
|
} else {
|
|
attrs_list = &iscsi_attrs_list;
|
|
name = "global";
|
|
}
|
|
|
|
list_for_each_entry(tgt_attr, attrs_list, attrs_list_entry) {
|
|
/* Both for sure NULL-terminated */
|
|
if (strcmp(tgt_attr->name, attr_info->name) == 0) {
|
|
PRINT_ERROR("Attribute %s for %s already exist",
|
|
attr_info->name, name);
|
|
res = -EEXIST;
|
|
goto out;
|
|
}
|
|
}
|
|
|
|
TRACE_DBG("Adding %s's attr %s with mode %x", name,
|
|
attr_info->name, attr_info->mode);
|
|
|
|
tgt_attr = kzalloc(sizeof(*tgt_attr), GFP_KERNEL);
|
|
if (tgt_attr == NULL) {
|
|
PRINT_ERROR("Unable to allocate user (size %zd)",
|
|
sizeof(*tgt_attr));
|
|
res = -ENOMEM;
|
|
goto out;
|
|
}
|
|
|
|
tgt_attr->target = target;
|
|
|
|
tgt_attr->name = kstrdup(attr_info->name, GFP_KERNEL);
|
|
if (tgt_attr->name == NULL) {
|
|
PRINT_ERROR("Unable to allocate attr %s name/value (target %s)",
|
|
attr_info->name, name);
|
|
res = -ENOMEM;
|
|
goto out_free;
|
|
}
|
|
|
|
list_add(&tgt_attr->attrs_list_entry, attrs_list);
|
|
|
|
tgt_attr->attr.attr.name = tgt_attr->name;
|
|
#if LINUX_VERSION_CODE <= KERNEL_VERSION(2, 6, 35)
|
|
tgt_attr->attr.attr.owner = THIS_MODULE;
|
|
#endif
|
|
#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 34)
|
|
#ifdef CONFIG_DEBUG_LOCK_ALLOC
|
|
tgt_attr->attr.attr.key = &__key;
|
|
#endif
|
|
#endif
|
|
tgt_attr->attr.attr.mode = attr_info->mode & (S_IRUGO | S_IWUGO);
|
|
tgt_attr->attr.show = iscsi_attr_show;
|
|
tgt_attr->attr.store = iscsi_attr_store;
|
|
|
|
TRACE_DBG("tgt_attr %p, attr %p", tgt_attr, &tgt_attr->attr.attr);
|
|
|
|
res = sysfs_create_file(
|
|
(target != NULL) ? scst_sysfs_get_tgt_kobj(target->scst_tgt) :
|
|
scst_sysfs_get_tgtt_kobj(&iscsi_template),
|
|
&tgt_attr->attr.attr);
|
|
if (res != 0) {
|
|
PRINT_ERROR("Unable to create file '%s' for target '%s'",
|
|
tgt_attr->attr.attr.name, name);
|
|
goto out_del;
|
|
}
|
|
|
|
out:
|
|
TRACE_EXIT_RES(res);
|
|
return res;
|
|
|
|
out_del:
|
|
list_del(&tgt_attr->attrs_list_entry);
|
|
|
|
out_free:
|
|
kfree(tgt_attr->name);
|
|
kfree(tgt_attr);
|
|
goto out;
|
|
}
|
|
|
|
void __iscsi_del_attr(struct iscsi_target *target,
|
|
struct iscsi_attr *tgt_attr)
|
|
{
|
|
TRACE_ENTRY();
|
|
|
|
TRACE_DBG("Deleting attr %s (target %s, tgt_attr %p, attr %p)",
|
|
tgt_attr->name, (target != NULL) ? target->name : "global",
|
|
tgt_attr, &tgt_attr->attr.attr);
|
|
|
|
list_del(&tgt_attr->attrs_list_entry);
|
|
|
|
sysfs_remove_file((target != NULL) ?
|
|
scst_sysfs_get_tgt_kobj(target->scst_tgt) :
|
|
scst_sysfs_get_tgtt_kobj(&iscsi_template),
|
|
&tgt_attr->attr.attr);
|
|
|
|
kfree(tgt_attr->name);
|
|
kfree(tgt_attr);
|
|
|
|
TRACE_EXIT();
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* target_mgmt_mutex supposed to be locked. If target != 0, target_mutex
|
|
* supposed to be locked as well.
|
|
*/
|
|
static int iscsi_del_attr(struct iscsi_target *target,
|
|
const char *attr_name)
|
|
{
|
|
int res = 0;
|
|
struct iscsi_attr *tgt_attr, *a;
|
|
struct list_head *attrs_list;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
if (target != NULL)
|
|
attrs_list = &target->attrs_list;
|
|
else
|
|
attrs_list = &iscsi_attrs_list;
|
|
|
|
tgt_attr = NULL;
|
|
list_for_each_entry(a, attrs_list, attrs_list_entry) {
|
|
/* Both for sure NULL-terminated */
|
|
if (strcmp(a->name, attr_name) == 0) {
|
|
tgt_attr = a;
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (tgt_attr == NULL) {
|
|
PRINT_ERROR("attr %s not found (target %s)", attr_name,
|
|
(target != NULL) ? target->name : "global");
|
|
res = -ENOENT;
|
|
goto out;
|
|
}
|
|
|
|
__iscsi_del_attr(target, tgt_attr);
|
|
|
|
out:
|
|
TRACE_EXIT_RES(res);
|
|
return res;
|
|
}
|
|
|
|
/* target_mgmt_mutex supposed to be locked */
|
|
static int iscsi_attr_cmd(void __user *ptr, unsigned int cmd)
|
|
{
|
|
int rc, err = 0;
|
|
struct iscsi_kern_attr_info info;
|
|
struct iscsi_target *target;
|
|
struct scst_sysfs_user_info *i = NULL;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
rc = copy_from_user(&info, ptr, sizeof(info));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy %d user's bytes", rc);
|
|
err = -EFAULT;
|
|
goto out;
|
|
}
|
|
|
|
info.attr.name[sizeof(info.attr.name)-1] = '\0';
|
|
|
|
if (info.cookie != 0) {
|
|
i = scst_sysfs_user_get_info(info.cookie);
|
|
TRACE_DBG("cookie %u, uinfo %p", info.cookie, i);
|
|
if (i == NULL) {
|
|
err = -EINVAL;
|
|
goto out;
|
|
}
|
|
}
|
|
|
|
target = target_lookup_by_id(info.tid);
|
|
|
|
if (target != NULL)
|
|
mutex_lock(&target->target_mutex);
|
|
|
|
switch (cmd) {
|
|
case ISCSI_ATTR_ADD:
|
|
err = iscsi_add_attr(target, &info.attr);
|
|
break;
|
|
case ISCSI_ATTR_DEL:
|
|
err = iscsi_del_attr(target, info.attr.name);
|
|
break;
|
|
default:
|
|
sBUG();
|
|
}
|
|
|
|
if (target != NULL)
|
|
mutex_unlock(&target->target_mutex);
|
|
|
|
if (i != NULL) {
|
|
i->info_status = err;
|
|
complete(&i->info_completion);
|
|
}
|
|
|
|
out:
|
|
TRACE_EXIT_RES(err);
|
|
return err;
|
|
}
|
|
|
|
#endif /* CONFIG_SCST_PROC */
|
|
|
|
/* target_mgmt_mutex supposed to be locked */
|
|
static int add_target(void __user *ptr)
|
|
{
|
|
int err, rc;
|
|
struct iscsi_kern_target_info *info;
|
|
#ifndef CONFIG_SCST_PROC
|
|
struct scst_sysfs_user_info *uinfo;
|
|
#endif
|
|
|
|
TRACE_ENTRY();
|
|
|
|
info = kzalloc(sizeof(*info), GFP_KERNEL);
|
|
if (info == NULL) {
|
|
PRINT_ERROR("Can't alloc info (size %zd)", sizeof(*info));
|
|
err = -ENOMEM;
|
|
goto out;
|
|
}
|
|
|
|
rc = copy_from_user(info, ptr, sizeof(*info));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy %d user's bytes", rc);
|
|
err = -EFAULT;
|
|
goto out_free;
|
|
}
|
|
|
|
if (target_lookup_by_id(info->tid) != NULL) {
|
|
PRINT_ERROR("Target %u already exist!", info->tid);
|
|
err = -EEXIST;
|
|
goto out_free;
|
|
}
|
|
|
|
info->name[sizeof(info->name)-1] = '\0';
|
|
|
|
#ifndef CONFIG_SCST_PROC
|
|
if (info->cookie != 0) {
|
|
uinfo = scst_sysfs_user_get_info(info->cookie);
|
|
TRACE_DBG("cookie %u, uinfo %p", info->cookie, uinfo);
|
|
if (uinfo == NULL) {
|
|
err = -EINVAL;
|
|
goto out_free;
|
|
}
|
|
} else
|
|
uinfo = NULL;
|
|
#endif
|
|
|
|
err = __add_target(info);
|
|
|
|
#ifndef CONFIG_SCST_PROC
|
|
if (uinfo != NULL) {
|
|
uinfo->info_status = err;
|
|
complete(&uinfo->info_completion);
|
|
}
|
|
#endif
|
|
|
|
out_free:
|
|
kfree(info);
|
|
|
|
out:
|
|
TRACE_EXIT_RES(err);
|
|
return err;
|
|
}
|
|
|
|
/* target_mgmt_mutex supposed to be locked */
|
|
static int del_target(void __user *ptr)
|
|
{
|
|
int err, rc;
|
|
struct iscsi_kern_target_info info;
|
|
#ifndef CONFIG_SCST_PROC
|
|
struct scst_sysfs_user_info *uinfo;
|
|
#endif
|
|
|
|
TRACE_ENTRY();
|
|
|
|
rc = copy_from_user(&info, ptr, sizeof(info));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy %d user's bytes", rc);
|
|
err = -EFAULT;
|
|
goto out;
|
|
}
|
|
|
|
info.name[sizeof(info.name)-1] = '\0';
|
|
|
|
#ifndef CONFIG_SCST_PROC
|
|
if (info.cookie != 0) {
|
|
uinfo = scst_sysfs_user_get_info(info.cookie);
|
|
TRACE_DBG("cookie %u, uinfo %p", info.cookie, uinfo);
|
|
if (uinfo == NULL) {
|
|
err = -EINVAL;
|
|
goto out;
|
|
}
|
|
} else
|
|
uinfo = NULL;
|
|
#endif
|
|
|
|
err = __del_target(info.tid);
|
|
|
|
#ifndef CONFIG_SCST_PROC
|
|
if (uinfo != NULL) {
|
|
uinfo->info_status = err;
|
|
complete(&uinfo->info_completion);
|
|
}
|
|
#endif
|
|
|
|
out:
|
|
TRACE_EXIT_RES(err);
|
|
return err;
|
|
}
|
|
|
|
static int iscsi_register(void __user *arg)
|
|
{
|
|
struct iscsi_kern_register_info reg;
|
|
char ver[sizeof(ISCSI_SCST_INTERFACE_VERSION)+1];
|
|
int res, rc;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
rc = copy_from_user(®, arg, sizeof(reg));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("%s", "Unable to get register info");
|
|
res = -EFAULT;
|
|
goto out;
|
|
}
|
|
|
|
rc = copy_from_user(ver, (void __user *)(unsigned long)reg.version,
|
|
sizeof(ver));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("%s", "Unable to get version string");
|
|
res = -EFAULT;
|
|
goto out;
|
|
}
|
|
ver[sizeof(ver)-1] = '\0';
|
|
|
|
if (strcmp(ver, ISCSI_SCST_INTERFACE_VERSION) != 0) {
|
|
PRINT_ERROR("Incorrect version of user space %s (expected %s)",
|
|
ver, ISCSI_SCST_INTERFACE_VERSION);
|
|
res = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
memset(®, 0, sizeof(reg));
|
|
reg.max_data_seg_len = ISCSI_CONN_IOV_MAX << PAGE_SHIFT;
|
|
|
|
/*
|
|
* In iSCSI all LUs in a session share queue depth, so let's not
|
|
* limit it too much for thousands of LUs VMware and other similar
|
|
* systems cases.
|
|
*/
|
|
#if 0
|
|
reg.max_queued_cmds = scst_get_max_lun_commands(NULL, NO_SUCH_LUN);
|
|
#else
|
|
reg.max_queued_cmds = MAX_NR_QUEUED_CMNDS;
|
|
#endif
|
|
|
|
res = 0;
|
|
|
|
rc = copy_to_user(arg, ®, sizeof(reg));
|
|
if (rc != 0) {
|
|
PRINT_ERROR("Failed to copy to user %d bytes", rc);
|
|
res = -EFAULT;
|
|
goto out;
|
|
}
|
|
|
|
out:
|
|
TRACE_EXIT_RES(res);
|
|
return res;
|
|
}
|
|
|
|
static long ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|
{
|
|
long err;
|
|
|
|
TRACE_ENTRY();
|
|
|
|
if (cmd == REGISTER_USERD) {
|
|
err = iscsi_register((void __user *)arg);
|
|
goto out;
|
|
}
|
|
|
|
err = mutex_lock_interruptible(&target_mgmt_mutex);
|
|
if (err < 0)
|
|
goto out;
|
|
|
|
switch (cmd) {
|
|
case ADD_TARGET:
|
|
err = add_target((void __user *)arg);
|
|
break;
|
|
|
|
case DEL_TARGET:
|
|
err = del_target((void __user *)arg);
|
|
break;
|
|
|
|
#ifndef CONFIG_SCST_PROC
|
|
case ISCSI_ATTR_ADD:
|
|
case ISCSI_ATTR_DEL:
|
|
err = iscsi_attr_cmd((void __user *)arg, cmd);
|
|
break;
|
|
|
|
case MGMT_CMD_CALLBACK:
|
|
err = mgmt_cmd_callback((void __user *)arg);
|
|
break;
|
|
#endif
|
|
|
|
case ISCSI_INITIATOR_ALLOWED:
|
|
err = iscsi_initiator_allowed((void __user *)arg);
|
|
break;
|
|
|
|
case ADD_SESSION:
|
|
err = add_session((void __user *)arg);
|
|
break;
|
|
|
|
case DEL_SESSION:
|
|
err = del_session((void __user *)arg);
|
|
break;
|
|
|
|
case ISCSI_PARAM_SET:
|
|
err = iscsi_params_config((void __user *)arg, 1);
|
|
break;
|
|
|
|
case ISCSI_PARAM_GET:
|
|
err = iscsi_params_config((void __user *)arg, 0);
|
|
break;
|
|
|
|
case ADD_CONN:
|
|
err = add_conn((void __user *)arg);
|
|
break;
|
|
|
|
case DEL_CONN:
|
|
err = del_conn((void __user *)arg);
|
|
break;
|
|
|
|
default:
|
|
PRINT_ERROR("Invalid ioctl cmd %x", cmd);
|
|
err = -EINVAL;
|
|
goto out_unlock;
|
|
}
|
|
|
|
out_unlock:
|
|
mutex_unlock(&target_mgmt_mutex);
|
|
|
|
out:
|
|
TRACE_EXIT_RES(err);
|
|
return err;
|
|
}
|
|
|
|
static int open(struct inode *inode, struct file *file)
|
|
{
|
|
bool already;
|
|
|
|
mutex_lock(&target_mgmt_mutex);
|
|
already = (ctr_open_state != ISCSI_CTR_OPEN_STATE_CLOSED);
|
|
if (!already)
|
|
ctr_open_state = ISCSI_CTR_OPEN_STATE_OPEN;
|
|
mutex_unlock(&target_mgmt_mutex);
|
|
|
|
if (already) {
|
|
PRINT_WARNING("%s", "Attempt to second open the control "
|
|
"device!");
|
|
return -EBUSY;
|
|
} else
|
|
return 0;
|
|
}
|
|
|
|
static int release(struct inode *inode, struct file *filp)
|
|
{
|
|
#ifndef CONFIG_SCST_PROC
|
|
struct iscsi_attr *attr, *t;
|
|
#endif
|
|
|
|
TRACE(TRACE_MGMT, "%s", "Releasing allocated resources");
|
|
|
|
mutex_lock(&target_mgmt_mutex);
|
|
ctr_open_state = ISCSI_CTR_OPEN_STATE_CLOSING;
|
|
mutex_unlock(&target_mgmt_mutex);
|
|
|
|
target_del_all();
|
|
|
|
mutex_lock(&target_mgmt_mutex);
|
|
|
|
#ifndef CONFIG_SCST_PROC
|
|
list_for_each_entry_safe(attr, t, &iscsi_attrs_list,
|
|
attrs_list_entry) {
|
|
__iscsi_del_attr(NULL, attr);
|
|
}
|
|
#endif
|
|
|
|
ctr_open_state = ISCSI_CTR_OPEN_STATE_CLOSED;
|
|
|
|
mutex_unlock(&target_mgmt_mutex);
|
|
|
|
return 0;
|
|
}
|
|
|
|
const struct file_operations ctr_fops = {
|
|
.owner = THIS_MODULE,
|
|
.unlocked_ioctl = ioctl,
|
|
.compat_ioctl = ioctl,
|
|
.open = open,
|
|
.release = release,
|
|
};
|
|
|
|
#ifdef CONFIG_SCST_DEBUG
|
|
static void iscsi_dump_char(int ch, unsigned char *text, int *pos)
|
|
{
|
|
int i = *pos;
|
|
|
|
if (ch < 0) {
|
|
while ((i % 16) != 0) {
|
|
pr_cont(" ");
|
|
text[i] = ' ';
|
|
i++;
|
|
if ((i % 16) == 0)
|
|
pr_cont(" | %.16s |\n", text);
|
|
else if ((i % 4) == 0)
|
|
pr_cont(" |");
|
|
}
|
|
i = 0;
|
|
goto out;
|
|
}
|
|
|
|
text[i] = (ch < 0x20 || (ch >= 0x80 && ch <= 0xa0)) ? ' ' : ch;
|
|
pr_cont(" %02x", ch);
|
|
i++;
|
|
if ((i % 16) == 0) {
|
|
pr_cont(" | %.16s |\n", text);
|
|
i = 0;
|
|
} else if ((i % 4) == 0)
|
|
pr_cont(" |");
|
|
|
|
out:
|
|
*pos = i;
|
|
return;
|
|
}
|
|
|
|
void iscsi_dump_pdu(struct iscsi_pdu *pdu)
|
|
{
|
|
unsigned char text[16];
|
|
int pos = 0;
|
|
|
|
if (trace_flag & TRACE_D_DUMP_PDU) {
|
|
unsigned char *buf;
|
|
int i;
|
|
|
|
buf = (void *)&pdu->bhs;
|
|
printk(KERN_DEBUG "BHS: (%p,%zd)\n", buf, sizeof(pdu->bhs));
|
|
for (i = 0; i < (int)sizeof(pdu->bhs); i++)
|
|
iscsi_dump_char(*buf++, text, &pos);
|
|
iscsi_dump_char(-1, text, &pos);
|
|
|
|
buf = (void *)pdu->ahs;
|
|
printk(KERN_DEBUG "AHS: (%p,%d)\n", buf, pdu->ahssize);
|
|
for (i = 0; i < pdu->ahssize; i++)
|
|
iscsi_dump_char(*buf++, text, &pos);
|
|
iscsi_dump_char(-1, text, &pos);
|
|
|
|
printk(KERN_DEBUG "Data: (%d)\n", pdu->datasize);
|
|
}
|
|
}
|
|
|
|
unsigned long iscsi_get_flow_ctrl_or_mgmt_dbg_log_flag(struct iscsi_cmnd *cmnd)
|
|
{
|
|
unsigned long flag;
|
|
|
|
if (cmnd->cmd_req != NULL)
|
|
cmnd = cmnd->cmd_req;
|
|
|
|
if (cmnd->scst_cmd == NULL)
|
|
flag = TRACE_MGMT_DEBUG;
|
|
else {
|
|
int status = scst_cmd_get_status(cmnd->scst_cmd);
|
|
if ((status == SAM_STAT_TASK_SET_FULL) ||
|
|
(status == SAM_STAT_BUSY))
|
|
flag = TRACE_FLOW_CONTROL;
|
|
else
|
|
flag = TRACE_MGMT_DEBUG;
|
|
}
|
|
return flag;
|
|
}
|
|
|
|
#endif /* CONFIG_SCST_DEBUG */
|