Gleb Chesnokov 59f685393d scst: Name and align function prototype arguments consistently ...

Name anonymous function and negotiation-callback parameters and match
declaration names to their definitions. This includes the misleading
length name of the CDB LBA argument. Types and calling conventions
remain unchanged. Use pool_type for the two private sysfs parameter names
so their declarations fit; structure fields and diagnostics keep their
existing names.

Drop redundant extern on function prototypes, retain it on objects, and
align continued arguments with the resulting opening parentheses.

Cppcheck reports funcArgNamesDifferent, funcArgNamesDifferentUnnamed.
One example:

  Function 'sqa_enable_tgt' argument 1 names different: declaration
  'tgt' definition 'scst_tgt'.

Checkpatch reports FUNCTION_ARGUMENTS:

  function definition argument 'const struct iscsi_key *' should also
  have an identifier name

Checkpatch reports AVOID_EXTERNS:

  extern prototypes should be avoided in .h files

Checkpatch reports PARENTHESIS_ALIGNMENT:

  Alignment should match open parenthesis

2026-10-21 22:12:25 +03:00

..

events

scst: Copy bounded strings and protocol fragments explicitly

2026-10-21 22:12:25 +03:00

fileio

scst: Avoid shadowed names and overwritten initializers

2026-10-21 22:12:25 +03:00

include

scst: Name and align function prototype arguments consistently

2026-10-21 22:12:25 +03:00

stpgd

scst: Group private macro operands and evaluate lock arguments once

2026-10-21 22:12:25 +03:00

AGENTS.md

build: Prepare device handlers for separate test objects

2026-10-14 15:08:03 +03:00

Makefile

Remove support for "make enable_proc" and "make disable_proc"

2018-11-22 22:13:40 +00:00