From 00746d6a161d6ccbaff809dca543f199cafb5162 Mon Sep 17 00:00:00 2001 From: Pavel Emelyanov Date: Fri, 7 Feb 2020 14:24:08 +0300 Subject: [PATCH] dht: Use const reference for token_metadata arg Two places in dht code have token_metadata _value_ arguments, but only read tokens from them. Optimize it a bit by turning values into const references. Signed-off-by: Pavel Emelyanov Message-Id: <20200207112408.18352-1-xemul@scylladb.com> --- dht/boot_strapper.cc | 4 ++-- dht/boot_strapper.hh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dht/boot_strapper.cc b/dht/boot_strapper.cc index a568a1493a..d285d4a7b6 100644 --- a/dht/boot_strapper.cc +++ b/dht/boot_strapper.cc @@ -72,7 +72,7 @@ future<> boot_strapper::bootstrap() { } -std::unordered_set boot_strapper::get_bootstrap_tokens(token_metadata metadata, database& db) { +std::unordered_set boot_strapper::get_bootstrap_tokens(const token_metadata& metadata, database& db) { auto initial_tokens = db.get_initial_tokens(); // if user specified tokens, use those if (initial_tokens.size() > 0) { @@ -103,7 +103,7 @@ std::unordered_set boot_strapper::get_bootstrap_tokens(token_metadata met return tokens; } -std::unordered_set boot_strapper::get_random_tokens(token_metadata metadata, size_t num_tokens) { +std::unordered_set boot_strapper::get_random_tokens(const token_metadata& metadata, size_t num_tokens) { std::unordered_set tokens; while (tokens.size() < num_tokens) { auto token = dht::token::get_random_token(); diff --git a/dht/boot_strapper.hh b/dht/boot_strapper.hh index 67122f7bd2..c07226915a 100644 --- a/dht/boot_strapper.hh +++ b/dht/boot_strapper.hh @@ -73,9 +73,9 @@ public: * otherwise, if num_tokens == 1, pick a token to assume half the load of the most-loaded node. * else choose num_tokens tokens at random */ - static std::unordered_set get_bootstrap_tokens(token_metadata metadata, database& db); + static std::unordered_set get_bootstrap_tokens(const token_metadata& metadata, database& db); - static std::unordered_set get_random_tokens(token_metadata metadata, size_t num_tokens); + static std::unordered_set get_random_tokens(const token_metadata& metadata, size_t num_tokens); #if 0 public static class StringSerializer implements IVersionedSerializer {