mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test/perf/perf_sstable: use switch-case when appropriate

Browse Source 
instead of using a chain of `if-else`, use switch-case instead,
it's visually easier to follow than `if`-`else` blocks. and since
we never need to handle the `else` case, the `throw` statement
is removed.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
This commit is contained in:
Kefu Chai
2024-08-14 17:05:39 +08:00
parent 5141c6efe0
commit 06c60f6abe
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/perf/perf_sstable.cc
View File

@@ -151,16 +151,18 @@ int scylla_sstable_main(int argc, char** argv) {
throw std::invalid_argument("Invalid mode");
}
}).then([test, mode] {
if (mode == test_modes::index_read) {
switch (mode) {
using enum test_modes;
case index_read:
return test_index_read(*test).then([test] {});
} else if (mode == test_modes::sequential_read) {
case sequential_read:
return test_sequential_read(*test).then([test] {});
} else if ((mode == test_modes::index_write) || (mode == test_modes::write)) {
case index_write:
[[fallthrough]];
case write:
return test_write(*test).then([test] {});
} else if (mode == test_modes::compaction) {
case compaction:
return test_compaction(*test).then([test] {});
} else {
throw std::invalid_argument("Invalid mode");
}
}).then([] {
return engine().exit(0);