From 0977a73ab2b1c5b2b63cd8e40eb6df8ca86f51aa Mon Sep 17 00:00:00 2001 From: Asias He Date: Mon, 22 Feb 2021 09:23:53 +0800 Subject: [PATCH] messaging_service: Move gossip ack message verb to gossip group Fix a scheduling group leak: INFO [shard 0] gossip - gossiper::run sg=gossip INFO [shard 0] gossip - gossiper::handle_ack_msg sg=statement INFO [shard 0] gossip - gossiper::handle_syn_msg sg=gossip INFO [shard 0] gossip - gossiper::handle_ack2_msg sg=gossip After the fix: INFO [shard 0] gossip - gossiper::run sg=gossip INFO [shard 0] gossip - gossiper::handle_ack_msg sg=gossip INFO [shard 0] gossip - gossiper::handle_syn_msg sg=gossip INFO [shard 0] gossip - gossiper::handle_ack2_msg sg=gossip Fixes #7986 Closes #8129 (cherry picked from commit 7018377bd75ff255e3e3201c62c605480ae98fa3) --- message/messaging_service.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/message/messaging_service.cc b/message/messaging_service.cc index 0547dd087f..68caae3f25 100644 --- a/message/messaging_service.cc +++ b/message/messaging_service.cc @@ -477,6 +477,7 @@ static constexpr unsigned do_get_rpc_client_idx(messaging_verb verb) { // as well as reduce latency as there are potentially many requests // blocked on schema version request. case messaging_verb::GOSSIP_DIGEST_SYN: + case messaging_verb::GOSSIP_DIGEST_ACK: case messaging_verb::GOSSIP_DIGEST_ACK2: case messaging_verb::GOSSIP_SHUTDOWN: case messaging_verb::GOSSIP_ECHO: @@ -511,7 +512,6 @@ static constexpr unsigned do_get_rpc_client_idx(messaging_verb verb) { case messaging_verb::READ_DATA: case messaging_verb::READ_MUTATION_DATA: case messaging_verb::READ_DIGEST: - case messaging_verb::GOSSIP_DIGEST_ACK: case messaging_verb::DEFINITIONS_UPDATE: case messaging_verb::TRUNCATE: case messaging_verb::MIGRATION_REQUEST: