From 0b91bfbcc52e2ba0b2a061cd74cd2fdcd17630ef Mon Sep 17 00:00:00 2001
From: Benny Halevy <bhalevy@scylladb.com>
Date: Wed, 10 May 2023 15:25:28 +0300
Subject: [PATCH] test: rest_api: test_storage_service: add
 test_storage_service_keyspace_cleanup_with_no_owned_ranges

Test cleanup on a keyspace after altering
it replication factor to 0.
Expect no sstables to remain.

Signed-off-by: Benny Halevy <bhalevy@scylladb.com>
---
 test/rest_api/test_storage_service.py | 56 +++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/test/rest_api/test_storage_service.py b/test/rest_api/test_storage_service.py
index 1a07998ead..32c29dcd6d 100644
--- a/test/rest_api/test_storage_service.py
+++ b/test/rest_api/test_storage_service.py
@@ -460,6 +460,62 @@ def test_storage_service_keyspace_cleanup(cql, this_dc, rest_api):
                 resp = rest_api.send("POST", f"storage_service/keyspace_cleanup/{keyspace}", { "cf": f"{test_tables[0]},XXX" })
                 assert resp.status_code == requests.codes.bad_request
 
+                resp = rest_api.send("POST", f"storage_service/keyspace_cleanup/{keyspace}")
+                resp.raise_for_status()
+
+def test_storage_service_keyspace_cleanup_with_no_owned_ranges(cql, this_dc, rest_api):
+    with new_test_keyspace(cql, f"WITH REPLICATION = {{ 'class' : 'NetworkTopologyStrategy', '{this_dc}' : 1 }}") as keyspace:
+        schema = 'p int, v text, primary key (p)'
+        with new_test_table(cql, keyspace, schema) as t0:
+            stmt = cql.prepare(f"INSERT INTO {t0} (p, v) VALUES (?, ?)")
+            cql.execute(stmt, [0, 'hello'])
+
+            # the node fixture may hold snapshots from other tests
+            # so keep the tags of the snapshots explicitly taken by this instance
+            my_snapshot_tags = dict()
+
+            def make_snapshot_tag(name):
+                tag = f"{int(time.time())}-{name}"
+                my_snapshot_tags[name] = tag
+                return tag
+
+            def snapshot_tag(name):
+                return my_snapshot_tags[name]
+
+            resp = rest_api.send("POST", f"storage_service/keyspace_flush/{keyspace}")
+            resp.raise_for_status()
+            resp = rest_api.send("POST", "storage_service/snapshots", {'kn': keyspace, 'tag': make_snapshot_tag('after-flush')})
+            resp.raise_for_status()
+
+            cql.execute(f"ALTER KEYSPACE {keyspace} WITH REPLICATION = {{ 'class' : 'NetworkTopologyStrategy', '{this_dc}' : 0 }}")
+            resp = rest_api.send("POST", "storage_service/snapshots", {'kn': keyspace, 'tag': make_snapshot_tag('after-alter-keyspace')})
+            resp.raise_for_status()
+
+            resp = rest_api.send("POST", f"storage_service/keyspace_cleanup/{keyspace}")
+            resp.raise_for_status()
+            resp = rest_api.send("POST", "storage_service/snapshots", {'kn': keyspace, 'tag': make_snapshot_tag('after-cleanup')})
+            resp.raise_for_status()
+
+            resp = rest_api.send("GET", "storage_service/snapshots")
+            resp.raise_for_status()
+            snapshots = dict()
+            for p in resp.json():
+                key = p['key']
+                assert isinstance(key, str), f"key is expected to be a string: {p}"
+                if key in my_snapshot_tags.values():
+                    value = p['value']
+                    if isinstance(value, list):
+                        assert len(value) == 1, f"Expecting a single value in {p}"
+                        value = value[0]
+                    assert isinstance(value, dict), f"value is expected to be a dict: {p}"
+                    snapshots[key] = value
+
+            print(f"snapshot metadata: {snapshots}")
+
+            assert snapshots[snapshot_tag('after-flush')]['total'] > 0, f"snapshots after flush should have non-zero data: {snapshots}"
+            assert snapshots[snapshot_tag('after-alter-keyspace')]['total'] == snapshots[snapshot_tag('after-flush')]['total'], f"snapshots after alter-keyspace should have the same data as after flush: {snapshots}"
+            assert snapshots[snapshot_tag('after-cleanup')]['total'] == 0, f"snapshots after clean should have no data: {snapshots}"
+
 def test_storage_service_keyspace_upgrade_sstables(cql, this_dc, rest_api):
     with new_test_keyspace(cql, f"WITH REPLICATION = {{ 'class' : 'NetworkTopologyStrategy', '{this_dc}' : 1 }}") as keyspace:
         schema = 'p int, v text, primary key (p)'