From 0eb66cbee5209fab220680d004d3bb88df776ec0 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Tue, 3 Sep 2024 13:11:56 +0800 Subject: [PATCH] sstables: correct the debugging message printed when removing temp dir in 372a4d1b79bb3c5d9941d7f79cd96a6eaf65deba, we introduced a change which was for debugging the logging message. but the logging message intended for printing the temp_dir not prints an `optional`. this is both confusing, and more importantly, it hurts the debuggability. in this change, the related change is reverted. Fixes scylladb/scylladb#20408 Signed-off-by: Kefu Chai (cherry picked from commit d26bb9ae302dc513b1da86178b824ea45e36c801) Closes scylladb/scylladb#20434 --- sstables/storage.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sstables/storage.cc b/sstables/storage.cc index d62176e4a4..5407735e1f 100644 --- a/sstables/storage.cc +++ b/sstables/storage.cc @@ -195,9 +195,7 @@ future<> filesystem_storage::remove_temp_dir() { if (!_temp_dir) { co_return; } - std::optional opt; - sstlog.debug("Removing temp_dir={}", opt); - //sstlog.debug("Removing temp_dir={}", _temp_dir); + sstlog.debug("Removing temp_dir={}", _temp_dir); try { co_await remove_file(_temp_dir->native()); } catch (...) {