diff --git a/sstables/sstables_manager.cc b/sstables/sstables_manager.cc index 2c4dc8e811..4d2fe4c223 100644 --- a/sstables/sstables_manager.cc +++ b/sstables/sstables_manager.cc @@ -79,7 +79,7 @@ storage_manager::object_storage_endpoint::object_storage_endpoint(db::object_sto storage_manager::storage_manager(const db::config& cfg, config stm_cfg) : _object_storage_clients_memory(stm_cfg.object_storage_clients_memory) - , _config_updater(this_shard_id() == 0 ? std::make_unique(cfg, *this) : nullptr) + , _config_updater(std::make_unique(cfg, *this)) { for (auto& e : cfg.object_storage_endpoints()) { _object_storage_endpoints.emplace(std::make_pair(e.key(), e)); @@ -170,9 +170,7 @@ std::vector storage_manager::endpoints(sstring type) const noexcept { storage_manager::config_updater::config_updater(const db::config& cfg, storage_manager& sstm) : action([&sstm, &cfg] () mutable { - return sstm.container().invoke_on_all([&cfg](auto& sstm) -> future<> { - co_await sstm.update_config(cfg); - }); + return sstm.update_config(cfg); }) , observer(cfg.object_storage_endpoints.observe(action.make_observer())) {} diff --git a/test/cluster/object_store/test_backup.py b/test/cluster/object_store/test_backup.py index 601963bfb7..0b92c478b8 100644 --- a/test/cluster/object_store/test_backup.py +++ b/test/cluster/object_store/test_backup.py @@ -166,7 +166,6 @@ async def test_backup_with_non_existing_parameters(manager: ManagerClient, objec @pytest.mark.asyncio -@pytest.mark.xfail async def test_backup_endpoint_config_is_live_updateable(manager: ManagerClient, object_storage): '''backup should fail if the endpoint is invalid/inaccessible after updating the config, it should succeed'''