From 275ed9a9bc01fdcdddfd25ecb8689a23e4f355cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Botond=20D=C3=A9nes?= Date: Mon, 22 Apr 2024 10:40:28 -0400 Subject: [PATCH] replica/mutation_dump: create_underlying_mutation_sources(): remove false move transformed_cr is moved in a loop, in each iteration. This is harmless because the variable is const and the move has no effect, yet it is confusing to readers and triggers false positives in clang-tidy (moved-from object reused). Remove it. Fixes: #18322 Closes scylladb/scylladb#18348 --- replica/mutation_dump.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/replica/mutation_dump.cc b/replica/mutation_dump.cc index 6d6375c849..1d5fbb324e 100644 --- a/replica/mutation_dump.cc +++ b/replica/mutation_dump.cc @@ -184,7 +184,7 @@ private: auto& e = prepared_mutation_sources[ms_it->first]; e.ms = ms_it->second; maybe_push(e.region_intervals, region_int, std::compare_three_way{}); - maybe_push(e.underlying_crs, std::move(transformed_cr), clustering_key_view::tri_compare(*_underlying_schema)); + maybe_push(e.underlying_crs, transformed_cr, clustering_key_view::tri_compare(*_underlying_schema)); ++ms_it; } }