From 293cf355df875f1c66fb2b8abe04b9bd9b2aea17 Mon Sep 17 00:00:00 2001 From: Andrei Chekun Date: Mon, 10 Jun 2024 15:47:20 +0200 Subject: [PATCH] [test.py] Fix log for failed node was nod added to failed directory If something happens during nod adding to the cluster, it will not be registered as a part of the cluster. This leads to situations during log gathering that logs for a such node will be missing. --- test/pylib/scylla_cluster.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/pylib/scylla_cluster.py b/test/pylib/scylla_cluster.py index aea9a16922..abb59df24f 100644 --- a/test/pylib/scylla_cluster.py +++ b/test/pylib/scylla_cluster.py @@ -917,10 +917,11 @@ class ScyllaCluster: self.leased_ips.remove(ip_addr) await self.host_registry.release_host(Host(ip_addr)) raise - if start and not expected_error: - self.running[server.server_id] = server - else: - self.stopped[server.server_id] = server + finally: + if start and not expected_error: + self.running[server.server_id] = server + else: + self.stopped[server.server_id] = server self.logger.info("Cluster %s added %s", self, server) return ServerInfo(server.server_id, server.ip_addr, server.rpc_address)