From 2ce409dca08ae852b7ea5c74b8cc7404f9a4efe5 Mon Sep 17 00:00:00 2001 From: Piotr Smaron Date: Tue, 31 Mar 2026 16:48:25 +0200 Subject: [PATCH] test: clean up fuzzy_test_config and add comments Remove the unused timeout field from fuzzy_test_config. It was declared, initialized per build mode, and logged, but never actually enforced anywhere. Document the intentionally small max_size (1024 bytes) passed to read_partitions_with_paged_scan in run_fuzzy_test_scan: it forces many pages per scan to stress the paging and result-merging logic. --- test/boost/multishard_query_test.cc | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/test/boost/multishard_query_test.cc b/test/boost/multishard_query_test.cc index 0a72af9059..3e6b706721 100644 --- a/test/boost/multishard_query_test.cc +++ b/test/boost/multishard_query_test.cc @@ -1045,7 +1045,6 @@ validate_result_size(size_t i, schema_ptr schema, const utils::chunked_vector& testlog.debug("[scan#{}]: seed={}, is_stateful={}, prange={}, ckranges={}", i, seed, is_stateful, partition_range, partition_slice.default_row_ranges()); + // Use a small max_size to force many pages per scan, stressing the + // paging and result-merging logic. With the large row limit here, + // the byte limit is typically the tighter bound. const auto [results, npages] = read_partitions_with_paged_scan(db, schema, 1000, 1024, is_stateful, partition_range, partition_slice); const auto expected_partitions = slice_partitions(*schema, mutations, partition_index_range, partition_slice); @@ -1173,14 +1175,14 @@ SEASTAR_THREAD_TEST_CASE(fuzzy_test) { tests::default_timestamp_generator()); #if defined DEBUG - auto cfg = fuzzy_test_config{seed, std::chrono::seconds{8}, 1, 1}; + auto cfg = fuzzy_test_config{seed, 1, 1}; #elif defined DEVEL - auto cfg = fuzzy_test_config{seed, std::chrono::seconds{2}, 2, 4}; + auto cfg = fuzzy_test_config{seed, 2, 4}; #else - auto cfg = fuzzy_test_config{seed, std::chrono::seconds{2}, 4, 8}; + auto cfg = fuzzy_test_config{seed, 4, 8}; #endif - testlog.info("Running test workload with configuration: seed={}, timeout={}s, concurrency={}, scans={}", cfg.seed, cfg.timeout.count(), + testlog.info("Running test workload with configuration: seed={}, concurrency={}, scans={}", cfg.seed, cfg.concurrency, cfg.scans); smp::invoke_on_all([cfg, db = &env.db(), gs = global_schema_ptr(tbl.schema), &compacted_frozen_mutations = tbl.compacted_frozen_mutations] {