mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

logalloc: Add disable_failure_guard during a few tls variable initialization

Browse Source 
The constructors of these global variables can allocate memory. Since
the variables are thread_local, they are initialized at first use.

There is nothing we can do if these allocations fail, so use
disable_failure_guard.

Signed-off-by: Rafael Ávila de Espíndola <espindola@scylladb.com>
Message-Id: <20200729184901.205646-1-espindola@scylladb.com>
This commit is contained in:
Rafael Ávila de Espíndola
2020-07-29 11:49:01 -07:00
committed by Tomasz Grabiec
parent 14b279020b
commit 30722b8c8e
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
utils/logalloc.cc
View File

@@ -184,7 +184,8 @@ public:
static
migrators&
static_migrators() {
static_migrators() noexcept {
memory::disable_failure_guard dfg;
static thread_local lw_shared_ptr<migrators> obj = make_lw_shared<migrators>();
return *obj;
}
@@ -348,7 +349,14 @@ struct segment;
static logging::logger llogger("lsa");
static logging::logger timing_logger("lsa-timing");
static thread_local tracker tracker_instance;
static tracker& get_tracker_instance() noexcept {
memory::disable_failure_guard dfg;
static thread_local tracker obj;
return obj;
}
static thread_local tracker& tracker_instance = get_tracker_instance();
using clock = std::chrono::steady_clock;
@@ -942,7 +950,13 @@ size_t segment_pool::segments_in_use() const {
return _segments_in_use;
}
static thread_local segment_pool shard_segment_pool;
static segment_pool& get_shard_segment_pool() noexcept {
memory::disable_failure_guard dfg;
static thread_local segment_pool obj;
return obj;
}
static thread_local segment_pool& shard_segment_pool = get_shard_segment_pool();
void segment::record_alloc(segment::size_type size) {
shard_segment_pool.descriptor(this).record_alloc(size);