From 3a31380b2cab4cdce57355898eb54041b4e5a0f2 Mon Sep 17 00:00:00 2001 From: Ernest Zaslavsky Date: Tue, 6 Jan 2026 18:33:41 +0200 Subject: [PATCH] dns_connection_factory: refine the move constructor Clean up the awkward move constructor that was declared in the header but defaulted in a separate compilation unit, improving clarity and consistency. --- utils/http.cc | 2 -- utils/http.hh | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/utils/http.cc b/utils/http.cc index 96d12f24c4..db1b12e44a 100644 --- a/utils/http.cc +++ b/utils/http.cc @@ -79,8 +79,6 @@ future utils::http::dns_connection_factory::connect(net::inet_ co_return co_await seastar::connect(socket_addr, {}, transport::TCP); } -utils::http::dns_connection_factory::dns_connection_factory(dns_connection_factory&&) = default; - utils::http::dns_connection_factory::dns_connection_factory(std::string host, int port, bool use_https, logging::logger& logger, shared_ptr certs) : _host(std::move(host)) , _port(port) diff --git a/utils/http.hh b/utils/http.hh index 3a49481b54..ba92f0810f 100644 --- a/utils/http.hh +++ b/utils/http.hh @@ -40,7 +40,7 @@ protected: future> get_creds(); future connect(net::inet_address address); public: - dns_connection_factory(dns_connection_factory&&); + dns_connection_factory(dns_connection_factory&&) = default; dns_connection_factory(std::string host, int port, bool use_https, logging::logger& logger, shared_ptr = {}); dns_connection_factory(std::string endpoint_url, logging::logger& logger, shared_ptr = {});