From 3c25e6fcb4a0bed3be6fa35fc0fbbaef08c48848 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Botond=20D=C3=A9nes?= Date: Mon, 28 Oct 2024 10:06:28 -0400 Subject: [PATCH] db/config: introduce enable_repair_multishard_reader_buffer_hint Allows enabling/disabling the multishard reader buffer hint optimization. Not wired yet. --- db/config.cc | 2 ++ db/config.hh | 1 + 2 files changed, 3 insertions(+) diff --git a/db/config.cc b/db/config.cc index e188028707..6a69db4ef0 100644 --- a/db/config.cc +++ b/db/config.cc @@ -980,6 +980,8 @@ db::config::config(std::shared_ptr exts) , repair_partition_count_estimation_ratio(this, "repair_partition_count_estimation_ratio", liveness::LiveUpdate, value_status::Used, 0.1, "Specify the fraction of partitions written by repair out of the total partitions. The value is currently only used for bloom filter estimation. Value is between 0 and 1.") , repair_hints_batchlog_flush_cache_time_in_ms(this, "repair_hints_batchlog_flush_cache_time_in_ms", liveness::LiveUpdate, value_status::Used, 60 * 1000, "The repair hints and batchlog flush request cache time. Setting 0 disables the flush cache. The cache reduces the number of hints and batchlog flushes during repair when tombstone_gc is set to repair mode. When the cache is on, a slightly smaller repair time will be used with the benefits of dropped hints and batchlog flushes.") + , repair_multishard_reader_buffer_hint_size(this, "repair_multishard_reader_buffer_hint_size", liveness::LiveUpdate, value_status::Used, 1 * 1024 * 1024, + "The buffer size to use for the buffer-hint feature of the multishard reader when running repair in mixed-shard clusters. This can help the performance of mixed-shard repair (including RBNO). Set to 0 to disable the hint feature altogether.") , ring_delay_ms(this, "ring_delay_ms", value_status::Used, 30 * 1000, "Time a node waits to hear from other nodes before joining the ring in milliseconds. Same as -Dcassandra.ring_delay_ms in cassandra.") , shadow_round_ms(this, "shadow_round_ms", value_status::Used, 300 * 1000, "The maximum gossip shadow round time. Can be used to reduce the gossip feature check time during node boot up.") , fd_max_interval_ms(this, "fd_max_interval_ms", value_status::Used, 2 * 1000, "The maximum failure_detector interval time in milliseconds. Interval larger than the maximum will be ignored. Larger cluster may need to increase the default.") diff --git a/db/config.hh b/db/config.hh index 8d6e14451e..100ea3879b 100644 --- a/db/config.hh +++ b/db/config.hh @@ -342,6 +342,7 @@ public: named_value enable_tombstone_gc_for_streaming_and_repair; named_value repair_partition_count_estimation_ratio; named_value repair_hints_batchlog_flush_cache_time_in_ms; + named_value repair_multishard_reader_buffer_hint_size; named_value ring_delay_ms; named_value shadow_round_ms; named_value fd_max_interval_ms;