mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

main: Run init_server and join_cluster inside maintenance scheduling group

Browse Source 
Currently, init_server and join_cluster which initiate the bootstrap and
replace operations on the new node run inside the main scheduling group.
We should run them inside the maintenance scheduling group to reduce the
impact on the user workload.

This patch fixes a scheduling group leak for bootstrap and replace operation.

Before:
[shard 0] storage_service - storage_service::bootstrap sg=main
[shard 0] repair - bootstrap_with_repair sg=main

After:
[shard 0] storage_service - storage_service::bootstrap sg=streaming
[shard 0] repair - bootstrap_with_repair sg=streaming

Fixes #8130

Closes #8131
This commit is contained in:
Asias He
2021-02-22 10:40:07 +08:00
committed by Avi Kivity
parent a24f83852e
commit 554ab035dd
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
main.cc
View File

@@ -1088,9 +1088,15 @@ int main(int ac, char** av) {
sys_dist_ks.start(std::ref(qp), std::ref(mm), std::ref(proxy)).get();
ss.init_server().get();
with_scheduling_group(maintenance_scheduling_group, [&] {
return ss.init_server();
}).get();
sst_format_selector.sync();
ss.join_cluster().get();
with_scheduling_group(maintenance_scheduling_group, [&] {
return ss.join_cluster();
}).get();
supervisor::notify("starting tracing");
tracing::tracing::start_tracing(qp).get();