mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

service: storage_proxy: do not report abort requests in handle_write

Browse Source 
We don't want to report aborts in storage_proxy::handle_write, because it
can be only triggered by shutdowns and timeouts.

Before this change, such reports flooded logs when a drained node still
received the write RPCs.
This commit is contained in:
Patryk Jędrzejczak
2023-07-12 13:35:22 +02:00
parent f9db9f5943
commit 56bd9b5db3
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
service/storage_proxy.cc
View File

@@ -482,8 +482,10 @@ private:
errors.count++;
errors.local = replica::try_encode_replica_exception(eptr);
seastar::log_level l = seastar::log_level::warn;
if (is_timeout_exception(eptr) || std::holds_alternative<replica::rate_limit_exception>(errors.local.reason)) {
// ignore timeouts and rate limit exceptions so that logs are not flooded.
if (is_timeout_exception(eptr)
|| std::holds_alternative<replica::rate_limit_exception>(errors.local.reason)
|| std::holds_alternative<abort_requested_exception>(errors.local.reason)) {
// ignore timeouts, abort requests and rate limit exceptions so that logs are not flooded.
// database's total_writes_timedout or total_writes_rate_limited counter was incremented.
l = seastar::log_level::debug;
}