mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-29 11:10:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

db/commitlog: Extend error messages for corrupted data

Browse Source 
We're providing additional information in error messages when throwing
an exception related to data corruption: when a segment is truncated
and when it's content is invalid. That might prove helpful when debugging.

Closes scylladb/scylladb#25190

(cherry picked from commit 408b45fa7e)

Closes scylladb/scylladb#25459
This commit is contained in:
Dawid Mędrek
2025-07-25 16:33:59 +02:00
committed by Pavel Emelyanov
parent 38f4c3325d
commit 69307eaf2d
2 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
db/commitlog/commitlog.cc
View File

@@ -3252,9 +3252,13 @@ const db::commitlog::config& db::commitlog::active_config() const {
return _segment_manager->cfg;
}
db::commitlog::segment_data_corruption_error::segment_data_corruption_error(std::string_view msg, uint64_t s)
: _msg(fmt::format("Segment data corruption: {}", msg))
, _bytes(s)
{}
db::commitlog::segment_truncation::segment_truncation(uint64_t pos)
: _msg(fmt::format("Segment truncation at {}", pos))
db::commitlog::segment_truncation::segment_truncation(std::string_view reason, uint64_t pos)
: _msg(fmt::format("Segment truncation at {}. Reason: {}", pos, reason))
, _pos(pos)
{}
@@ -3444,7 +3448,8 @@ db::commitlog::read_log_file(const replay_state& state, sstring filename, sstrin
while (rem < size) {
if (eof) {
throw segment_truncation(block_boundry);
auto reason = fmt::format("unexpected EOF, rem={}, size={}", rem, size);
throw segment_truncation(std::move(reason), block_boundry);
}
auto block_size = alignment - initial.size_bytes();
@@ -3455,7 +3460,8 @@ db::commitlog::read_log_file(const replay_state& state, sstring filename, sstrin
if (tmp.size_bytes() == 0) {
eof = true;
throw segment_truncation(block_boundry);
auto reason = fmt::format("read 0 bytes, while tried to read {}", block_size);
throw segment_truncation(std::move(reason), block_boundry);
}
crc32_nbo crc;
@@ -3490,10 +3496,12 @@ db::commitlog::read_log_file(const replay_state& state, sstring filename, sstrin
auto checksum = crc.checksum();
if (check != checksum) {
throw segment_data_corruption_error("Data corruption", alignment);
auto reason = fmt::format("checksums do not match: {:x} vs. {:x}", check, checksum);
throw segment_data_corruption_error(std::move(reason), alignment);
}
if (id != this->id) {
throw segment_truncation(pos + rem);
auto reason = fmt::format("IDs do not match: {} vs. {}", id, this->id);
throw segment_truncation(std::move(reason), pos + rem);
}
}
tmp.remove_suffix(detail::sector_overhead_size);
@@ -3768,7 +3776,8 @@ db::commitlog::read_log_file(const replay_state& state, sstring filename, sstrin
co_await read_chunk();
}
if (corrupt_size > 0) {
throw segment_data_corruption_error("Data corruption", corrupt_size);
auto reason = fmt::format("corrupted size while reading file: {}", corrupt_size);
throw segment_data_corruption_error(std::move(reason), corrupt_size);
}
} catch (...) {
p = std::current_exception();