diff --git a/audit/audit.cc b/audit/audit.cc index 852d44b511..5d3744781c 100644 --- a/audit/audit.cc +++ b/audit/audit.cc @@ -113,8 +113,8 @@ static category_set parse_audit_categories(const sstring& data) { return result; } -static std::map> parse_audit_tables(const sstring& data) { - std::map> result; +static audit::audited_tables_t parse_audit_tables(const sstring& data) { + audit::audited_tables_t result; if (!data.empty()) { std::vector tokens; boost::split(tokens, data, boost::is_any_of(",")); @@ -139,8 +139,8 @@ static std::map> parse_audit_tables(const sstring& da return result; } -static std::set parse_audit_keyspaces(const sstring& data) { - std::set result; +static audit::audited_keyspaces_t parse_audit_keyspaces(const sstring& data) { + audit::audited_keyspaces_t result; if (!data.empty()) { std::vector tokens; boost::split(tokens, data, boost::is_any_of(",")); @@ -156,8 +156,8 @@ audit::audit(locator::shared_token_metadata& token_metadata, cql3::query_processor& qp, service::migration_manager& mm, std::set&& audit_modes, - std::set&& audited_keyspaces, - std::map>&& audited_tables, + audited_keyspaces_t&& audited_keyspaces, + audited_tables_t&& audited_tables, category_set&& audited_categories, const db::config& cfg) : _token_metadata(token_metadata) @@ -165,8 +165,8 @@ audit::audit(locator::shared_token_metadata& token_metadata, , _audited_tables(std::move(audited_tables)) , _audited_categories(std::move(audited_categories)) , _cfg(cfg) - , _cfg_keyspaces_observer(cfg.audit_keyspaces.observe([this] (sstring const& new_value){ update_config>(new_value, parse_audit_keyspaces, _audited_keyspaces); })) - , _cfg_tables_observer(cfg.audit_tables.observe([this] (sstring const& new_value){ update_config>>(new_value, parse_audit_tables, _audited_tables); })) + , _cfg_keyspaces_observer(cfg.audit_keyspaces.observe([this] (sstring const& new_value){ update_config(new_value, parse_audit_keyspaces, _audited_keyspaces); })) + , _cfg_tables_observer(cfg.audit_tables.observe([this] (sstring const& new_value){ update_config(new_value, parse_audit_tables, _audited_tables); })) , _cfg_categories_observer(cfg.audit_categories.observe([this] (sstring const& new_value){ update_config(new_value, parse_audit_categories, _audited_categories); })) { _storage_helper_ptr = create_storage_helper(std::move(audit_modes), qp, mm); @@ -181,8 +181,8 @@ future<> audit::start_audit(const db::config& cfg, sharded(); } category_set audited_categories = parse_audit_categories(cfg.audit_categories()); - std::map> audited_tables = parse_audit_tables(cfg.audit_tables()); - std::set audited_keyspaces = parse_audit_keyspaces(cfg.audit_keyspaces()); + audit::audited_tables_t audited_tables = parse_audit_tables(cfg.audit_tables()); + audit::audited_keyspaces_t audited_keyspaces = parse_audit_keyspaces(cfg.audit_keyspaces()); logger.info("Audit is enabled. Auditing to: \"{}\", with the following categories: \"{}\", keyspaces: \"{}\", and tables: \"{}\"", cfg.audit(), cfg.audit_categories(), cfg.audit_keyspaces(), cfg.audit_tables()); diff --git a/audit/audit.hh b/audit/audit.hh index 3663949153..bf81cdd607 100644 --- a/audit/audit.hh +++ b/audit/audit.hh @@ -129,10 +129,15 @@ public: class storage_helper; class audit final : public seastar::async_sharded_service { +public: + // Transparent comparator (std::less<>) enables heterogeneous lookup with + // string_view keys. + using audited_keyspaces_t = std::set>; + using audited_tables_t = std::map>, std::less<>>; +private: locator::shared_token_metadata& _token_metadata; - std::set _audited_keyspaces; - // Maps keyspace name to set of table names in that keyspace - std::map> _audited_tables; + audited_keyspaces_t _audited_keyspaces; + audited_tables_t _audited_tables; category_set _audited_categories; std::unique_ptr _storage_helper_ptr; @@ -164,8 +169,8 @@ public: cql3::query_processor& qp, service::migration_manager& mm, std::set&& audit_modes, - std::set&& audited_keyspaces, - std::map>&& audited_tables, + audited_keyspaces_t&& audited_keyspaces, + audited_tables_t&& audited_tables, category_set&& audited_categories, const db::config& cfg); ~audit();