From 83cea04d35c7d14872753307ecdf79a685b15bc7 Mon Sep 17 00:00:00 2001 From: Amnon Heiman Date: Tue, 17 Sep 2024 17:24:03 +0300 Subject: [PATCH] alternator:test_metrics test metrics for batch item count This patch adds tests for the batch operations item count. The tests validate that the metrics tracking the number of items processed in a batch increase by the correct amount. Signed-off-by: Amnon Heiman (cherry picked from commit 8dec292698b6e90c66941b6934206f63335d5da6) --- test/alternator/test_metrics.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/alternator/test_metrics.py b/test/alternator/test_metrics.py index f5d083006c..2026e3fc88 100644 --- a/test/alternator/test_metrics.py +++ b/test/alternator/test_metrics.py @@ -128,6 +128,16 @@ def test_batch_get_item(test_table_s, metrics): test_table_s.meta.client.batch_get_item(RequestItems = { test_table_s.name: {'Keys': [{'p': random_string()}], 'ConsistentRead': True}}) +def test_batch_write_item_count(test_table_s, metrics): + with check_increases_operation(metrics, ['BatchWriteItem'], metric_name='scylla_alternator_batch_item_count', expected_value=2): + test_table_s.meta.client.batch_write_item(RequestItems = { + test_table_s.name: [{'PutRequest': {'Item': {'p': random_string(), 'a': 'hi'}}}, {'PutRequest': {'Item': {'p': random_string(), 'a': 'hi'}}}]}) + +def test_batch_get_item_count(test_table_s, metrics): + with check_increases_operation(metrics, ['BatchGetItem'], metric_name='scylla_alternator_batch_item_count', expected_value=2): + test_table_s.meta.client.batch_get_item(RequestItems = { + test_table_s.name: {'Keys': [{'p': random_string()}, {'p': random_string()}], 'ConsistentRead': True}}) + # Test counters for CreateTable, DescribeTable, UpdateTable and DeleteTable def test_table_operations(dynamodb, metrics): with check_increases_operation(metrics, ['CreateTable', 'DescribeTable', 'UpdateTable', 'DeleteTable']):