From 947e28146d753ca080d59109effd534e2593a2a2 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sat, 29 Jun 2024 23:22:59 +0800 Subject: [PATCH] dbuild: pass --tty when running in interactive mode podman does not allocate a tty by default, so without `-t` or `--tty`, one cannot use a functional terminal when interacting with the container. that what one can expect when running `dbuild -i --`, and we are greeted with : ``` bash: cannot set terminal process group (-1): Inappropriate ioctl for device bash: no job control in this shell ``` after this change, one can enjoy the good-old terminal as usual after being dropped to the container provided by `dbuild -i --`. Signed-off-by: Kefu Chai Closes scylladb/scylladb#19550 --- tools/toolchain/dbuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/toolchain/dbuild b/tools/toolchain/dbuild index f8c39f9cff..0b0c5c9b3f 100755 --- a/tools/toolchain/dbuild +++ b/tools/toolchain/dbuild @@ -224,7 +224,7 @@ if [[ -n "$interactive" || -n "$is_podman" ]]; then # We also avoid detached mode with podman, which doesn't need it # (it does not proxy SIGTERM) and doesn't work well with it. - $tool run --rm "${docker_common_args[@]}" + $tool run --tty --rm "${docker_common_args[@]}" ret=$? cleanup exit $ret