From 97f85e52f7aebf5c52fa2ae8967da1972dcc289d Mon Sep 17 00:00:00 2001 From: Benny Halevy Date: Tue, 5 Nov 2024 13:41:57 +0200 Subject: [PATCH] view: get_view_natural_endpoint: clarify documentation "self-pairing" is enabled only when use_legacy_self_pairing is enabled. That is currently unclear in the documentation comment for this function. Signed-off-by: Benny Halevy --- db/view/view.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/db/view/view.cc b/db/view/view.cc index 049fdfa534..c775f921e2 100644 --- a/db/view/view.cc +++ b/db/view/view.cc @@ -1723,8 +1723,10 @@ bool should_generate_view_updates_on_this_shard(const schema_ptr& base, const lo // // If the keyspace's replication strategy is a NetworkTopologyStrategy, // we pair only nodes in the same datacenter. -// If one of the base replicas also happens to be a view replica, it is -// paired with itself (with the other nodes paired by order in the list +// +// When use_legacy_self_pairing is enabled, if one of the base replicas +// also happens to be a view replica, it is paired with itself +// (with the other nodes paired by order in the list // after taking this node out). // // If the assumption that the given base token belongs to this replica