From a6cf45f9e2a0eaac60a6179078fdfad7f8d59b92 Mon Sep 17 00:00:00 2001 From: Yaniv Kaul Date: Sun, 12 Apr 2026 20:16:21 +0300 Subject: [PATCH] data_dictionary: fix swapped arguments in extraneous options error The format string says "Extraneous options for {type}: {values}" but the arguments were passed in the wrong order (values first, type second), producing misleading error messages like "Extraneous options for bucket,endpoint: S3" instead of "Extraneous options for S3: bucket,endpoint". Signed-off-by: Yaniv Kaul --- data_dictionary/data_dictionary.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data_dictionary/data_dictionary.cc b/data_dictionary/data_dictionary.cc index e70183ea5b..f6ffae9a00 100644 --- a/data_dictionary/data_dictionary.cc +++ b/data_dictionary/data_dictionary.cc @@ -339,7 +339,7 @@ static storage_options::object_storage object_storage_from_map(std::string_view } if (values.size() > allowed_options.size()) { throw std::runtime_error(fmt::format("Extraneous options for {}: {}; allowed: {}", - fmt::join(values | std::views::keys, ","), type, + type, fmt::join(values | std::views::keys, ","), fmt::join(allowed_options | std::views::keys, ","))); } options.type = std::string(type);