mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

table: seal_active_memtable: handle ENOSPC error

Browse Source 
Aborting too soon on ENOSPC is too harsh, leading to loss of
availability of the node for reads, while restarting it won't
solve the ENOSPC condition.

Fixes #11245

Signed-off-by: Benny Halevy <bhalevy@scylladb.com>

Closes #11246
This commit is contained in:
Benny Halevy
2022-08-09 10:34:50 +03:00
committed by Tomasz Grabiec
parent 9c4e32d2e2
commit a980510654
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
replica/table.cc
View File

@@ -584,7 +584,8 @@ table::seal_active_memtable(flush_permit&& flush_permit) noexcept {
auto permit = std::move(flush_permit);
auto r = exponential_backoff_retry(100ms, 10s);
// Try flushing for around half an hour (30 minutes every 10 seconds)
int allowed_retries = 30 * 60 / 10;
int default_retries = 30 * 60 / 10;
int allowed_retries = default_retries;
std::optional<utils::phased_barrier::operation> op;
size_t memtable_size;
future<> previous_flush = make_ready_future<>();
@@ -612,6 +613,13 @@ table::seal_active_memtable(flush_permit&& flush_permit) noexcept {
if (allowed_retries-- <= 0) {
abort_on_error();
}
} else if (auto ep = try_catch<std::system_error>(ex)) {
if (ep->code().value() == ENOSPC) {
// Keep on trying
allowed_retries = default_retries;
} else {
abort_on_error();
}
} else {
abort_on_error();
}
@@ -679,7 +687,7 @@ table::seal_active_memtable(flush_permit&& flush_permit) noexcept {
auto write_permit = permit.release_sstable_write_permit();
utils::get_local_injector().inject("table_seal_active_memtable_try_flush", []() {
throw std::bad_alloc();
throw std::system_error(ENOSPC, std::system_category(), "Injected error");
});
co_return co_await this->try_flush_memtable_to_sstable(old, std::move(write_permit));
});