mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

commitlog: use commitlog priority for replay

Browse Source 
Right now replay is being issued with the standard seastar priority.
The rationale for that at the time is that it is an early event that
doesn't really share the disk with anybody.

That is largely untrue now that we start compactions on boot.
Compactions may fight for bandwidth with the commitlog, and with such
low priority the commitlog is guaranteed to lose.

Fixes #1856

Signed-off-by: Glauber Costa <glauber@scylladb.com>
This commit is contained in:
Glauber Costa
2016-11-17 12:32:48 -05:00
parent 4d3d774757
commit aa375cd33d
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
db/commitlog/commitlog.cc
View File

@@ -1538,6 +1538,15 @@ db::commitlog::read_log_file(const sstring& filename, commit_load_reader_func ne
subscription<temporary_buffer<char>, db::replay_position>
db::commitlog::read_log_file(file f, commit_load_reader_func next, position_type off) {
struct work {
private:
file_input_stream_options make_file_input_stream_options() {
file_input_stream_options fo;
fo.buffer_size = db::commitlog::segment::default_size;
fo.read_ahead = 0;
fo.io_priority_class = service::get_local_commitlog_priority();
return fo;
}
public:
file f;
stream<temporary_buffer<char>, replay_position> s;
input_stream<char> fin;
@@ -1554,7 +1563,7 @@ db::commitlog::read_log_file(file f, commit_load_reader_func next, position_type
bool failed = false;
work(file f, position_type o = 0)
: f(f), fin(make_file_input_stream(f)), start_off(o) {
: f(f), fin(make_file_input_stream(f, o, make_file_input_stream_options())), start_off(o) {
}
work(work&&) = default;