From b217a5e43a4e08e5317eaf22572c4bebd2ceffcc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20M=C4=99drek?= Date: Thu, 6 Nov 2025 16:57:47 +0100 Subject: [PATCH] test: Disable maintenance mode correctly in test_maintenance_mode.py Although setting the value of `maintenance_mode` to the string `"false"` disables maintenance mode, the testing framework misinterprets the value and thinks that it's actually enabled. As a result, it might try to connect to Scylla via the maintenance socket, which we don't want. (cherry picked from commit 394207fd69f62d02ae3e77935eb21433b43a1d27) --- test/topology_custom/test_maintenance_mode.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/topology_custom/test_maintenance_mode.py b/test/topology_custom/test_maintenance_mode.py index 292dfcf465..9b234ccd8a 100644 --- a/test/topology_custom/test_maintenance_mode.py +++ b/test/topology_custom/test_maintenance_mode.py @@ -90,7 +90,7 @@ async def test_maintenance_mode(manager: ManagerClient): await manager.server_stop_gracefully(server_a.server_id) # Restart in normal mode to see if the changes made in maintenance mode are persisted - await manager.server_update_config(server_a.server_id, "maintenance_mode", "false") + await manager.server_update_config(server_a.server_id, "maintenance_mode", False) await manager.server_start(server_a.server_id, wait_others=1) await wait_for_cql_and_get_hosts(cql, [server_a], time.time() + 60) await manager.servers_see_each_other([server_a, server_b])