From b348014745a2f7d85369ebfce931945fbadd8a72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patryk=20J=C4=99drzejczak?= Date: Mon, 15 Jan 2024 15:58:55 +0100 Subject: [PATCH] test: test_topology_ops: remove failed mutations filter We added this filter after detecting a bug in the Raft-based topology. We weren't sending `barrier_and_drain` commands to a decommissioning node that could still be coordinating requests. It could cause stale topology exceptions on replicas if the decommissioning node sent a request with an old topology version after normal nodes received the new fence version. This bug has been fixed in the previous commit, so we remove the filter. --- test/topology_experimental_raft/test_topology_ops.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/topology_experimental_raft/test_topology_ops.py b/test/topology_experimental_raft/test_topology_ops.py index 264b275812..b7aeee82a1 100644 --- a/test/topology_experimental_raft/test_topology_ops.py +++ b/test/topology_experimental_raft/test_topology_ops.py @@ -75,8 +75,7 @@ async def test_topology_ops(request, manager: ManagerClient): async def check_node_log_for_failed_mutations(manager: ManagerClient, server: ServerInfo): logger.info(f"Checking that node {server} had no failed mutations") log = await manager.server_open_log(server.server_id) - occurrences = await log.grep(expr="Failed to apply mutation from", \ - filter_expr="replica::stale_topology_exception") # Disabled due to #15804 + occurrences = await log.grep(expr="Failed to apply mutation from") assert len(occurrences) == 0