mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-02 06:05:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: extend test_batchlog_replay_failure_during_repair

Browse Source 
Modify test_batchlog_replay_failure_during_repair to also check
that there isn't data resurrection if flushing hints falls within
the repair cache timeout.

(cherry picked from commit e3dcb7e827)
This commit is contained in:
Aleksandra Martyniuk
2025-11-14 14:18:04 +01:00
parent 11cab796a7
commit b5dae10acb
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/topology_custom/test_batchlog_manager.py
View File

@@ -295,7 +295,8 @@ async def test_drop_mutations_for_dropped_table(manager: ManagerClient) -> None:
@pytest.mark.asyncio
@skip_mode("release", "error injections are not supported in release mode")
async def test_batchlog_replay_failure_during_repair(manager: ManagerClient) -> None:
@pytest.mark.parametrize("repair_cache", [True, False])
async def test_batchlog_replay_failure_during_repair(manager: ManagerClient, repair_cache: bool) -> None:
"""
We want to verify that repair_time will not be updated if batchlog replay fails.
@@ -315,7 +316,7 @@ async def test_batchlog_replay_failure_during_repair(manager: ManagerClient) ->
cmdline=['--enable-cache', '0',
"--hinted-handoff-enabled", "0",
"--logger-log-level", "batchlog_manager=trace:repair=debug",
"--repair-hints-batchlog-flush-cache-time-in-ms", "0"]
"--repair-hints-batchlog-flush-cache-time-in-ms", "1000000" if repair_cache else "0"]
config = {"error_injections_at_startup": ["short_batchlog_manager_replay_interval"],
"write_request_timeout_in_ms": 2000,
'group0_tombstone_gc_refresh_interval_in_ms': 1000,
@@ -390,6 +391,9 @@ async def test_batchlog_replay_failure_during_repair(manager: ManagerClient) ->
# be triggered from now on (if it's present).
await disable_injection("skip_batch_replay")
await s1_log.wait_for("Batchlog replay on shard 0: done", timeout=60, from_mark=s1_mark)
await s1_log.wait_for("Batchlog replay on shard 1: done", timeout=60, from_mark=s1_mark)
await manager.api.repair(s1.ip_addr, ks, "my_table")
await manager.api.flush_keyspace(s1.ip_addr, ks)